Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inspector] EUI Visual Refresh Integration #204436

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Dec 16, 2024

Summary

Related to #203132.
Closes #204595.

This replaces all references to euiThemeVars in favor of the useEuiTheme hook in the inspector plugin.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@cqliu1 cqliu1 changed the title Replace euiThemeVars in inspector [Inspector] EUI Visual Refresh Integration Dec 17, 2024
@cqliu1 cqliu1 added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas EUI Visual Refresh Feature:Inspector Inspector infrastructure and implementations release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels EUI Visual Refresh Feature:Inspector Inspector infrastructure and implementations release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Inspector] EUI Visual Refresh and QA
2 participants