Fixing inference service test deprecation warning in search tests #204386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12360365294 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 16, 2024
…astic#204386) Adds a `model_id` property to the model config and renames the service to `elasticsearch`, as `elser` has been deprecated. This should avoid triggering API deprecation warning. (cherry picked from commit 49a5b2f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 16, 2024
…ts (#204386) (#204480) # Backport This will backport the following commits from `main` to `8.x`: - [Fixing inference service test deprecation warning in search tests (#204386)](#204386) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-16T20:03:47Z","message":"Fixing inference service test deprecation warning in search tests (#204386)\n\nAdds a `model_id` property to the model config and renames the service\r\nto `elasticsearch`, as `elser` has been deprecated.\r\nThis should avoid triggering API deprecation warning.","sha":"49a5b2ff7ee809df5bddec88c5f1c2058c1e4b55","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","v9.0.0","testing","backport:version","v8.18.0"],"title":"Fixing inference service test deprecation warning in search tests","number":204386,"url":"https://github.com/elastic/kibana/pull/204386","mergeCommit":{"message":"Fixing inference service test deprecation warning in search tests (#204386)\n\nAdds a `model_id` property to the model config and renames the service\r\nto `elasticsearch`, as `elser` has been deprecated.\r\nThis should avoid triggering API deprecation warning.","sha":"49a5b2ff7ee809df5bddec88c5f1c2058c1e4b55"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204386","number":204386,"mergeCommit":{"message":"Fixing inference service test deprecation warning in search tests (#204386)\n\nAdds a `model_id` property to the model config and renames the service\r\nto `elasticsearch`, as `elser` has been deprecated.\r\nThis should avoid triggering API deprecation warning.","sha":"49a5b2ff7ee809df5bddec88c5f1c2058c1e4b55"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
…astic#204386) Adds a `model_id` property to the model config and renames the service to `elasticsearch`, as `elser` has been deprecated. This should avoid triggering API deprecation warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
model_idproperty to the model config and renames the service toelasticsearch, aselserhas been deprecated.This should avoid triggering API deprecation warning.