[One Discover] Add AIAssistant prompts to logs overview detail #204339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyghiani
added
release_note:skip
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
jughosta
approved these changes
Dec 16, 2024
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Good point @jughosta, currently the prompt only asks for a KQL query while it makes sense that we can get a difference based on the mode. I did a quick attempt changing the prompt, but it seems it doesn't get very well the output, since it typically returns a DSL query. 
This is probably a matter of tuning the prompting in a way that it has the knowledge it needs about ES|QL, I'd rather leave this enhancement out of the scope of this issue, but I added a note in #186460 about enhancing this prompts UX also to consider this aspect. |
💚 Build Succeeded
Metrics [docs]Async chunks
History |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12411002825 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 19, 2024
…ic#204339) ## 📓 Summary Closes elastic#202191 This work brings into the O11y solution contextual experience in Discover the Logs AI Assistant prompts already adopted in LogStream and Logs Explorer, which are now set for deprecation in favour of the unique OneDiscover experience. The AIAssistant is consumed by the `discover-shared` features registry, which registers the features from the logs-shared plugin. Once the codebase for LogStream and Logs Explorer that consume this component is removed, it might make sense to do some clean-up and move the LogsAIAssistant component implementation among the other contextual components (log summary columns, etc...). https://github.com/user-attachments/assets/f97d5a01-3896-4a86-9a3c-443151a9d04e Co-authored-by: Marco Antonio Ghiani <[email protected]> (cherry picked from commit 8b3281d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 19, 2024
…204339) (#204910) # Backport This will backport the following commits from `main` to `8.x`: - [[One Discover] Add AIAssistant prompts to logs overview detail (#204339)](#204339) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T10:37:08Z","message":"[One Discover] Add AIAssistant prompts to logs overview detail (#204339)\n\n## 📓 Summary\r\n\r\nCloses #202191 \r\n\r\nThis work brings into the O11y solution contextual experience in\r\nDiscover the Logs AI Assistant prompts already adopted in LogStream and\r\nLogs Explorer, which are now set for deprecation in favour of the unique\r\nOneDiscover experience.\r\n\r\nThe AIAssistant is consumed by the `discover-shared` features registry,\r\nwhich registers the features from the logs-shared plugin. Once the\r\ncodebase for LogStream and Logs Explorer that consume this component is\r\nremoved, it might make sense to do some clean-up and move the\r\nLogsAIAssistant component implementation among the other contextual\r\ncomponents (log summary columns, etc...).\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f97d5a01-3896-4a86-9a3c-443151a9d04e\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"8b3281d4843efff3be4d291453c1aa6a61cd75fc","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Project:OneDiscover"],"title":"[One Discover] Add AIAssistant prompts to logs overview detail","number":204339,"url":"https://github.com/elastic/kibana/pull/204339","mergeCommit":{"message":"[One Discover] Add AIAssistant prompts to logs overview detail (#204339)\n\n## 📓 Summary\r\n\r\nCloses #202191 \r\n\r\nThis work brings into the O11y solution contextual experience in\r\nDiscover the Logs AI Assistant prompts already adopted in LogStream and\r\nLogs Explorer, which are now set for deprecation in favour of the unique\r\nOneDiscover experience.\r\n\r\nThe AIAssistant is consumed by the `discover-shared` features registry,\r\nwhich registers the features from the logs-shared plugin. Once the\r\ncodebase for LogStream and Logs Explorer that consume this component is\r\nremoved, it might make sense to do some clean-up and move the\r\nLogsAIAssistant component implementation among the other contextual\r\ncomponents (log summary columns, etc...).\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f97d5a01-3896-4a86-9a3c-443151a9d04e\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"8b3281d4843efff3be4d291453c1aa6a61cd75fc"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204339","number":204339,"mergeCommit":{"message":"[One Discover] Add AIAssistant prompts to logs overview detail (#204339)\n\n## 📓 Summary\r\n\r\nCloses #202191 \r\n\r\nThis work brings into the O11y solution contextual experience in\r\nDiscover the Logs AI Assistant prompts already adopted in LogStream and\r\nLogs Explorer, which are now set for deprecation in favour of the unique\r\nOneDiscover experience.\r\n\r\nThe AIAssistant is consumed by the `discover-shared` features registry,\r\nwhich registers the features from the logs-shared plugin. Once the\r\ncodebase for LogStream and Logs Explorer that consume this component is\r\nremoved, it might make sense to do some clean-up and move the\r\nLogsAIAssistant component implementation among the other contextual\r\ncomponents (log summary columns, etc...).\r\n\r\n\r\nhttps://github.com/user-attachments/assets/f97d5a01-3896-4a86-9a3c-443151a9d04e\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"8b3281d4843efff3be4d291453c1aa6a61cd75fc"}}]}] BACKPORT--> --------- Co-authored-by: Marco Antonio Ghiani <[email protected]>
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Dec 19, 2024
…ic#204339) ## 📓 Summary Closes elastic#202191 This work brings into the O11y solution contextual experience in Discover the Logs AI Assistant prompts already adopted in LogStream and Logs Explorer, which are now set for deprecation in favour of the unique OneDiscover experience. The AIAssistant is consumed by the `discover-shared` features registry, which registers the features from the logs-shared plugin. Once the codebase for LogStream and Logs Explorer that consume this component is removed, it might make sense to do some clean-up and move the LogsAIAssistant component implementation among the other contextual components (log summary columns, etc...). https://github.com/user-attachments/assets/f97d5a01-3896-4a86-9a3c-443151a9d04e Co-authored-by: Marco Antonio Ghiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 Summary
Closes #202191
This work brings into the O11y solution contextual experience in Discover the Logs AI Assistant prompts already adopted in LogStream and Logs Explorer, which are now set for deprecation in favour of the unique OneDiscover experience.
The AIAssistant is consumed by the
discover-sharedfeatures registry, which registers the features from the logs-shared plugin. Once the codebase for LogStream and Logs Explorer that consume this component is removed, it might make sense to do some clean-up and move the LogsAIAssistant component implementation among the other contextual components (log summary columns, etc...).Screen.Recording.2024-12-16.at.09.02.45.mov