-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the annotation step in the OTel Kubernetes flow #204260
Update the annotation step in the OTel Kubernetes flow #204260
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
@mykolaharmash will this affect the k8s e2e tests in Ensemble? |
...ity_onboarding/public/application/quickstart_flows/otel_kubernetes/otel_kubernetes_panel.tsx
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
…/public/application/quickstart_flows/otel_kubernetes/otel_kubernetes_panel.tsx Co-authored-by: Mike Birnstiehl <[email protected]>
@gbamparop probably slightly, but it's still in progress, I'll adjust the test once you merge this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for addressing this! ✨
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12411468786 |
## 📓 Summary Updates the third optional step in the OpenTelemetry flow for Kubernetes according to the latest designs. It splits the guidelines by providing instructions to annotate specific pods as well as all the resources in the namespace. ## Before <img width="1061" alt="image" src="https://github.com/user-attachments/assets/1c334244-47ea-493d-b8ef-6bf002f97616" /> ## After ### Amsterdam <img width="930" alt="image" src="https://github.com/user-attachments/assets/91bec562-c1dc-4c8c-b58e-d9b71a9d6978" /> ### Amsterdam (Dark mode) <img width="931" alt="image" src="https://github.com/user-attachments/assets/673deb18-588d-4845-9419-3ad00bbae1e2" /> ### Borealis <img width="934" alt="image" src="https://github.com/user-attachments/assets/a79aee17-708a-4809-becc-6a4ba2ffa020" /> Closes elastic#201130 --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Mike Birnstiehl <[email protected]> (cherry picked from commit 92bc22b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
#204917) # Backport This will backport the following commits from `main` to `8.x`: - [Update the annotation step in the OTel Kubernetes flow (#204260)](#204260) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Giorgos Bamparopoulos","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T11:07:11Z","message":"Update the annotation step in the OTel Kubernetes flow (#204260)\n\n## 📓 Summary\r\nUpdates the third optional step in the OpenTelemetry flow for Kubernetes\r\naccording to the latest designs. It splits the guidelines by providing\r\ninstructions to annotate specific pods as well as all the resources in\r\nthe namespace.\r\n\r\n## Before\r\n<img width=\"1061\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1c334244-47ea-493d-b8ef-6bf002f97616\"\r\n/>\r\n\r\n## After\r\n### Amsterdam\r\n<img width=\"930\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/91bec562-c1dc-4c8c-b58e-d9b71a9d6978\"\r\n/>\r\n\r\n\r\n### Amsterdam (Dark mode)\r\n<img width=\"931\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/673deb18-588d-4845-9419-3ad00bbae1e2\"\r\n/>\r\n\r\n### Borealis\r\n<img width=\"934\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a79aee17-708a-4809-becc-6a4ba2ffa020\"\r\n/>\r\n\r\n\r\n\r\n\r\nCloses https://github.com/elastic/kibana/issues/201130\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Mike Birnstiehl <[email protected]>","sha":"92bc22b84046a4595d3f2a674cc0286b37ff4788","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability"],"title":"Update the annotation step in the OTel Kubernetes flow","number":204260,"url":"https://github.com/elastic/kibana/pull/204260","mergeCommit":{"message":"Update the annotation step in the OTel Kubernetes flow (#204260)\n\n## 📓 Summary\r\nUpdates the third optional step in the OpenTelemetry flow for Kubernetes\r\naccording to the latest designs. It splits the guidelines by providing\r\ninstructions to annotate specific pods as well as all the resources in\r\nthe namespace.\r\n\r\n## Before\r\n<img width=\"1061\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1c334244-47ea-493d-b8ef-6bf002f97616\"\r\n/>\r\n\r\n## After\r\n### Amsterdam\r\n<img width=\"930\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/91bec562-c1dc-4c8c-b58e-d9b71a9d6978\"\r\n/>\r\n\r\n\r\n### Amsterdam (Dark mode)\r\n<img width=\"931\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/673deb18-588d-4845-9419-3ad00bbae1e2\"\r\n/>\r\n\r\n### Borealis\r\n<img width=\"934\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a79aee17-708a-4809-becc-6a4ba2ffa020\"\r\n/>\r\n\r\n\r\n\r\n\r\nCloses https://github.com/elastic/kibana/issues/201130\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Mike Birnstiehl <[email protected]>","sha":"92bc22b84046a4595d3f2a674cc0286b37ff4788"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204260","number":204260,"mergeCommit":{"message":"Update the annotation step in the OTel Kubernetes flow (#204260)\n\n## 📓 Summary\r\nUpdates the third optional step in the OpenTelemetry flow for Kubernetes\r\naccording to the latest designs. It splits the guidelines by providing\r\ninstructions to annotate specific pods as well as all the resources in\r\nthe namespace.\r\n\r\n## Before\r\n<img width=\"1061\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1c334244-47ea-493d-b8ef-6bf002f97616\"\r\n/>\r\n\r\n## After\r\n### Amsterdam\r\n<img width=\"930\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/91bec562-c1dc-4c8c-b58e-d9b71a9d6978\"\r\n/>\r\n\r\n\r\n### Amsterdam (Dark mode)\r\n<img width=\"931\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/673deb18-588d-4845-9419-3ad00bbae1e2\"\r\n/>\r\n\r\n### Borealis\r\n<img width=\"934\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a79aee17-708a-4809-becc-6a4ba2ffa020\"\r\n/>\r\n\r\n\r\n\r\n\r\nCloses https://github.com/elastic/kibana/issues/201130\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Mike Birnstiehl <[email protected]>","sha":"92bc22b84046a4595d3f2a674cc0286b37ff4788"}}]}] BACKPORT--> Co-authored-by: Giorgos Bamparopoulos <[email protected]>
## 📓 Summary Updates the third optional step in the OpenTelemetry flow for Kubernetes according to the latest designs. It splits the guidelines by providing instructions to annotate specific pods as well as all the resources in the namespace. ## Before <img width="1061" alt="image" src="https://github.com/user-attachments/assets/1c334244-47ea-493d-b8ef-6bf002f97616" /> ## After ### Amsterdam <img width="930" alt="image" src="https://github.com/user-attachments/assets/91bec562-c1dc-4c8c-b58e-d9b71a9d6978" /> ### Amsterdam (Dark mode) <img width="931" alt="image" src="https://github.com/user-attachments/assets/673deb18-588d-4845-9419-3ad00bbae1e2" /> ### Borealis <img width="934" alt="image" src="https://github.com/user-attachments/assets/a79aee17-708a-4809-becc-6a4ba2ffa020" /> Closes elastic#201130 --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Mike Birnstiehl <[email protected]>
📓 Summary
Updates the third optional step in the OpenTelemetry flow for Kubernetes according to the latest designs. It splits the guidelines by providing instructions to annotate specific pods as well as all the resources in the namespace.
Before
After
Amsterdam
Amsterdam (Dark mode)
Borealis
Closes #201130