Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the annotation step in the OTel Kubernetes flow #204260

Merged
merged 4 commits into from
Dec 19, 2024

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Dec 13, 2024

📓 Summary

Updates the third optional step in the OpenTelemetry flow for Kubernetes according to the latest designs. It splits the guidelines by providing instructions to annotate specific pods as well as all the resources in the namespace.

Before

image

After

Amsterdam

image

Amsterdam (Dark mode)

image

Borealis

image

Closes #201130

@gbamparop gbamparop requested a review from a team as a code owner December 13, 2024 16:58
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 13, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@gbamparop gbamparop added the release_note:skip Skip the PR/issue when compiling release notes label Dec 13, 2024
@gbamparop gbamparop added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Dec 13, 2024
@gbamparop
Copy link
Contributor Author

@mykolaharmash will this affect the k8s e2e tests in Ensemble?

@gbamparop
Copy link
Contributor Author

@elasticmachine merge upstream

elasticmachine and others added 2 commits December 16, 2024 11:28
…/public/application/quickstart_flows/otel_kubernetes/otel_kubernetes_panel.tsx

Co-authored-by: Mike Birnstiehl <[email protected]>
@mykolaharmash
Copy link
Contributor

@mykolaharmash will this affect the k8s e2e tests in Ensemble?

@gbamparop probably slightly, but it's still in progress, I'll adjust the test once you merge this one

Copy link
Contributor

@mykolaharmash mykolaharmash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for addressing this! ✨

@gbamparop
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 19, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 097e75e
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-204260-097e75e2397f

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #10 / serverless search UI Serverless Inference Management UI delete action "before each" hook for "deletes modal successfully with usage"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 274.0KB 274.8KB +830.0B

History

@gbamparop gbamparop merged commit 92bc22b into elastic:main Dec 19, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12411468786

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 19, 2024
## 📓 Summary
Updates the third optional step in the OpenTelemetry flow for Kubernetes
according to the latest designs. It splits the guidelines by providing
instructions to annotate specific pods as well as all the resources in
the namespace.

## Before
<img width="1061" alt="image"
src="https://github.com/user-attachments/assets/1c334244-47ea-493d-b8ef-6bf002f97616"
/>

## After
### Amsterdam
<img width="930" alt="image"
src="https://github.com/user-attachments/assets/91bec562-c1dc-4c8c-b58e-d9b71a9d6978"
/>

### Amsterdam (Dark mode)
<img width="931" alt="image"
src="https://github.com/user-attachments/assets/673deb18-588d-4845-9419-3ad00bbae1e2"
/>

### Borealis
<img width="934" alt="image"
src="https://github.com/user-attachments/assets/a79aee17-708a-4809-becc-6a4ba2ffa020"
/>

Closes elastic#201130

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Mike Birnstiehl <[email protected]>
(cherry picked from commit 92bc22b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 19, 2024
#204917)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Update the annotation step in the OTel Kubernetes flow
(#204260)](#204260)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Giorgos
Bamparopoulos","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T11:07:11Z","message":"Update
the annotation step in the OTel Kubernetes flow (#204260)\n\n## 📓
Summary\r\nUpdates the third optional step in the OpenTelemetry flow for
Kubernetes\r\naccording to the latest designs. It splits the guidelines
by providing\r\ninstructions to annotate specific pods as well as all
the resources in\r\nthe namespace.\r\n\r\n## Before\r\n<img
width=\"1061\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1c334244-47ea-493d-b8ef-6bf002f97616\"\r\n/>\r\n\r\n##
After\r\n### Amsterdam\r\n<img width=\"930\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/91bec562-c1dc-4c8c-b58e-d9b71a9d6978\"\r\n/>\r\n\r\n\r\n###
Amsterdam (Dark mode)\r\n<img width=\"931\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/673deb18-588d-4845-9419-3ad00bbae1e2\"\r\n/>\r\n\r\n###
Borealis\r\n<img width=\"934\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a79aee17-708a-4809-becc-6a4ba2ffa020\"\r\n/>\r\n\r\n\r\n\r\n\r\nCloses
https://github.com/elastic/kibana/issues/201130\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Mike
Birnstiehl
<[email protected]>","sha":"92bc22b84046a4595d3f2a674cc0286b37ff4788","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability"],"title":"Update
the annotation step in the OTel Kubernetes
flow","number":204260,"url":"https://github.com/elastic/kibana/pull/204260","mergeCommit":{"message":"Update
the annotation step in the OTel Kubernetes flow (#204260)\n\n## 📓
Summary\r\nUpdates the third optional step in the OpenTelemetry flow for
Kubernetes\r\naccording to the latest designs. It splits the guidelines
by providing\r\ninstructions to annotate specific pods as well as all
the resources in\r\nthe namespace.\r\n\r\n## Before\r\n<img
width=\"1061\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1c334244-47ea-493d-b8ef-6bf002f97616\"\r\n/>\r\n\r\n##
After\r\n### Amsterdam\r\n<img width=\"930\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/91bec562-c1dc-4c8c-b58e-d9b71a9d6978\"\r\n/>\r\n\r\n\r\n###
Amsterdam (Dark mode)\r\n<img width=\"931\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/673deb18-588d-4845-9419-3ad00bbae1e2\"\r\n/>\r\n\r\n###
Borealis\r\n<img width=\"934\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a79aee17-708a-4809-becc-6a4ba2ffa020\"\r\n/>\r\n\r\n\r\n\r\n\r\nCloses
https://github.com/elastic/kibana/issues/201130\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Mike
Birnstiehl
<[email protected]>","sha":"92bc22b84046a4595d3f2a674cc0286b37ff4788"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204260","number":204260,"mergeCommit":{"message":"Update
the annotation step in the OTel Kubernetes flow (#204260)\n\n## 📓
Summary\r\nUpdates the third optional step in the OpenTelemetry flow for
Kubernetes\r\naccording to the latest designs. It splits the guidelines
by providing\r\ninstructions to annotate specific pods as well as all
the resources in\r\nthe namespace.\r\n\r\n## Before\r\n<img
width=\"1061\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/1c334244-47ea-493d-b8ef-6bf002f97616\"\r\n/>\r\n\r\n##
After\r\n### Amsterdam\r\n<img width=\"930\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/91bec562-c1dc-4c8c-b58e-d9b71a9d6978\"\r\n/>\r\n\r\n\r\n###
Amsterdam (Dark mode)\r\n<img width=\"931\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/673deb18-588d-4845-9419-3ad00bbae1e2\"\r\n/>\r\n\r\n###
Borealis\r\n<img width=\"934\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a79aee17-708a-4809-becc-6a4ba2ffa020\"\r\n/>\r\n\r\n\r\n\r\n\r\nCloses
https://github.com/elastic/kibana/issues/201130\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Mike
Birnstiehl
<[email protected]>","sha":"92bc22b84046a4595d3f2a674cc0286b37ff4788"}}]}]
BACKPORT-->

Co-authored-by: Giorgos Bamparopoulos <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
## 📓 Summary
Updates the third optional step in the OpenTelemetry flow for Kubernetes
according to the latest designs. It splits the guidelines by providing
instructions to annotate specific pods as well as all the resources in
the namespace.

## Before
<img width="1061" alt="image"
src="https://github.com/user-attachments/assets/1c334244-47ea-493d-b8ef-6bf002f97616"
/>

## After
### Amsterdam
<img width="930" alt="image"
src="https://github.com/user-attachments/assets/91bec562-c1dc-4c8c-b58e-d9b71a9d6978"
/>


### Amsterdam (Dark mode)
<img width="931" alt="image"
src="https://github.com/user-attachments/assets/673deb18-588d-4845-9419-3ad00bbae1e2"
/>

### Borealis
<img width="934" alt="image"
src="https://github.com/user-attachments/assets/a79aee17-708a-4809-becc-6a4ba2ffa020"
/>




Closes elastic#201130

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Mike Birnstiehl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Observability Onboarding] Fix K8 annotations step
5 participants