Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Update deprecated access tags to the new security configuration in routes #204214

Conversation

iblancof
Copy link
Contributor

@iblancof iblancof commented Dec 13, 2024

Summary

Closes #203793

This PR replaces the deprecated access tags with the new security configuration.

All instances of options: {tags: ['access:infra']} are now updated to security: {authz: {requiredPrivileges: ['infra']}}.

@iblancof iblancof added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Authz: API migration v8.18.0 labels Dec 13, 2024
@iblancof iblancof self-assigned this Dec 13, 2024
@iblancof iblancof requested a review from a team as a code owner December 13, 2024 13:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 13, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 16, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 29ce215
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-204214-29ce2156e041

Metrics [docs]

✅ unchanged

History

cc @iblancof

@iblancof iblancof enabled auto-merge (squash) December 16, 2024 09:40
@iblancof iblancof merged commit 73066e8 into elastic:main Dec 16, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12350236719

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 16, 2024
…on in routes (elastic#204214)

## Summary

Closes elastic#203793

This PR replaces the deprecated `access` tags with the new `security`
configuration.

All instances of `options: {tags: ['access:infra']}` are now updated to
`security: {authz: {requiredPrivileges: ['infra']}}`.

(cherry picked from commit 73066e8)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@iblancof iblancof deleted the 203793-infra-manual-migration-for-routes-with-access-tags branch December 16, 2024 10:31
kibanamachine added a commit that referenced this pull request Dec 16, 2024
…guration in routes (#204214) (#204349)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Infra] Update deprecated access tags to the new security
configuration in routes
(#204214)](#204214)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Irene
Blanco","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-16T10:02:04Z","message":"[Infra]
Update deprecated access tags to the new security configuration in
routes (#204214)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/203793\r\n\r\nThis PR replaces
the deprecated `access` tags with the new
`security`\r\nconfiguration.\r\n\r\nAll instances of `options: {tags:
['access:infra']}` are now updated to\r\n`security: {authz:
{requiredPrivileges:
['infra']}}`.","sha":"73066e8cc30c756ed6953948d9d65bb0175af99f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","Authz:
API migration","v8.18.0"],"title":"[Infra] Update deprecated access tags
to the new security configuration in
routes","number":204214,"url":"https://github.com/elastic/kibana/pull/204214","mergeCommit":{"message":"[Infra]
Update deprecated access tags to the new security configuration in
routes (#204214)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/203793\r\n\r\nThis PR replaces
the deprecated `access` tags with the new
`security`\r\nconfiguration.\r\n\r\nAll instances of `options: {tags:
['access:infra']}` are now updated to\r\n`security: {authz:
{requiredPrivileges:
['infra']}}`.","sha":"73066e8cc30c756ed6953948d9d65bb0175af99f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204214","number":204214,"mergeCommit":{"message":"[Infra]
Update deprecated access tags to the new security configuration in
routes (#204214)\n\n## Summary\r\n\r\nCloses
https://github.com/elastic/kibana/issues/203793\r\n\r\nThis PR replaces
the deprecated `access` tags with the new
`security`\r\nconfiguration.\r\n\r\nAll instances of `options: {tags:
['access:infra']}` are now updated to\r\n`security: {authz:
{requiredPrivileges:
['infra']}}`.","sha":"73066e8cc30c756ed6953948d9d65bb0175af99f"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Irene Blanco <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
…on in routes (elastic#204214)

## Summary

Closes elastic#203793

This PR replaces the deprecated `access` tags with the new `security`
configuration.

All instances of `options: {tags: ['access:infra']}` are now updated to
`security: {authz: {requiredPrivileges: ['infra']}}`.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
…on in routes (elastic#204214)

## Summary

Closes elastic#203793

This PR replaces the deprecated `access` tags with the new `security`
configuration.

All instances of `options: {tags: ['access:infra']}` are now updated to
`security: {authz: {requiredPrivileges: ['infra']}}`.
yngrdyn added a commit that referenced this pull request Jan 28, 2025
Relates to elastic/kibana-team#1235.

---
## Team: `@elastic/obs-ux-logs-team`

| URL | PR |
| --- | --- |
| `/api/log_entries/highlights` | current PR |
| `/api/log_entries/summary` | current PR |
| `/api/log_entries/summary_highlights` | current PR |
| `/api/infra/log_views/{logViewId}` |
#204214 |
| `/api/infra/log_views/{logViewId}` |
#204214 |
| `/api/infra/log_analysis/results/log_entry_categories` |
#204214 |
| `/api/infra/log_analysis/results/log_entry_category_datasets` |
#204214 |
|
`/api/infra/log_analysis/results/latest_log_entry_category_datasets_stats`
| #204214 |
| `/api/infra/log_analysis/results/log_entry_category_examples` |
#204214 |
| `/api/infra/log_analysis/results/log_entry_anomalies` |
#204214 |
| `/api/infra/log_analysis/results/log_entry_anomalies_datasets` |
#204214 |
| `/api/infra/log_analysis/id_formats` |
#204214 |
| `/api/infra/log_analysis/validation/log_entry_datasets` |
#204214 |
| `/api/infra/log_analysis/validation/log_entry_rate_indices` |
#204214 |
| `/api/infra/log_analysis/results/log_entry_examples` |
#204214 |
| `/api/infra/log_alerts/chart_preview_data` |
#204214 |
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 28, 2025
Relates to elastic/kibana-team#1235.

---
## Team: `@elastic/obs-ux-logs-team`

| URL | PR |
| --- | --- |
| `/api/log_entries/highlights` | current PR |
| `/api/log_entries/summary` | current PR |
| `/api/log_entries/summary_highlights` | current PR |
| `/api/infra/log_views/{logViewId}` |
elastic#204214 |
| `/api/infra/log_views/{logViewId}` |
elastic#204214 |
| `/api/infra/log_analysis/results/log_entry_categories` |
elastic#204214 |
| `/api/infra/log_analysis/results/log_entry_category_datasets` |
elastic#204214 |
|
`/api/infra/log_analysis/results/latest_log_entry_category_datasets_stats`
| elastic#204214 |
| `/api/infra/log_analysis/results/log_entry_category_examples` |
elastic#204214 |
| `/api/infra/log_analysis/results/log_entry_anomalies` |
elastic#204214 |
| `/api/infra/log_analysis/results/log_entry_anomalies_datasets` |
elastic#204214 |
| `/api/infra/log_analysis/id_formats` |
elastic#204214 |
| `/api/infra/log_analysis/validation/log_entry_datasets` |
elastic#204214 |
| `/api/infra/log_analysis/validation/log_entry_rate_indices` |
elastic#204214 |
| `/api/infra/log_analysis/results/log_entry_examples` |
elastic#204214 |
| `/api/infra/log_alerts/chart_preview_data` |
elastic#204214 |

(cherry picked from commit 013a124)
kibanamachine added a commit that referenced this pull request Jan 28, 2025
…208598)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Logs] Manual migration for routes with access tags
(#208484)](#208484)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yngrid
Coello","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-28T18:34:05Z","message":"[Logs]
Manual migration for routes with access tags (#208484)\n\nRelates to
https://github.com/elastic/kibana-team/issues/1235.\r\n\r\n---\r\n##
Team: `@elastic/obs-ux-logs-team`\r\n\r\n| URL | PR |\r\n| --- | ---
|\r\n| `/api/log_entries/highlights` | current PR |\r\n|
`/api/log_entries/summary` | current PR |\r\n|
`/api/log_entries/summary_highlights` | current PR |\r\n|
`/api/infra/log_views/{logViewId}`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_views/{logViewId}`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_categories`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_category_datasets`
|\r\nhttps://github.com//pull/204214
|\r\n|\r\n`/api/infra/log_analysis/results/latest_log_entry_category_datasets_stats`\r\n|
#204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_category_examples`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_anomalies`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_anomalies_datasets`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/id_formats`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/validation/log_entry_datasets`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/validation/log_entry_rate_indices`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_examples`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_alerts/chart_preview_data`
|\r\nhttps://github.com//pull/204214
|","sha":"013a1248a3338144799e4dc32ffc4bec9aa5b9f8","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Logs]
Manual migration for routes with access
tags","number":208484,"url":"https://github.com/elastic/kibana/pull/208484","mergeCommit":{"message":"[Logs]
Manual migration for routes with access tags (#208484)\n\nRelates to
https://github.com/elastic/kibana-team/issues/1235.\r\n\r\n---\r\n##
Team: `@elastic/obs-ux-logs-team`\r\n\r\n| URL | PR |\r\n| --- | ---
|\r\n| `/api/log_entries/highlights` | current PR |\r\n|
`/api/log_entries/summary` | current PR |\r\n|
`/api/log_entries/summary_highlights` | current PR |\r\n|
`/api/infra/log_views/{logViewId}`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_views/{logViewId}`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_categories`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_category_datasets`
|\r\nhttps://github.com//pull/204214
|\r\n|\r\n`/api/infra/log_analysis/results/latest_log_entry_category_datasets_stats`\r\n|
#204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_category_examples`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_anomalies`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_anomalies_datasets`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/id_formats`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/validation/log_entry_datasets`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/validation/log_entry_rate_indices`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_examples`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_alerts/chart_preview_data`
|\r\nhttps://github.com//pull/204214
|","sha":"013a1248a3338144799e4dc32ffc4bec9aa5b9f8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208484","number":208484,"mergeCommit":{"message":"[Logs]
Manual migration for routes with access tags (#208484)\n\nRelates to
https://github.com/elastic/kibana-team/issues/1235.\r\n\r\n---\r\n##
Team: `@elastic/obs-ux-logs-team`\r\n\r\n| URL | PR |\r\n| --- | ---
|\r\n| `/api/log_entries/highlights` | current PR |\r\n|
`/api/log_entries/summary` | current PR |\r\n|
`/api/log_entries/summary_highlights` | current PR |\r\n|
`/api/infra/log_views/{logViewId}`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_views/{logViewId}`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_categories`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_category_datasets`
|\r\nhttps://github.com//pull/204214
|\r\n|\r\n`/api/infra/log_analysis/results/latest_log_entry_category_datasets_stats`\r\n|
#204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_category_examples`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_anomalies`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_anomalies_datasets`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/id_formats`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/validation/log_entry_datasets`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/validation/log_entry_rate_indices`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_analysis/results/log_entry_examples`
|\r\nhttps://github.com//pull/204214 |\r\n|
`/api/infra/log_alerts/chart_preview_data`
|\r\nhttps://github.com//pull/204214
|","sha":"013a1248a3338144799e4dc32ffc4bec9aa5b9f8"}}]}] BACKPORT-->

Co-authored-by: Yngrid Coello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Authz: API migration backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra] Manual migration for routes with access tags
5 participants