Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ObsUX][INFRA] Remove-infra-from-babel-preset-styled-components #204213

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[ObsUX][INFRA] Remove-infra-from-babel-preset-styled-components #204213

merged 1 commit into from
Dec 13, 2024

Conversation

MiriamAparicio
Copy link
Contributor

Summary

After migrating infra plugin from styled-components to @emotion in this PR, this file was missed to update

@MiriamAparicio MiriamAparicio added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 EUI Visual Refresh labels Dec 13, 2024
@MiriamAparicio MiriamAparicio requested a review from a team as a code owner December 13, 2024 13:49
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #13 / UserActionPropertyActions renders the property actions

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1543 1542 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.8MB 1.7MB -30.1KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 57.9KB 57.8KB -62.0B
Unknown metric groups

async chunk count

id before after diff
infra 32 33 +1

@MiriamAparicio MiriamAparicio merged commit 0cd82ae into elastic:main Dec 13, 2024
17 checks passed
@MiriamAparicio MiriamAparicio deleted the remove-infra-from-babel-preset-styled-components branch December 13, 2024 15:40
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@MiriamAparicio @CAWilson94
[ObsUX][INFRA] Remove-infra-from-babel-preset-styled-components (elas…
ad44918 
…tic#204213)

## Summary

After migrating infra plugin from `styled-components` to `@emotion` in
this [PR](elastic#202405), this file was
missed to update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delanni delanni delanni approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiriamAparicio @elasticmachine @delanni