Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolutions][Lens][Embeddable] Use the correct Lens typeguard for the new embeddable #204189

Merged
merged 2 commits into from
Dec 18, 2024
Merged

[SecuritySolutions][Lens][Embeddable] Use the correct Lens typeguard for the new embeddable #204189

merged 2 commits into from
Dec 18, 2024
+6 −12

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Dec 13, 2024 •
edited by kibanamachine
Loading

Summary

Fixes #180726

Use the new isLensApi helper in place of the previous system.

@dej611 dej611 added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes Feature:Lens Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Embeddables Relating to the Embeddable system labels Dec 13, 2024
@dej611 dej611 requested a review from a team as a code owner December 13, 2024 10:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@dej611 dej611 added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Dec 13, 2024
@dej611 dej611 enabled auto-merge (squash) December 18, 2024 09:28
@dej611 dej611 merged commit 9b0879c into elastic:main Dec 18, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12391836168

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 22.2MB 22.2MB -6.0B

History

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204189

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 19, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 204189 locally

@nreese
Copy link
Contributor

nreese commented Dec 19, 2024

Why was this not backported to 8.x?

@dej611 dej611 mentioned this pull request Dec 19, 2024
Closed
@dej611
Copy link
Contributor Author

dej611 commented Dec 19, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dej611 added a commit to dej611/kibana that referenced this pull request Dec 19, 2024
@dej611
[SecuritySolutions][Lens][Embeddable] Use the correct Lens typeguard …
667c164 
…for the new embeddable (elastic#204189)

## Summary

Fixes elastic#180726

Use the new `isLensApi` helper in place of the previous system.

Co-authored-by: Angela Chuang <[email protected]>
(cherry picked from commit 9b0879c)

# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/app/actions/copy_to_clipboard/lens/copy_to_clipboard.ts
#	x-pack/solutions/security/plugins/security_solution/public/app/actions/filter/lens/create_action.ts
#	x-pack/solutions/security/plugins/security_solution/public/app/actions/utils.ts
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@dej611 @angorayc @JoseLuisGJ
[SecuritySolutions][Lens][Embeddable] Use the correct Lens typeguard …
6e6b78c 
…for the new embeddable (elastic#204189)

## Summary

Fixes elastic#180726 

Use the new `isLensApi` helper in place of the previous system.

Co-authored-by: Angela Chuang <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

5 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
@dej611 @angorayc @benakansara
[SecuritySolutions][Lens][Embeddable] Use the correct Lens typeguard …
d4231ed 
…for the new embeddable (elastic#204189)

## Summary

Fixes elastic#180726 

Use the new `isLensApi` helper in place of the previous system.

Co-authored-by: Angela Chuang <[email protected]>
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

2 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@dej611 dej611 mentioned this pull request Jan 7, 2025
Closed
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angorayc angorayc angorayc approved these changes

Assignees
No one assigned
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Embeddables Relating to the Embeddable system Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter editor breaks after using inline visualization editor
5 participants
@dej611 @elasticmachine @kibanamachine @nreese @angorayc