[ML] Adding filter bar to jobs list #20415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded |
jgowdyelastic
changed the title
jgowdyelastic
added
review
v7.0.0
v6.4.0
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui |
💔 Build Failed |
|
retest |
💔 Build Failed |
peteharverson
approved these changes
Jul 4, 2018
| const loadGroups = () => { | ||
| return ml.jobs.groups() | ||
| .then((groups) => { | ||
| return groups.map(g => ({ |
There was a problem hiding this comment.
The style guide recommends using parentheses when the function body includes braces
| } | ||
|
|
||
| // keep count of the number of matches we make as we're looping over the clauses | ||
| // we only want to return jobs with match all clauses, i.e. each search term is ANDed |
There was a problem hiding this comment.
Should this be jobs which match all clauses ?
| EuiSearchBar, | ||
| } from '@elastic/eui'; | ||
|
|
||
| const loadGroups = () => { |
There was a problem hiding this comment.
Prefer the use of a function declaration rather an expression here
💔 Build Failed |
jgowdyelastic
force-pushed
the
adding-filter-bar-to-jobs-list
branch
from
e4f9565 to
a51b78b
Compare
💚 Build Succeeded |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Jul 4, 2018
* [ML] Adding filter bar to jobs list * fixing page index when filtering * refreshing job selection after actions have happened * adding job counts to groups * catching multi-select start datafeed errors * style tweaks * more style tweaks * changes based on review * refactoring search logic
jgowdyelastic
added a commit
that referenced
this pull request
Jul 4, 2018
* [ML] Adding filter bar to jobs list * fixing page index when filtering * refreshing job selection after actions have happened * adding job counts to groups * catching multi-select start datafeed errors * style tweaks * more style tweaks * changes based on review * refactoring search logic
|
Related to #20150 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds filter bar to the jobs list.
Terms searching will match on job id, description and memory status.
Filters for Job and datafeed state can be toggled.
Groups can be picked from a dropdown.
Filter terms are ANDed to allow refining of results.