Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log stream and settings #204115

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Dec 12, 2024

🛑 Blocked by #203996

Removes the code used to render the log stream and settings pages.

The following areas have been checked:

  • Log stream embeddable (dashboard of the cisco_meraki integration)
  • Log stream shared component
  • Log categories
  • Log anomalies
Screen.Recording.2024-12-12.at.18.52.38.mov

Closes #204005

@elasticmachine
Copy link
Contributor

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@gbamparop
Copy link
Contributor Author

/ci

@gbamparop gbamparop added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Dec 12, 2024
@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1543 1249 -294

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/management-settings-ids 136 135 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.8MB 1.2MB -557.5KB
observability 480.8KB 480.5KB -262.0B
total -557.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 57.9KB 51.2KB -6.8KB
Unknown metric groups

API count

id before after diff
@kbn/management-settings-ids 137 136 -1

async chunk count

id before after diff
infra 32 28 -4

ESLint disabled in files

id before after diff
infra 9 8 -1

ESLint disabled line counts

id before after diff
infra 43 40 -3

Total ESLint disabled count

id before after diff
infra 52 48 -4

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the code used to render the logs stream app and the logs settings page in Observability
3 participants