-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(slo): update EUI tokens for Borealis #204066
Conversation
62e6e71
to
c614b26
Compare
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
/oblt-deploy |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Changes LGTM from EUI side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ErrorRateChart
component uses variant={currentStatus === 'BREACHED' ? 'danger' : 'success'}
But according to the Meta issue we need to use vis
colors for visualisation
Update: I'm not sure though where/how variant
would be applied
@fkanout
I don't mind creating an issue for migrating toward the vis color if we think we should, but I don't think it's required for the purpose of the borealis migration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for knocking this out
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @kdelemme |
Resolves #203334
🏇🏻 Summary
This PR replaces all deprecated tokens/hooks usage with the correct new values as explained in the linked issue.