Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(slo): update EUI tokens for Borealis #204066

Merged
merged 7 commits into from
Dec 16, 2024

Conversation

kdelemme
Copy link
Contributor

Resolves #203334

🏇🏻 Summary

This PR replaces all deprecated tokens/hooks usage with the correct new values as explained in the linked issue.

Screenshots
screencapture-localhost-5601-kibana-app-dashboards-2024-12-09-15_26_17
screencapture-localhost-5601-kibana-app-dashboards-2024-12-09-15_26_48
screencapture-localhost-5601-kibana-app-slos-2c2e57eb-845e-42c0-b4f8-1c6148d0a1bf-2024-12-09-15_25_53
screencapture-localhost-5601-kibana-app-slos-2024-12-09-14_11_02
screencapture-localhost-5601-kibana-app-slos-2024-12-09-15_24_06
screencapture-localhost-5601-kibana-app-slos-2024-12-09-15_25_41
screencapture-localhost-5601-kibana-app-slos-9870f113-ce06-456d-9078-ffe8e0e86dd5-history-2024-12-09-15_24_52
screencapture-localhost-5601-kibana-app-slos-edit-9870f113-ce06-456d-9078-ffe8e0e86dd5-2024-12-09-15_24_35

@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:obs-ux-management Observability Management User Experience Team EUI Visual Refresh backport:skip This commit does not require backporting labels Dec 12, 2024
@kdelemme kdelemme self-assigned this Dec 12, 2024
@kdelemme kdelemme force-pushed the chore/borealis-slo-2 branch from 62e6e71 to c614b26 Compare December 12, 2024 16:12
@kdelemme kdelemme marked this pull request as ready for review December 12, 2024 16:38
@kdelemme kdelemme requested review from a team as code owners December 12, 2024 16:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kdelemme
Copy link
Contributor Author

/oblt-deploy

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 13, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Changes LGTM from EUI side

@fkanout fkanout self-requested a review December 16, 2024 14:21
Copy link
Contributor

@fkanout fkanout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ErrorRateChart component uses variant={currentStatus === 'BREACHED' ? 'danger' : 'success'}
But according to the Meta issue we need to use vis colors for visualisation
Update: I'm not sure though where/how variant would be applied

@kdelemme
Copy link
Contributor Author

@fkanout
Well technically the meta states we should use the color.vis if we were previously using the vis token directly, and that's not the case here:

If you were using any of the above tokens directly, please change your code to pull them directly from euiTheme.colors.vis.

I don't mind creating an issue for migrating toward the vis color if we think we should, but I don't think it's required for the purpose of the borealis migration.

@kdelemme kdelemme requested a review from fkanout December 16, 2024 18:37
Copy link
Member

@jasonrhodes jasonrhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for knocking this out

@kdelemme kdelemme removed the request for review from a team December 16, 2024 19:37
@jasonrhodes jasonrhodes removed the request for review from fkanout December 16, 2024 19:37
@kdelemme kdelemme enabled auto-merge (squash) December 16, 2024 19:38
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 16, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: 328cc0b
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-204066-328cc0b2b5fa

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 851.2KB 851.1KB -28.0B

History

cc @kdelemme

@kdelemme kdelemme merged commit 7fd9d7c into elastic:main Dec 16, 2024
8 checks passed
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SLO] Audit new EUI Borealis theme
5 participants