Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset Quality] Reclassify modules as "platform/shared" #204052

Merged
merged 11 commits into from
Dec 18, 2024
Merged

[Dataset Quality] Reclassify modules as "platform/shared" #204052

merged 11 commits into from
Dec 18, 2024

Conversation

weltenwort
Copy link
Member

@weltenwort weltenwort commented Dec 12, 2024 •
edited by kibanamachine
Loading

📝 Summary

This reclassifies the plugins @kbn/data-quality-plugin and @kbn/dataset-quality-plugin as platform/shared, because they're not specific observability despite the code ownership.

🕵️‍♀️ Review notes

  • One small utility hook was copied from @kbn/observability-shared-plugin to remove a forbidden dependency.

@weltenwort weltenwort added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-logs Observability Logs User Experience Team labels Dec 12, 2024
@weltenwort weltenwort self-assigned this Dec 12, 2024
@weltenwort
Copy link
Member Author

@gbamparop thanks for the review, but this is not done yet 😇

@weltenwort weltenwort marked this pull request as ready for review December 18, 2024 08:13
@weltenwort weltenwort requested review from a team as code owners December 18, 2024 08:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

afharo
afharo approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@weltenwort
Copy link
Member Author

@elasticmachine merge upstream

@gbamparop gbamparop enabled auto-merge (squash) December 18, 2024 18:44
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 18, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: 4451aba
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-204052-4451aba200ee

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
datasetQuality 278 273 -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 252.5KB 252.5KB -34.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
datasetQuality 18.9KB 18.9KB +20.0B

History

cc @weltenwort

@gbamparop gbamparop merged commit 3a4fe6f into elastic:main Dec 18, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12400585629

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204052

Questions ?

Please refer to the Backport tool documentation

@yngrdyn yngrdyn mentioned this pull request Dec 19, 2024
Merged
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@weltenwort @kibanamachine
@elasticmachine @JoseLuisGJ
[Dataset Quality] Reclassify modules as "platform/shared" (elastic#20…
c9cb09f 
…4052)

## 📝 Summary

This reclassifies the plugins `@kbn/data-quality-plugin` and
`@kbn/dataset-quality-plugin` as `platform/shared`, because they're not
specific observability despite the code ownership.

- partly addresses:
elastic/observability-dev#4059

## 🕵️‍♀️ Review notes

- One small utility hook was copied from
`@kbn/observability-shared-plugin` to remove a forbidden dependency.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
yngrdyn added a commit that referenced this pull request Dec 19, 2024
@yngrdyn @weltenwort
@kibanamachine @elasticmachine
[8.x][Dataset Quality] Reclassify modules as "platform/shared" (#204991)
c986805 
# Backport

This will backport the following commits from `main` to `8.x`:
 - #204052

<!--- Backport version: 9.4.3 -->

Co-authored-by: Felix Stürmer <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbamparop gbamparop gbamparop approved these changes

@afharo afharo afharo approved these changes

Assignees

@weltenwort weltenwort

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@weltenwort @elasticmachine @kibanamachine @afharo @gbamparop