[ES|QL] Fixes the multiple comments bug #203966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stratoula
added
v9.0.0
v8.17.0
v8.18.0
release_note:fix
Feature:ES|QL
|
Pinging @elastic/kibana-esql (Team:ESQL) |
💚 Build Succeeded
Metrics [docs]Async chunks
|
vadimkibana
approved these changes
Dec 12, 2024
|
Starting backport for target branches: 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12295156352 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 12, 2024
## Summary  Sometimes commenting multiple lines doesnt work as expected. This PR fixes it. The problem was that we were (un)commenting line by line and this apparently can be buggy. With this PR we gather the edits and apply all of them in one `executeEdits ` (cherry picked from commit 9edadfd)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 12, 2024
## Summary  Sometimes commenting multiple lines doesnt work as expected. This PR fixes it. The problem was that we were (un)commenting line by line and this apparently can be buggy. With this PR we gather the edits and apply all of them in one `executeEdits ` (cherry picked from commit 9edadfd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 12, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Fixes the multiple comments bug (#203966)](#203966) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T11:08:29Z","message":"[ES|QL] Fixes the multiple comments bug (#203966)\n\n## Summary\r\n\r\n\r\n\r\n\r\nSometimes commenting multiple lines doesnt work as expected.\r\n\r\nThis PR fixes it. The problem was that we were (un)commenting line by\r\nline and this apparently can be buggy. With this PR we gather the edits\r\nand apply all of them in one `executeEdits `","sha":"9edadfdc4637b2fccc925677f9977fde62849608","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.17.0","v8.18.0"],"title":"[ES|QL] Fixes the multiple comments bug","number":203966,"url":"https://github.com/elastic/kibana/pull/203966","mergeCommit":{"message":"[ES|QL] Fixes the multiple comments bug (#203966)\n\n## Summary\r\n\r\n\r\n\r\n\r\nSometimes commenting multiple lines doesnt work as expected.\r\n\r\nThis PR fixes it. The problem was that we were (un)commenting line by\r\nline and this apparently can be buggy. With this PR we gather the edits\r\nand apply all of them in one `executeEdits `","sha":"9edadfdc4637b2fccc925677f9977fde62849608"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203966","number":203966,"mergeCommit":{"message":"[ES|QL] Fixes the multiple comments bug (#203966)\n\n## Summary\r\n\r\n\r\n\r\n\r\nSometimes commenting multiple lines doesnt work as expected.\r\n\r\nThis PR fixes it. The problem was that we were (un)commenting line by\r\nline and this apparently can be buggy. With this PR we gather the edits\r\nand apply all of them in one `executeEdits `","sha":"9edadfdc4637b2fccc925677f9977fde62849608"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 12, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [[ES|QL] Fixes the multiple comments bug (#203966)](#203966) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Stratoula Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T11:08:29Z","message":"[ES|QL] Fixes the multiple comments bug (#203966)\n\n## Summary\r\n\r\n\r\n\r\n\r\nSometimes commenting multiple lines doesnt work as expected.\r\n\r\nThis PR fixes it. The problem was that we were (un)commenting line by\r\nline and this apparently can be buggy. With this PR we gather the edits\r\nand apply all of them in one `executeEdits `","sha":"9edadfdc4637b2fccc925677f9977fde62849608","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.17.0","v8.18.0"],"title":"[ES|QL] Fixes the multiple comments bug","number":203966,"url":"https://github.com/elastic/kibana/pull/203966","mergeCommit":{"message":"[ES|QL] Fixes the multiple comments bug (#203966)\n\n## Summary\r\n\r\n\r\n\r\n\r\nSometimes commenting multiple lines doesnt work as expected.\r\n\r\nThis PR fixes it. The problem was that we were (un)commenting line by\r\nline and this apparently can be buggy. With this PR we gather the edits\r\nand apply all of them in one `executeEdits `","sha":"9edadfdc4637b2fccc925677f9977fde62849608"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203966","number":203966,"mergeCommit":{"message":"[ES|QL] Fixes the multiple comments bug (#203966)\n\n## Summary\r\n\r\n\r\n\r\n\r\nSometimes commenting multiple lines doesnt work as expected.\r\n\r\nThis PR fixes it. The problem was that we were (un)commenting line by\r\nline and this apparently can be buggy. With this PR we gather the edits\r\nand apply all of them in one `executeEdits `","sha":"9edadfdc4637b2fccc925677f9977fde62849608"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Stratoula Kalafateli <[email protected]>
|
This PR didn't make it on time for the latest v8.17.0 BC. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes commenting multiple lines doesnt work as expected.
This PR fixes it. The problem was that we were (un)commenting line by line and this apparently can be buggy. With this PR we gather the edits and apply all of them in one
executeEdits