Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes deprecated platform security v1 routes #203915

Merged
merged 16 commits into from
Jan 7, 2025
Merged

Removes deprecated platform security v1 routes #203915

merged 16 commits into from
Jan 7, 2025

Conversation

jeramysoucy
Copy link
Contributor

Summary

Removes the v1 routes deprecated in #199656

Part of Kibana 9.0.0 readiness https://github.com/elastic/kibana-team/issues/1190

@jeramysoucy jeramysoucy added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 labels Dec 11, 2024
@jeramysoucy jeramysoucy self-assigned this Dec 11, 2024
@jeramysoucy jeramysoucy marked this pull request as ready for review December 17, 2024 16:59
@jeramysoucy jeramysoucy requested a review from a team as a code owner December 17, 2024 16:59
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

azasypkin
azasypkin approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just a few suggestions.

x-pack/plugins/security/server/routes/authentication/saml.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/saml.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/oidc.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/oidc.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/oidc.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/oidc.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/common.ts Outdated Show resolved Hide resolved
x-pack/plugins/security/server/routes/authentication/common.ts Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
security 47 41 -6

History

cc @jeramysoucy

@jeramysoucy jeramysoucy merged commit 9f4e851 into elastic:main Jan 7, 2025
8 checks passed
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jan 8, 2025
@jeramysoucy @crespocarlos
Removes deprecated platform security v1 routes (elastic#203915)
a632588 
## Summary

Removes the v1 routes deprecated in
elastic#199656

Part of Kibana 9.0.0 readiness
elastic/kibana-team#1190
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@jeramysoucy @CAWilson94
Removes deprecated platform security v1 routes (elastic#203915)
0c4b5be 
## Summary

Removes the v1 routes deprecated in
elastic#199656

Part of Kibana 9.0.0 readiness
elastic/kibana-team#1190
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
@jeramysoucy @viduni94
Removes deprecated platform security v1 routes (elastic#203915)
c268b88 
## Summary

Removes the v1 routes deprecated in
elastic#199656

Part of Kibana 9.0.0 readiness
elastic/kibana-team#1190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees

@jeramysoucy jeramysoucy

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeramysoucy @elasticmachine @azasypkin