Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] Migrate logs-related components to TypeScript #203536

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

gbamparop
Copy link
Contributor

@gbamparop gbamparop commented Dec 10, 2024

Summary

A recent bug that affected some of the pages in Stack Monitoring was caused by changes related to the locators of the logs-related apps.

The issue wasn't caught by type checks as the affected area in the monitoring plugin was written in JavaScript.

The goal of this PR is to migrate the logs-related components to TypeScript.

Testing

The stateful environment deployed by this PR includes logs and metrics for stack monitoring. Please make sure to select a larger time range (e.g. last 14 days).

@gbamparop gbamparop added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Dec 10, 2024
@gbamparop
Copy link
Contributor Author

/ci

@gbamparop
Copy link
Contributor Author

/oblt-deploy

@gbamparop gbamparop changed the title [Stack Monitoring] Migrate logs-related component to TypeScript [Stack Monitoring] Migrate logs-related components to TypeScript Dec 10, 2024
@gbamparop
Copy link
Contributor Author

/ci

@gbamparop gbamparop requested a review from a team December 10, 2024 13:07
@gbamparop gbamparop marked this pull request as ready for review December 10, 2024 15:08
@gbamparop gbamparop requested a review from a team as a code owner December 10, 2024 15:08
Copy link
Contributor

@consulthys consulthys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGT Stack Monitoring

Navigating Stack Monitoring didn't surface any errors (also none in the Dev tools console), whether logs were present on the page or not.

@Kerry350 Kerry350 self-requested a review December 12, 2024 11:12
Copy link
Contributor

@Kerry350 Kerry350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the conversion!

@gbamparop
Copy link
Contributor Author

/oblt-deploy

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #67 / serverless search UI Serverless Playground Overview has embedded console

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 538.4KB 538.5KB +178.0B

History

@gbamparop gbamparop merged commit 46a1535 into elastic:main Dec 13, 2024
8 checks passed
mykolaharmash pushed a commit to mykolaharmash/kibana that referenced this pull request Dec 13, 2024
…stic#203536)

A recent [bug](elastic#199902) that
affected some of the pages in Stack Monitoring was caused by changes
related to the locators of the logs-related apps.

The issue wasn't caught by type checks as the affected area in the
monitoring plugin was written in JavaScript.

The goal of this PR is to migrate the logs-related components to
TypeScript.

The stateful environment deployed by this PR includes logs and metrics
for stack monitoring. Please make sure to select a larger time range
(e.g. last 14 days).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants