Make link to es deprecation logs more useful #203487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesuswr
added
Team:Core
|
/ci |
|
looking great so far! |
TinaHeiligers
added
the
release_note:skip
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
jesuswr
commented
Dec 10, 2024
| }, | ||
| }); | ||
|
|
||
| const checkAllIndicesInPatternAreDeprecationLogs = (indexPattern: string | undefined): boolean => { |
There was a problem hiding this comment.
@davismcphee Should this behaviour be included in the future helper you mentioned in the slack thread?
afharo
reviewed
Dec 10, 2024
...ugins/discover/public/context_awareness/profile_providers/common/deprecation_logs/profile.ts
Outdated
Show resolved
Hide resolved
|
cc @bitzandeb in case you can think of other useful fields to highlight by default. |
afharo
approved these changes
Dec 10, 2024
Comment on lines
+1145
to
+1146
| # TODO: this deprecation_logs folder should be owned by kibana management team after 9.0 | ||
| src/plugins/discover/public/context_awareness/profile_providers/common/deprecation_logs @elastic/kibana-data-discovery @elastic/kibana-core |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
History
cc @jesuswr |
davismcphee
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Code changes look good and it works as expected! I left some minor feedback and suggestions, but nothing blocking. Thanks for adding this, it's a great start to improving Discover support for core functionality 👍
One idea for a potential followup would be to adopt some of the functionality from the O11y logs profile to use for deprecation logs too, like log.level cell rendering and row highlighting:
We even have the option to extend the entire O11y logs profile using the extendProfileProvider utility if we think it makes sense to include it all (plus the deprecation specific stuff like custom columns).
...plugins/discover/public/context_awareness/profile_providers/common/deprecation_logs/index.ts
Outdated
Show resolved
Hide resolved
...ugins/discover/public/context_awareness/profile_providers/common/deprecation_logs/profile.ts
Outdated
Show resolved
Hide resolved
...ugins/discover/public/context_awareness/profile_providers/common/deprecation_logs/profile.ts
Outdated
Show resolved
Hide resolved
| }, | ||
| }); | ||
|
|
||
| const checkAllIndicesInPatternAreDeprecationLogs = (indexPattern: string | undefined): boolean => { |
There was a problem hiding this comment.
I originally forgot we already had a utility for extracting the index pattern, but I also think it would make sense to extract this if we find it's needed for other profiles in the future.
...ugins/discover/public/context_awareness/profile_providers/common/deprecation_logs/profile.ts
Outdated
Show resolved
Hide resolved
...ugins/discover/public/context_awareness/profile_providers/common/deprecation_logs/profile.ts
Outdated
Show resolved
Hide resolved
|
Thanks for the suggestions @davismcphee ! Just pushed a commit adding them 😄 |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12276562902 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 11, 2024
## Summary resolves elastic#201538 Added a profile to the deprecation logs so by default it shows the columns. Decided to allow this behaviour if the pattern contains multiple patterns for deprecation logs like: `.logs-deprecation.abc,.logs-deprecation.def` , this can be easily changed if we prefer not to do it this way. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit c423e3e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 11, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Make link to es deprecation logs more useful (#203487)](#203487) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jesus Wahrman","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-11T12:40:27Z","message":"Make link to es deprecation logs more useful (#203487)\n\n## Summary\r\n\r\nresolves https://github.com/elastic/kibana/issues/201538\r\n\r\nAdded a profile to the deprecation logs so by default it shows the\r\ncolumns. Decided to allow this behaviour if the pattern contains\r\nmultiple patterns for deprecation logs like:\r\n`.logs-deprecation.abc,.logs-deprecation.def` , this can be easily\r\nchanged if we prefer not to do it this way.\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"c423e3e9d3bd61041d4e10e72cef01ea663ca5bf","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"Make link to es deprecation logs more useful","number":203487,"url":"https://github.com/elastic/kibana/pull/203487","mergeCommit":{"message":"Make link to es deprecation logs more useful (#203487)\n\n## Summary\r\n\r\nresolves https://github.com/elastic/kibana/issues/201538\r\n\r\nAdded a profile to the deprecation logs so by default it shows the\r\ncolumns. Decided to allow this behaviour if the pattern contains\r\nmultiple patterns for deprecation logs like:\r\n`.logs-deprecation.abc,.logs-deprecation.def` , this can be easily\r\nchanged if we prefer not to do it this way.\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"c423e3e9d3bd61041d4e10e72cef01ea663ca5bf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203487","number":203487,"mergeCommit":{"message":"Make link to es deprecation logs more useful (#203487)\n\n## Summary\r\n\r\nresolves https://github.com/elastic/kibana/issues/201538\r\n\r\nAdded a profile to the deprecation logs so by default it shows the\r\ncolumns. Decided to allow this behaviour if the pattern contains\r\nmultiple patterns for deprecation logs like:\r\n`.logs-deprecation.abc,.logs-deprecation.def` , this can be easily\r\nchanged if we prefer not to do it this way.\r\n\r\n\r\n### Checklist\r\n\r\nCheck the PR satisfies following conditions. \r\n\r\nReviewers should verify this PR satisfies this list as well.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"c423e3e9d3bd61041d4e10e72cef01ea663ca5bf"}}]}] BACKPORT--> Co-authored-by: Jesus Wahrman <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary resolves elastic#201538 Added a profile to the deprecation logs so by default it shows the columns. Decided to allow this behaviour if the pattern contains multiple patterns for deprecation logs like: `.logs-deprecation.abc,.logs-deprecation.def` , this can be easily changed if we prefer not to do it this way. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolves #201538
Added a profile to the deprecation logs so by default it shows the columns. Decided to allow this behaviour if the pattern contains multiple patterns for deprecation logs like:
.logs-deprecation.abc,.logs-deprecation.def, this can be easily changed if we prefer not to do it this way.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines