[Search][Connectors] Disable setup options after creating configuration #203374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoseLuisGJ
changed the title
JoseLuisGJ
added
v8.16.2
release_note:skip
|
LGTM @JoseLuisGJ! But another question: isn’t this step a bit misleading? We tell the user they’ll only see the API key once at this stage, but then at the next step (deployment), we actually need the same API key again to configure the connector. Maybe we should just automatically the configuration and automatically proceed to the next step? |
|
Hey @jedrazb If we choose Elastic managed: we generate the config and convey this config including the API key shown only once at this point. Whereas if we choose Self-managed we only let users go to the new Dseployment step, and there we automatically generate the config and convey it to the users. |
jedrazb
approved these changes
Dec 9, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
cc @JoseLuisGJ |
|
Starting backport for target branches: 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12234484402 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 9, 2024
…on (elastic#203374) ## Summary This PR disables the _Elastic managed_ and _Self-managed_ setup options after clicking the _Generate configuration_ button in order to avoid the error described in this ticket elastic/search-team#8665 when changing deployment method after generating the config.  (cherry picked from commit 9b6af1c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 9, 2024
…on (elastic#203374) ## Summary This PR disables the _Elastic managed_ and _Self-managed_ setup options after clicking the _Generate configuration_ button in order to avoid the error described in this ticket elastic/search-team#8665 when changing deployment method after generating the config.  (cherry picked from commit 9b6af1c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 9, 2024
…on (elastic#203374) ## Summary This PR disables the _Elastic managed_ and _Self-managed_ setup options after clicking the _Generate configuration_ button in order to avoid the error described in this ticket elastic/search-team#8665 when changing deployment method after generating the config.  (cherry picked from commit 9b6af1c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 9, 2024
…guration (#203374) (#203395) # Backport This will backport the following commits from `main` to `8.x`: - [[Search][Connectors] Disable setup options after creating configuration (#203374)](#203374) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"José Luis González","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-09T11:15:54Z","message":"[Search][Connectors] Disable setup options after creating configuration (#203374)\n\n## Summary\r\n\r\nThis PR disables the _Elastic managed_ and _Self-managed_ setup options\r\nafter clicking the _Generate configuration_ button in order to avoid the\r\nerror described in this ticket\r\nhttps://github.com/elastic/search-team/issues/8665 when changing\r\ndeployment method after generating the config.\r\n\r\n","sha":"9b6af1c1887f83d821d6fc639715ad4be593fea7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0","v8.16.2","v8.16.3"],"title":"[Search][Connectors] Disable setup options after creating configuration","number":203374,"url":"https://github.com/elastic/kibana/pull/203374","mergeCommit":{"message":"[Search][Connectors] Disable setup options after creating configuration (#203374)\n\n## Summary\r\n\r\nThis PR disables the _Elastic managed_ and _Self-managed_ setup options\r\nafter clicking the _Generate configuration_ button in order to avoid the\r\nerror described in this ticket\r\nhttps://github.com/elastic/search-team/issues/8665 when changing\r\ndeployment method after generating the config.\r\n\r\n","sha":"9b6af1c1887f83d821d6fc639715ad4be593fea7"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203374","number":203374,"mergeCommit":{"message":"[Search][Connectors] Disable setup options after creating configuration (#203374)\n\n## Summary\r\n\r\nThis PR disables the _Elastic managed_ and _Self-managed_ setup options\r\nafter clicking the _Generate configuration_ button in order to avoid the\r\nerror described in this ticket\r\nhttps://github.com/elastic/search-team/issues/8665 when changing\r\ndeployment method after generating the config.\r\n\r\n","sha":"9b6af1c1887f83d821d6fc639715ad4be593fea7"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: José Luis González <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 9, 2024
…iguration (#203374) (#203394) # Backport This will backport the following commits from `main` to `8.17`: - [[Search][Connectors] Disable setup options after creating configuration (#203374)](#203374) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"José Luis González","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-09T11:15:54Z","message":"[Search][Connectors] Disable setup options after creating configuration (#203374)\n\n## Summary\r\n\r\nThis PR disables the _Elastic managed_ and _Self-managed_ setup options\r\nafter clicking the _Generate configuration_ button in order to avoid the\r\nerror described in this ticket\r\nhttps://github.com/elastic/search-team/issues/8665 when changing\r\ndeployment method after generating the config.\r\n\r\n","sha":"9b6af1c1887f83d821d6fc639715ad4be593fea7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0","v8.16.2","v8.16.3"],"title":"[Search][Connectors] Disable setup options after creating configuration","number":203374,"url":"https://github.com/elastic/kibana/pull/203374","mergeCommit":{"message":"[Search][Connectors] Disable setup options after creating configuration (#203374)\n\n## Summary\r\n\r\nThis PR disables the _Elastic managed_ and _Self-managed_ setup options\r\nafter clicking the _Generate configuration_ button in order to avoid the\r\nerror described in this ticket\r\nhttps://github.com/elastic/search-team/issues/8665 when changing\r\ndeployment method after generating the config.\r\n\r\n","sha":"9b6af1c1887f83d821d6fc639715ad4be593fea7"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203374","number":203374,"mergeCommit":{"message":"[Search][Connectors] Disable setup options after creating configuration (#203374)\n\n## Summary\r\n\r\nThis PR disables the _Elastic managed_ and _Self-managed_ setup options\r\nafter clicking the _Generate configuration_ button in order to avoid the\r\nerror described in this ticket\r\nhttps://github.com/elastic/search-team/issues/8665 when changing\r\ndeployment method after generating the config.\r\n\r\n","sha":"9b6af1c1887f83d821d6fc639715ad4be593fea7"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: José Luis González <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 9, 2024
…iguration (#203374) (#203393) # Backport This will backport the following commits from `main` to `8.16`: - [[Search][Connectors] Disable setup options after creating configuration (#203374)](#203374) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"José Luis González","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-09T11:15:54Z","message":"[Search][Connectors] Disable setup options after creating configuration (#203374)\n\n## Summary\r\n\r\nThis PR disables the _Elastic managed_ and _Self-managed_ setup options\r\nafter clicking the _Generate configuration_ button in order to avoid the\r\nerror described in this ticket\r\nhttps://github.com/elastic/search-team/issues/8665 when changing\r\ndeployment method after generating the config.\r\n\r\n","sha":"9b6af1c1887f83d821d6fc639715ad4be593fea7","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:version","v8.17.0","v8.18.0","v8.16.2","v8.16.3"],"title":"[Search][Connectors] Disable setup options after creating configuration","number":203374,"url":"https://github.com/elastic/kibana/pull/203374","mergeCommit":{"message":"[Search][Connectors] Disable setup options after creating configuration (#203374)\n\n## Summary\r\n\r\nThis PR disables the _Elastic managed_ and _Self-managed_ setup options\r\nafter clicking the _Generate configuration_ button in order to avoid the\r\nerror described in this ticket\r\nhttps://github.com/elastic/search-team/issues/8665 when changing\r\ndeployment method after generating the config.\r\n\r\n","sha":"9b6af1c1887f83d821d6fc639715ad4be593fea7"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203374","number":203374,"mergeCommit":{"message":"[Search][Connectors] Disable setup options after creating configuration (#203374)\n\n## Summary\r\n\r\nThis PR disables the _Elastic managed_ and _Self-managed_ setup options\r\nafter clicking the _Generate configuration_ button in order to avoid the\r\nerror described in this ticket\r\nhttps://github.com/elastic/search-team/issues/8665 when changing\r\ndeployment method after generating the config.\r\n\r\n","sha":"9b6af1c1887f83d821d6fc639715ad4be593fea7"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: José Luis González <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
…on (elastic#203374) ## Summary This PR disables the _Elastic managed_ and _Self-managed_ setup options after clicking the _Generate configuration_ button in order to avoid the error described in this ticket elastic/search-team#8665 when changing deployment method after generating the config. 
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Dec 10, 2024
…on (elastic#203374) ## Summary This PR disables the _Elastic managed_ and _Self-managed_ setup options after clicking the _Generate configuration_ button in order to avoid the error described in this ticket elastic/search-team#8665 when changing deployment method after generating the config. 
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this pull request
Dec 11, 2024
…on (elastic#203374) ## Summary This PR disables the _Elastic managed_ and _Self-managed_ setup options after clicking the _Generate configuration_ button in order to avoid the error described in this ticket elastic/search-team#8665 when changing deployment method after generating the config. 
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…on (elastic#203374) ## Summary This PR disables the _Elastic managed_ and _Self-managed_ setup options after clicking the _Generate configuration_ button in order to avoid the error described in this ticket elastic/search-team#8665 when changing deployment method after generating the config. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR disables the Elastic managed and Self-managed setup options after clicking the Generate configuration button in order to avoid the error described in this ticket https://github.com/elastic/search-team/issues/8665 when changing deployment method after generating the config.