Refactor SearchSource interface #20334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
cjcenizal
force-pushed
the
refactor-search-source
branch
from
944bffd to
f802938
Compare
💔 Build Failed |
cjcenizal
force-pushed
the
refactor-search-source
branch
2 times, most recently
from
f3c9e36 to
455d51c
Compare
💔 Build Failed |
cjcenizal
force-pushed
the
refactor-search-source
branch
from
455d51c to
890b4ed
Compare
💔 Build Failed |
cjcenizal
force-pushed
the
refactor-search-source
branch
from
890b4ed to
a8a5bd0
Compare
💔 Build Failed |
cjcenizal
force-pushed
the
refactor-search-source
branch
2 times, most recently
from
0c77b46 to
2f848c7
Compare
💔 Build Failed |
cjcenizal
force-pushed
the
refactor-search-source
branch
from
2f848c7 to
03e8982
Compare
💔 Build Failed |
cjcenizal
force-pushed
the
refactor-search-source
branch
from
03e8982 to
d1596ed
Compare
|
Retest |
cjcenizal
force-pushed
the
refactor-search-source
branch
from
d1596ed to
60ab3c9
Compare
💚 Build Succeeded |
💔 Build Failed |
cjcenizal
force-pushed
the
refactor-search-source
branch
from
cb792f3 to
3713c31
Compare
💔 Build Failed |
cjcenizal
force-pushed
the
refactor-search-source
branch
from
fdf0082 to
85b0f28
Compare
💚 Build Succeeded |
💚 Build Succeeded |
jen-huang
approved these changes
Jul 3, 2018
💔 Build Failed |
cjcenizal
force-pushed
the
refactor-search-source
branch
from
ad6b2b5 to
9e3f6a9
Compare
- Replace chainable methods with single setValue method. - Rename set method to overwrite, and simplify it. Rename get to getValue and getOwn to getOwnValue.
- Rename methods: new -> create, clone -> createCopy, makeChild -> createChild. - Remove unused enable, disable, and addFilterPredicate methods. - Group methods by cohesiveness.
…Data. Rename _state to _data internally.
cjcenizal
force-pushed
the
refactor-search-source
branch
from
9e3f6a9 to
1c431c7
Compare
💔 Build Failed |
💚 Build Succeeded |
cjcenizal
added a commit
that referenced
this pull request
Jul 3, 2018
* Removed the dynamically assigned type, query, filter, sort, highlight, highlightAll, aggs, from, searchAfter, size, source, version, and fields methods. * The accessor interface now consists of getField and setField methods which throw errors if an unrecognized property name is provided, in addition to getFields, setFields, getOwnField, and getId methods. * Linked-list interface now consists of setParent and getParent. * Factory interface now consists of create, createCopy, and createChild. * Removed the unused unused enable, disable, and addFilterPredicate, and the redundant toString (method only used internally) and extend method (superseded by createChild). * Internally, renamed the _state property to _data and grouped methods by concern.
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Jul 3, 2018
* Removed the dynamically assigned type, query, filter, sort, highlight, highlightAll, aggs, from, searchAfter, size, source, version, and fields methods. * The accessor interface now consists of getField and setField methods which throw errors if an unrecognized property name is provided, in addition to getFields, setFields, getOwnField, and getId methods. * Linked-list interface now consists of setParent and getParent. * Factory interface now consists of create, createCopy, and createChild. * Removed the unused unused enable, disable, and addFilterPredicate, and the redundant toString (method only used internally) and extend method (superseded by createChild). * Internally, renamed the _state property to _data and grouped methods by concern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists largely of interface changes and some minor internal changes to make the code a bit clearer. Reviewing one commit at a time should make the changes easier to digest.
type,query,filter,sort,highlight,highlightAll,aggs,from,searchAfter,size,source,version, andfieldsmethods.getValueandsetValuemethods which throw errors if an unrecognized property name is provided, in addition tosetIndexPattern,getData,setData,getOwnValue, andgetIdmethods.setParentandgetParent.create,createCopy, andcreateChild.enable,disable, andaddFilterPredicate, and the redundanttoString(method only used internally) andextendmethod (superseded bycreateChild).Internally, I renamed the
_stateproperty to_dataand grouped methods by concern.