Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [EuiProvider] Hide unwanted toast until a fix can be done !! (#203244) #203327

Merged
merged 1 commit into from
Dec 6, 2024
Merged

[8.x] [EuiProvider] Hide unwanted toast until a fix can be done !! (#203244) #203327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ export class ChromeService {
};

// Ensure developers are notified if working in a context that lacks the EUI Provider.
// @ts-expect-error
private handleEuiDevProviderWarning = (notifications: NotificationsStart) => {
const isDev = this.params.coreContext.env.mode.name === 'development';
if (isDev) {
Expand Down Expand Up @@ -240,7 +241,8 @@ export class ChromeService {
}: StartDeps): Promise<InternalChromeStart> {
this.initVisibility(application);
this.handleEuiFullScreenChanges();
this.handleEuiDevProviderWarning(notifications);
// commented out until https://github.com/elastic/kibana/issues/201805 can be fixed
// this.handleEuiDevProviderWarning(notifications);

const globalHelpExtensionMenuLinks$ = new BehaviorSubject<ChromeGlobalHelpExtensionMenuLink[]>(
[]
Expand Down
3 changes: 2 additions & 1 deletion test/plugin_functional/test_suites/shared_ux/eui_provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ export default function ({ getPageObjects, getService }: PluginFunctionalProvide
const testSubjects = getService('testSubjects');
const browser = getService('browser');

describe('EUI Provider Dev Warning', () => {
// skipped until https://github.com/elastic/kibana/issues/201805 is resolved
describe.skip('EUI Provider Dev Warning', () => {
it('shows error toast to developer', async () => {
const pageTitle = 'EuiProvider test - Elastic';

Expand Down
Loading