Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only run quick checks for changes to renovate.json #203153

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Only run quick checks for changes to renovate.json #203153

merged 4 commits into from
Dec 17, 2024

Conversation

legrego
Copy link
Member

@legrego legrego commented Dec 5, 2024 •
edited by kibanamachine
Loading

Summary

Introduces a new renovate CI pipeline to only run quick checks for PRs which only adjust the renovate.json configuration file.

legrego
legrego commented Dec 5, 2024
View reviewed changes
.buildkite/pipelines/pull_request/renovate.yml Outdated
Comment on lines 2 to 23
# - command: .buildkite/scripts/lifecycle/pre_build.sh
# label: Pre-Build
# timeout_in_minutes: 10
# agents:
# machineType: n2-standard-2

# - wait

# - command: .buildkite/scripts/steps/build_kibana.sh
# label: Build Kibana Distribution
# agents:
# machineType: n2-standard-8
# preemptible: true
# diskSizeGb: 125
# key: build
# if: "build.env('KIBANA_BUILD_ID') == null || build.env('KIBANA_BUILD_ID') == ''"
# timeout_in_minutes: 90
# retry:
# automatic:
# - exit_status: '-1'
# limit: 3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from the base pipeline. I assume I don't need these, but would appreciate confirmation 🙏

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will want pre and post build steps to run. The build step is not necessary

@legrego legrego added Team:Operations Team label for Operations Team Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Dec 5, 2024
@legrego legrego marked this pull request as ready for review December 5, 2024 17:27
@legrego legrego requested a review from a team as a code owner December 5, 2024 17:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

Ikuni17
Ikuni17 reviewed Dec 5, 2024
View reviewed changes
.buildkite/pipelines/pull_request/renovate.yml Outdated
Comment on lines 2 to 23
# - command: .buildkite/scripts/lifecycle/pre_build.sh
# label: Pre-Build
# timeout_in_minutes: 10
# agents:
# machineType: n2-standard-2

# - wait

# - command: .buildkite/scripts/steps/build_kibana.sh
# label: Build Kibana Distribution
# agents:
# machineType: n2-standard-8
# preemptible: true
# diskSizeGb: 125
# key: build
# if: "build.env('KIBANA_BUILD_ID') == null || build.env('KIBANA_BUILD_ID') == ''"
# timeout_in_minutes: 90
# retry:
# automatic:
# - exit_status: '-1'
# limit: 3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will want pre and post build steps to run. The build step is not necessary

.buildkite/pipelines/pull_request/renovate.yml Outdated Show resolved Hide resolved
.buildkite/scripts/pipelines/pull_request/pipeline.ts Outdated Show resolved Hide resolved
@legrego legrego requested a review from Ikuni17 December 6, 2024 16:27
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@legrego legrego merged commit 591d640 into elastic:main Dec 17, 2024
9 checks passed
@legrego
Copy link
Member Author

legrego commented Dec 17, 2024

@Ikuni17 Sorry to bother you -- can you help me debug a job failure? I think I misconfigured something here:

https://buildkite.com/elastic/kibana-pull-request/builds/261559#0193d621-affe-43d2-88f0-d39ea0e3efc9

From PR: #204649

@Ikuni17 Ikuni17 removed the backport:skip This commit does not require backporting label Dec 17, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 17, 2024
@Ikuni17 Ikuni17 added backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development and removed backport:skip This commit does not require backporting labels Dec 17, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12383442412

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 17, 2024
@legrego
Only run quick checks for changes to renovate.json (elastic#203153)
ed9e3e0 
## Summary

Introduces a new `renovate` CI pipeline to only run quick checks for PRs
which only adjust the `renovate.json` configuration file.

(cherry picked from commit 591d640)
@kibanamachine kibanamachine mentioned this pull request Dec 17, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 17, 2024
@legrego
Only run quick checks for changes to renovate.json (elastic#203153)
a503bde 
## Summary

Introduces a new `renovate` CI pipeline to only run quick checks for PRs
which only adjust the `renovate.json` configuration file.

(cherry picked from commit 591d640)
@kibanamachine kibanamachine mentioned this pull request Dec 17, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 17, 2024
@legrego
Only run quick checks for changes to renovate.json (elastic#203153)
f2de925 
## Summary

Introduces a new `renovate` CI pipeline to only run quick checks for PRs
which only adjust the `renovate.json` configuration file.

(cherry picked from commit 591d640)
@kibanamachine kibanamachine mentioned this pull request Dec 17, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.16
✅ 8.17
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 18, 2024
@kibanamachine @legrego
[8.x] Only run quick checks for changes to renovate.json (#203153) (#…
b86b55a 
…204675)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Only run quick checks for changes to renovate.json
(#203153)](#203153)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Larry
Gregory","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-17T13:59:43Z","message":"Only
run quick checks for changes to renovate.json (#203153)\n\n##
Summary\n\nIntroduces a new `renovate` CI pipeline to only run quick
checks for PRs\nwhich only adjust the `renovate.json` configuration
file.","sha":"591d640b1fe21dc847338a535c142153f2b50e80","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Team:Security","release_note:skip","v9.0.0","backport:prev-major"],"title":"Only
run quick checks for changes to
renovate.json","number":203153,"url":"https://github.com/elastic/kibana/pull/203153","mergeCommit":{"message":"Only
run quick checks for changes to renovate.json (#203153)\n\n##
Summary\n\nIntroduces a new `renovate` CI pipeline to only run quick
checks for PRs\nwhich only adjust the `renovate.json` configuration
file.","sha":"591d640b1fe21dc847338a535c142153f2b50e80"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203153","number":203153,"mergeCommit":{"message":"Only
run quick checks for changes to renovate.json (#203153)\n\n##
Summary\n\nIntroduces a new `renovate` CI pipeline to only run quick
checks for PRs\nwhich only adjust the `renovate.json` configuration
file.","sha":"591d640b1fe21dc847338a535c142153f2b50e80"}}]}] BACKPORT-->

Co-authored-by: Larry Gregory <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 18, 2024
@kibanamachine @legrego
[8.17] Only run quick checks for changes to renovate.json (#203153) (#…
a06b6a2 
…204674)

# Backport

This will backport the following commits from `main` to `8.17`:
- [Only run quick checks for changes to renovate.json
(#203153)](#203153)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Larry
Gregory","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-17T13:59:43Z","message":"Only
run quick checks for changes to renovate.json (#203153)\n\n##
Summary\n\nIntroduces a new `renovate` CI pipeline to only run quick
checks for PRs\nwhich only adjust the `renovate.json` configuration
file.","sha":"591d640b1fe21dc847338a535c142153f2b50e80","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Team:Security","release_note:skip","v9.0.0","backport:prev-major"],"title":"Only
run quick checks for changes to
renovate.json","number":203153,"url":"https://github.com/elastic/kibana/pull/203153","mergeCommit":{"message":"Only
run quick checks for changes to renovate.json (#203153)\n\n##
Summary\n\nIntroduces a new `renovate` CI pipeline to only run quick
checks for PRs\nwhich only adjust the `renovate.json` configuration
file.","sha":"591d640b1fe21dc847338a535c142153f2b50e80"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203153","number":203153,"mergeCommit":{"message":"Only
run quick checks for changes to renovate.json (#203153)\n\n##
Summary\n\nIntroduces a new `renovate` CI pipeline to only run quick
checks for PRs\nwhich only adjust the `renovate.json` configuration
file.","sha":"591d640b1fe21dc847338a535c142153f2b50e80"}}]}] BACKPORT-->

Co-authored-by: Larry Gregory <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 18, 2024
@kibanamachine @legrego
[8.16] Only run quick checks for changes to renovate.json (#203153) (#…
7cf56ea 
…204673)

# Backport

This will backport the following commits from `main` to `8.16`:
- [Only run quick checks for changes to renovate.json
(#203153)](#203153)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Larry
Gregory","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-17T13:59:43Z","message":"Only
run quick checks for changes to renovate.json (#203153)\n\n##
Summary\n\nIntroduces a new `renovate` CI pipeline to only run quick
checks for PRs\nwhich only adjust the `renovate.json` configuration
file.","sha":"591d640b1fe21dc847338a535c142153f2b50e80","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Team:Security","release_note:skip","v9.0.0","backport:prev-major"],"title":"Only
run quick checks for changes to
renovate.json","number":203153,"url":"https://github.com/elastic/kibana/pull/203153","mergeCommit":{"message":"Only
run quick checks for changes to renovate.json (#203153)\n\n##
Summary\n\nIntroduces a new `renovate` CI pipeline to only run quick
checks for PRs\nwhich only adjust the `renovate.json` configuration
file.","sha":"591d640b1fe21dc847338a535c142153f2b50e80"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203153","number":203153,"mergeCommit":{"message":"Only
run quick checks for changes to renovate.json (#203153)\n\n##
Summary\n\nIntroduces a new `renovate` CI pipeline to only run quick
checks for PRs\nwhich only adjust the `renovate.json` configuration
file.","sha":"591d640b1fe21dc847338a535c142153f2b50e80"}}]}] BACKPORT-->

Co-authored-by: Larry Gregory <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
@legrego @JoseLuisGJ
Only run quick checks for changes to renovate.json (elastic#203153)
d69be6d 
## Summary

Introduces a new `renovate` CI pipeline to only run quick checks for PRs
which only adjust the `renovate.json` configuration file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ikuni17 Ikuni17 Ikuni17 approved these changes

Assignees
No one assigned
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.16.3 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legrego @elasticmachine @kibanamachine @Ikuni17