Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌊 Streams: Set subobjects: false #203002

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Dec 4, 2024

With elastic/elasticsearch#117544 fixed, subobjects: false can be set on wired streams.

This allows to map fields as scalars even if they share the same prefix, e.g.

  • deeply.nested.path as keyword
  • deeply.nested.path.and.more as keyword

@flash1293 flash1293 added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.18.0 Feature:Streams This is the label for the Streams Project labels Dec 4, 2024
@flash1293 flash1293 requested a review from a team as a code owner December 4, 2024 18:40
@simianhacker simianhacker self-requested a review December 6, 2024 18:01
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flash1293 flash1293 enabled auto-merge (squash) December 10, 2024 10:01
@flash1293 flash1293 merged commit 7f3c642 into elastic:main Dec 10, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12255160760

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
With elastic/elasticsearch#117544 fixed,
`subobjects: false` can be set on wired streams.

This allows to map fields as scalars even if they share the same prefix,
e.g.
* `deeply.nested.path` as `keyword`
* `deeply.nested.path.and.more` as `keyword`

(cherry picked from commit 7f3c642)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 10, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [🌊 Streams: Set subobjects: false
(#203002)](#203002)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Joe
Reuter","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T11:28:13Z","message":"🌊
Streams: Set subobjects: false (#203002)\n\nWith
elastic/elasticsearch#117544
fixed,\r\n`subobjects: false` can be set on wired streams.\r\n\r\nThis
allows to map fields as scalars even if they share the same
prefix,\r\ne.g.\r\n* `deeply.nested.path` as `keyword`\r\n*
`deeply.nested.path.and.more` as
`keyword`","sha":"7f3c642c0a3717a0f71275051fd35a48f88a1e0a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.18.0","Feature:Streams"],"title":"🌊
Streams: Set subobjects:
false","number":203002,"url":"https://github.com/elastic/kibana/pull/203002","mergeCommit":{"message":"🌊
Streams: Set subobjects: false (#203002)\n\nWith
elastic/elasticsearch#117544
fixed,\r\n`subobjects: false` can be set on wired streams.\r\n\r\nThis
allows to map fields as scalars even if they share the same
prefix,\r\ne.g.\r\n* `deeply.nested.path` as `keyword`\r\n*
`deeply.nested.path.and.more` as
`keyword`","sha":"7f3c642c0a3717a0f71275051fd35a48f88a1e0a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203002","number":203002,"mergeCommit":{"message":"🌊
Streams: Set subobjects: false (#203002)\n\nWith
elastic/elasticsearch#117544
fixed,\r\n`subobjects: false` can be set on wired streams.\r\n\r\nThis
allows to map fields as scalars even if they share the same
prefix,\r\ne.g.\r\n* `deeply.nested.path` as `keyword`\r\n*
`deeply.nested.path.and.more` as
`keyword`","sha":"7f3c642c0a3717a0f71275051fd35a48f88a1e0a"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Joe Reuter <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
With elastic/elasticsearch#117544 fixed,
`subobjects: false` can be set on wired streams.

This allows to map fields as scalars even if they share the same prefix,
e.g.
* `deeply.nested.path` as `keyword`
* `deeply.nested.path.and.more` as `keyword`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants