-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌊 Streams: Set subobjects: false #203002
Merged
Merged
🌊 Streams: Set subobjects: false #203002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
release_note:skip
Skip the PR/issue when compiling release notes
v9.0.0
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
v8.18.0
Feature:Streams
This is the label for the Streams Project
labels
Dec 4, 2024
simianhacker
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12255160760 |
💚 Build Succeeded
Metrics [docs]
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 10, 2024
With elastic/elasticsearch#117544 fixed, `subobjects: false` can be set on wired streams. This allows to map fields as scalars even if they share the same prefix, e.g. * `deeply.nested.path` as `keyword` * `deeply.nested.path.and.more` as `keyword` (cherry picked from commit 7f3c642)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 10, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [🌊 Streams: Set subobjects: false (#203002)](#203002) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe Reuter","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T11:28:13Z","message":"🌊 Streams: Set subobjects: false (#203002)\n\nWith elastic/elasticsearch#117544 fixed,\r\n`subobjects: false` can be set on wired streams.\r\n\r\nThis allows to map fields as scalars even if they share the same prefix,\r\ne.g.\r\n* `deeply.nested.path` as `keyword`\r\n* `deeply.nested.path.and.more` as `keyword`","sha":"7f3c642c0a3717a0f71275051fd35a48f88a1e0a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","v8.18.0","Feature:Streams"],"title":"🌊 Streams: Set subobjects: false","number":203002,"url":"https://github.com/elastic/kibana/pull/203002","mergeCommit":{"message":"🌊 Streams: Set subobjects: false (#203002)\n\nWith elastic/elasticsearch#117544 fixed,\r\n`subobjects: false` can be set on wired streams.\r\n\r\nThis allows to map fields as scalars even if they share the same prefix,\r\ne.g.\r\n* `deeply.nested.path` as `keyword`\r\n* `deeply.nested.path.and.more` as `keyword`","sha":"7f3c642c0a3717a0f71275051fd35a48f88a1e0a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203002","number":203002,"mergeCommit":{"message":"🌊 Streams: Set subobjects: false (#203002)\n\nWith elastic/elasticsearch#117544 fixed,\r\n`subobjects: false` can be set on wired streams.\r\n\r\nThis allows to map fields as scalars even if they share the same prefix,\r\ne.g.\r\n* `deeply.nested.path` as `keyword`\r\n* `deeply.nested.path.and.more` as `keyword`","sha":"7f3c642c0a3717a0f71275051fd35a48f88a1e0a"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Joe Reuter <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
With elastic/elasticsearch#117544 fixed, `subobjects: false` can be set on wired streams. This allows to map fields as scalars even if they share the same prefix, e.g. * `deeply.nested.path` as `keyword` * `deeply.nested.path.and.more` as `keyword`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
Feature:Streams
This is the label for the Streams Project
release_note:skip
Skip the PR/issue when compiling release notes
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With elastic/elasticsearch#117544 fixed,
subobjects: false
can be set on wired streams.This allows to map fields as scalars even if they share the same prefix, e.g.
deeply.nested.path
askeyword
deeply.nested.path.and.more
askeyword