[SLOs] Added $state into filters schema !! #202887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
|
| query: t.record(t.string, t.any), | ||
| }), | ||
| t.partial({ | ||
| $state: t.any, |
There was a problem hiding this comment.
Is it going to be the same data that we store in the SLO's instance? Was there an issue when this type was not present?
There was a problem hiding this comment.
we don't store this normall anymore from UI. it's just to be backward compatible.
There was a problem hiding this comment.
I don't understand what is that for? Can you open an issue stating the problem that this PR is actually solving please?
There was a problem hiding this comment.
Apparently we were allowing excess keys for a while, resulting in some SLOs created with some $state: { store: "appState" }overhead. Then excess keys become not allowed somewhere in 8.16, which breaks any API using the filterSchema when provided with such $state key.
This part of the API is really just a dump of the UI settings, nothing better we can do here. I don't expect customer to use that directly
There was a problem hiding this comment.
I think it would be better to avoid saving $state in the SLO instance since it is only related to UI. Can we do that by sanitizing the data before passing it to the API? (more info)
Reading your comment again:
we don't store this normall anymore from UI.
Does it mean we have different types for the SLO instance that we save and API calls? I think my main question is how our public API will look like and if this type is used there.
There was a problem hiding this comment.
Btw, if this issue was introduced in 8.16, then we don't need to backport it to 8.15:
There was a problem hiding this comment.
we don't do that anymore, it's just for backward compatability.
kdelemme
approved these changes
Dec 4, 2024
|
Starting backport for target branches: 8.15, 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12176632586 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 5, 2024
## Summary fixes elastic#202999 Added $state into filters schema !! (cherry picked from commit 51e63ee)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 5, 2024
## Summary fixes elastic#202999 Added $state into filters schema !! (cherry picked from commit 51e63ee)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 5, 2024
## Summary fixes elastic#202999 Added $state into filters schema !! (cherry picked from commit 51e63ee)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 5, 2024
## Summary fixes elastic#202999 Added $state into filters schema !! (cherry picked from commit 51e63ee)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 5, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [[SLOs] Added $state into filters schema !! (#202887)](#202887) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T09:12:48Z","message":"[SLOs] Added $state into filters schema !! (#202887)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/202999\r\n\r\nAdded $state into filters schema !!","sha":"51e63eeaccd9998d473ef62d11d530697a836e7f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major"],"title":"[SLOs] Added $state into filters schema !!","number":202887,"url":"https://github.com/elastic/kibana/pull/202887","mergeCommit":{"message":"[SLOs] Added $state into filters schema !! (#202887)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/202999\r\n\r\nAdded $state into filters schema !!","sha":"51e63eeaccd9998d473ef62d11d530697a836e7f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202887","number":202887,"mergeCommit":{"message":"[SLOs] Added $state into filters schema !! (#202887)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/202999\r\n\r\nAdded $state into filters schema !!","sha":"51e63eeaccd9998d473ef62d11d530697a836e7f"}}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 5, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [[SLOs] Added $state into filters schema !! (#202887)](#202887) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T09:12:48Z","message":"[SLOs] Added $state into filters schema !! (#202887)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/202999\r\n\r\nAdded $state into filters schema !!","sha":"51e63eeaccd9998d473ef62d11d530697a836e7f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major"],"title":"[SLOs] Added $state into filters schema !!","number":202887,"url":"https://github.com/elastic/kibana/pull/202887","mergeCommit":{"message":"[SLOs] Added $state into filters schema !! (#202887)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/202999\r\n\r\nAdded $state into filters schema !!","sha":"51e63eeaccd9998d473ef62d11d530697a836e7f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202887","number":202887,"mergeCommit":{"message":"[SLOs] Added $state into filters schema !! (#202887)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/202999\r\n\r\nAdded $state into filters schema !!","sha":"51e63eeaccd9998d473ef62d11d530697a836e7f"}}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 5, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[SLOs] Added $state into filters schema !! (#202887)](#202887) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T09:12:48Z","message":"[SLOs] Added $state into filters schema !! (#202887)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/202999\r\n\r\nAdded $state into filters schema !!","sha":"51e63eeaccd9998d473ef62d11d530697a836e7f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major"],"title":"[SLOs] Added $state into filters schema !!","number":202887,"url":"https://github.com/elastic/kibana/pull/202887","mergeCommit":{"message":"[SLOs] Added $state into filters schema !! (#202887)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/202999\r\n\r\nAdded $state into filters schema !!","sha":"51e63eeaccd9998d473ef62d11d530697a836e7f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202887","number":202887,"mergeCommit":{"message":"[SLOs] Added $state into filters schema !! (#202887)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/202999\r\n\r\nAdded $state into filters schema !!","sha":"51e63eeaccd9998d473ef62d11d530697a836e7f"}}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 5, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[SLOs] Added $state into filters schema !! (#202887)](#202887) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-05T09:12:48Z","message":"[SLOs] Added $state into filters schema !! (#202887)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/202999\r\n\r\nAdded $state into filters schema !!","sha":"51e63eeaccd9998d473ef62d11d530697a836e7f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major"],"title":"[SLOs] Added $state into filters schema !!","number":202887,"url":"https://github.com/elastic/kibana/pull/202887","mergeCommit":{"message":"[SLOs] Added $state into filters schema !! (#202887)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/202999\r\n\r\nAdded $state into filters schema !!","sha":"51e63eeaccd9998d473ef62d11d530697a836e7f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202887","number":202887,"mergeCommit":{"message":"[SLOs] Added $state into filters schema !! (#202887)\n\n## Summary\r\n\r\nfixes https://github.com/elastic/kibana/issues/202999\r\n\r\nAdded $state into filters schema !!","sha":"51e63eeaccd9998d473ef62d11d530697a836e7f"}}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
## Summary fixes elastic#202999 Added $state into filters schema !!
SoniaSanzV
pushed a commit
to SoniaSanzV/kibana
that referenced
this pull request
Dec 9, 2024
## Summary fixes elastic#202999 Added $state into filters schema !!
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
## Summary fixes elastic#202999 Added $state into filters schema !!
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/kibana
that referenced
this pull request
Dec 10, 2024
## Summary fixes elastic#202999 Added $state into filters schema !!
mykolaharmash
pushed a commit
to mykolaharmash/kibana
that referenced
this pull request
Dec 11, 2024
## Summary fixes elastic#202999 Added $state into filters schema !!
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary fixes elastic#202999 Added $state into filters schema !!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #202999
Added $state into filters schema !!