Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix styling popover controls #202865

Merged
merged 8 commits into from
Dec 12, 2024
Merged

[Lens] Fix styling popover controls #202865

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eca1cf9
[Lens] Fix styling popover controls
Ajay-Satish-01 Dec 3, 2024
a02e839
Merge branch 'main' into fix-ui
Ajay-Satish-01 Dec 4, 2024
9ac0540
Replace inline css with fullWidth prop
Ajay-Satish-01 Dec 5, 2024
5647793
Replace inline css with fullWidth prop
Ajay-Satish-01 Dec 5, 2024
b63c816
Update missing_values_option.tsx
mbondyra Dec 5, 2024
86668aa
Update missing_values_option.tsx
mbondyra Dec 5, 2024
9e24b80
Merge branch 'main' into fix-ui
Ajay-Satish-01 Dec 6, 2024
4a9be18
Merge branch 'main' into fix-ui
elasticmachine Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...public/visualizations/xy/xy_config_panel/visual_options_popover/missing_values_option.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import React from 'react';
import { i18n } from '@kbn/i18n';
import { css } from '@emotion/react';
import { EuiFormRow, EuiIconTip, EuiSuperSelect, EuiSwitch, EuiText } from '@elastic/eui';
import type { FittingFunction, EndValue } from '@kbn/expression-xy-plugin/common';
import { FittingFunctions } from '@kbn/expression-xy-plugin/public';
Expand Down Expand Up @@ -88,6 +89,9 @@ export const MissingValuesOptions: React.FC<MissingValuesOptionProps> = ({
{fittingFunction && fittingFunction !== FittingFunctions.NONE && (
<>
<EuiFormRow
css={css`
max-inline-size: none !important;
`}
Ajay-Satish-01 marked this conversation as resolved.
Show resolved Hide resolved
display="columnCompressed"
label={i18n.translate('xpack.lens.xyChart.endValuesLabel', {
defaultMessage: 'End values',
Expand Down Expand Up @@ -117,6 +121,9 @@ export const MissingValuesOptions: React.FC<MissingValuesOptionProps> = ({
/>
</EuiFormRow>
<EuiFormRow
css={css`
max-inline-size: none !important;
`}
Ajay-Satish-01 marked this conversation as resolved.
Show resolved Hide resolved
label={i18n.translate('xpack.lens.xyChart.missingValuesStyle', {
defaultMessage: 'Show as dotted line',
})}
Expand Down