-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] fix schema validation to allow undefined/null #202732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:prev-major
Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development
labels
Dec 3, 2024
botelastic
bot
added
the
Team:Fleet
Team label for Observability Data Collection Fleet team
label
Dec 3, 2024
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
approved these changes
Dec 3, 2024
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --update'
💔 Build Failed
Failed CI StepsHistory |
Starting backport for target branches: 8.15, 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12144716378 |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
juliaElastic
added a commit
to juliaElastic/kibana
that referenced
this pull request
Dec 4, 2024
Fix a few issues encountered with schema validation. One of them reported here: https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332 The other encountered locally when testing upgrades: ``` "Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead." ``` --------- Co-authored-by: kibanamachine <[email protected]>
juliaElastic
added a commit
to juliaElastic/kibana
that referenced
this pull request
Dec 4, 2024
Fix a few issues encountered with schema validation. One of them reported here: https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332 The other encountered locally when testing upgrades: ``` "Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead." ``` --------- Co-authored-by: kibanamachine <[email protected]>
juliaElastic
added a commit
to juliaElastic/kibana
that referenced
this pull request
Dec 4, 2024
Fix a few issues encountered with schema validation. One of them reported here: https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332 The other encountered locally when testing upgrades: ``` "Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead." ``` --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
added
the
backport missing
Added to PRs automatically when the are determined to be missing a backport.
label
Dec 4, 2024
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
juliaElastic
added
backport:skip
This commit does not require backporting
and removed
backport missing
Added to PRs automatically when the are determined to be missing a backport.
labels
Dec 5, 2024
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Dec 5, 2024
## Summary Fix a few issues encountered with schema validation. One of them reported here: https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332 The other encountered locally when testing upgrades: ``` "Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead." ``` --------- Co-authored-by: kibanamachine <[email protected]>
juliaElastic
added a commit
that referenced
this pull request
Dec 9, 2024
…202877) Backport #202732 to 8.x Co-authored-by: kibanamachine <[email protected]>
juliaElastic
added a commit
that referenced
this pull request
Dec 9, 2024
…#202878) Backport #202732 to 8.17 Co-authored-by: kibanamachine <[email protected]>
juliaElastic
added a commit
that referenced
this pull request
Dec 9, 2024
…#202879) Backport #202732 to 8.16 Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
## Summary Fix a few issues encountered with schema validation. One of them reported here: https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332 The other encountered locally when testing upgrades: ``` "Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead." ``` --------- Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Fix a few issues encountered with schema validation. One of them reported here: https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332 The other encountered locally when testing upgrades: ``` "Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead." ``` --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-major
Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Fleet
Team label for Observability Data Collection Fleet team
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a few issues encountered with schema validation.
One of them reported here: https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332
The other encountered locally when testing upgrades: