Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] fix schema validation to allow undefined/null #202732

Merged
merged 4 commits into from
Dec 3, 2024

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Dec 3, 2024

Summary

Fix a few issues encountered with schema validation.

One of them reported here: https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332

The other encountered locally when testing upgrades:

"Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead."

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Dec 3, 2024
@juliaElastic juliaElastic self-assigned this Dec 3, 2024
@juliaElastic juliaElastic requested a review from a team as a code owner December 3, 2024 13:58
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Dec 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --update'
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 3, 2024

💔 Build Failed

Failed CI Steps

History

cc @juliaElastic

@juliaElastic juliaElastic enabled auto-merge (squash) December 3, 2024 15:40
@juliaElastic juliaElastic merged commit 230d661 into elastic:main Dec 3, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12144716378

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.15 Backport failed because of merge conflicts
8.16 Backport failed because of merge conflicts
8.17 Backport failed because of merge conflicts
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- feat(slo): allow configuration of advanced settings from UI (#200822)
- OpenAPI docs for APM UI APIs (#197946)
- [Core] [UA] Support API Deprecations (#196081)

Manual backport

To create the backport manually run:

node scripts/backport --pr 202732

Questions ?

Please refer to the Backport tool documentation

juliaElastic added a commit to juliaElastic/kibana that referenced this pull request Dec 4, 2024
Fix a few issues encountered with schema validation.

One of them reported here:
https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332

The other encountered locally when testing upgrades:
```
"Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead."
```

---------

Co-authored-by: kibanamachine <[email protected]>
juliaElastic added a commit to juliaElastic/kibana that referenced this pull request Dec 4, 2024
Fix a few issues encountered with schema validation.

One of them reported here:
https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332

The other encountered locally when testing upgrades:
```
"Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead."
```

---------

Co-authored-by: kibanamachine <[email protected]>
juliaElastic added a commit to juliaElastic/kibana that referenced this pull request Dec 4, 2024
Fix a few issues encountered with schema validation.

One of them reported here:
https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332

The other encountered locally when testing upgrades:
```
"Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead."
```

---------

Co-authored-by: kibanamachine <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 4, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@juliaElastic juliaElastic added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 5, 2024
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
## Summary

Fix a few issues encountered with schema validation.

One of them reported here:
https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332

The other encountered locally when testing upgrades:
```
"Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead."
```

---------

Co-authored-by: kibanamachine <[email protected]>
juliaElastic added a commit that referenced this pull request Dec 9, 2024
juliaElastic added a commit that referenced this pull request Dec 9, 2024
juliaElastic added a commit that referenced this pull request Dec 9, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
## Summary

Fix a few issues encountered with schema validation.

One of them reported here:
https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332

The other encountered locally when testing upgrades:
```
"Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead."
```

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

Fix a few issues encountered with schema validation.

One of them reported here:
https://discuss.elastic.co/t/fleet-error-updating-policy-settings/371332

The other encountered locally when testing upgrades:
```
"Failed output validation: [request body.items.0.upgrade_details]: expected a plain object value, but found [null] instead."
```

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants