-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Detection Engine] deprecates siem signals migration APIs #202662
[Security Solution][Detection Engine] deprecates siem signals migration APIs #202662
Conversation
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested locally. As expected after sending requests to deprecated routes warnings appear in Upgrade Assistant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @vitaliidm !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc changes and doc links look good.
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12255606546 |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @vitaliidm |
…on APIs (elastic#202662) ## Summary - addresses part of elastic#195523 - deprecates https://www.elastic.co/guide/en/security/current/signals-migration-api.html APIs according to internal 9.x readiness [guideline](https://docs.google.com/document/d/1W7csjn6QYjrBjmbXMzSz_JUD4KcmWz8jTTtAWFwgUJM/edit?tab=t.0#heading=h.tui2zvb9gca6) #### How to test deprecated APIs? 1. Run API https://www.elastic.co/guide/en/security/current/signals-migration-api.html 2. Observe warning deprecation on Kibana Upgrade page <img width="2540" alt="Screenshot 2024-12-03 at 10 43 59" src="https://github.com/user-attachments/assets/24fcebb9-2d31-4ca3-a0dc-4ed7861d26a2"> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 3d46ead)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…igration APIs (#202662) (#203549) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Detection Engine] deprecates siem signals migration APIs (#202662)](#202662) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Vitalii Dmyterko","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T11:58:08Z","message":"[Security Solution][Detection Engine] deprecates siem signals migration APIs (#202662)\n\n## Summary\r\n\r\n - addresses part of https://github.com/elastic/kibana/issues/195523\r\n- deprecates\r\nhttps://www.elastic.co/guide/en/security/current/signals-migration-api.html\r\nAPIs according to internal 9.x readiness\r\n[guideline](https://docs.google.com/document/d/1W7csjn6QYjrBjmbXMzSz_JUD4KcmWz8jTTtAWFwgUJM/edit?tab=t.0#heading=h.tui2zvb9gca6)\r\n \r\n#### How to test deprecated APIs?\r\n\r\n1. Run API\r\nhttps://www.elastic.co/guide/en/security/current/signals-migration-api.html\r\n2. Observe warning deprecation on Kibana Upgrade page\r\n\r\n<img width=\"2540\" alt=\"Screenshot 2024-12-03 at 10 43 59\"\r\nsrc=\"https://github.com/user-attachments/assets/24fcebb9-2d31-4ca3-a0dc-4ed7861d26a2\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"3d46eadace572cbcfb95611224b819e2e67ed006","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:deprecation","v9.0.0","Team:Detections and Resp","Team: SecuritySolution","backport:prev-minor","Team:Detection Engine"],"title":"[Security Solution][Detection Engine] deprecates siem signals migration APIs","number":202662,"url":"https://github.com/elastic/kibana/pull/202662","mergeCommit":{"message":"[Security Solution][Detection Engine] deprecates siem signals migration APIs (#202662)\n\n## Summary\r\n\r\n - addresses part of https://github.com/elastic/kibana/issues/195523\r\n- deprecates\r\nhttps://www.elastic.co/guide/en/security/current/signals-migration-api.html\r\nAPIs according to internal 9.x readiness\r\n[guideline](https://docs.google.com/document/d/1W7csjn6QYjrBjmbXMzSz_JUD4KcmWz8jTTtAWFwgUJM/edit?tab=t.0#heading=h.tui2zvb9gca6)\r\n \r\n#### How to test deprecated APIs?\r\n\r\n1. Run API\r\nhttps://www.elastic.co/guide/en/security/current/signals-migration-api.html\r\n2. Observe warning deprecation on Kibana Upgrade page\r\n\r\n<img width=\"2540\" alt=\"Screenshot 2024-12-03 at 10 43 59\"\r\nsrc=\"https://github.com/user-attachments/assets/24fcebb9-2d31-4ca3-a0dc-4ed7861d26a2\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"3d46eadace572cbcfb95611224b819e2e67ed006"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202662","number":202662,"mergeCommit":{"message":"[Security Solution][Detection Engine] deprecates siem signals migration APIs (#202662)\n\n## Summary\r\n\r\n - addresses part of https://github.com/elastic/kibana/issues/195523\r\n- deprecates\r\nhttps://www.elastic.co/guide/en/security/current/signals-migration-api.html\r\nAPIs according to internal 9.x readiness\r\n[guideline](https://docs.google.com/document/d/1W7csjn6QYjrBjmbXMzSz_JUD4KcmWz8jTTtAWFwgUJM/edit?tab=t.0#heading=h.tui2zvb9gca6)\r\n \r\n#### How to test deprecated APIs?\r\n\r\n1. Run API\r\nhttps://www.elastic.co/guide/en/security/current/signals-migration-api.html\r\n2. Observe warning deprecation on Kibana Upgrade page\r\n\r\n<img width=\"2540\" alt=\"Screenshot 2024-12-03 at 10 43 59\"\r\nsrc=\"https://github.com/user-attachments/assets/24fcebb9-2d31-4ca3-a0dc-4ed7861d26a2\">\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"3d46eadace572cbcfb95611224b819e2e67ed006"}}]}] BACKPORT--> Co-authored-by: Vitalii Dmyterko <[email protected]>
…on APIs (elastic#202662) ## Summary - addresses part of elastic#195523 - deprecates https://www.elastic.co/guide/en/security/current/signals-migration-api.html APIs according to internal 9.x readiness [guideline](https://docs.google.com/document/d/1W7csjn6QYjrBjmbXMzSz_JUD4KcmWz8jTTtAWFwgUJM/edit?tab=t.0#heading=h.tui2zvb9gca6) #### How to test deprecated APIs? 1. Run API https://www.elastic.co/guide/en/security/current/signals-migration-api.html 2. Observe warning deprecation on Kibana Upgrade page <img width="2540" alt="Screenshot 2024-12-03 at 10 43 59" src="https://github.com/user-attachments/assets/24fcebb9-2d31-4ca3-a0dc-4ed7861d26a2"> --------- Co-authored-by: kibanamachine <[email protected]>
Summary
How to test deprecated APIs?