Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecuritySolution] Entity store status page - Add health status to transform #202523

Merged
merged 7 commits into from
Dec 18, 2024

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Dec 2, 2024

Summary

Add the actual transform status to the Entity Store status page.
Before, it just showed green whenever the transform was installed.

How to test it?

  • Install the Engine
  • Break the transform by updating it on the stack management page
  • The status change should be reflected in the engine status page

Screenshot 2024-12-16 at 11 05 30

@machadoum machadoum force-pushed the siem-ea-status-transform-health branch from 82847cf to 5b6e38e Compare December 13, 2024 14:43
@machadoum machadoum self-assigned this Dec 13, 2024
@machadoum machadoum added v9.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: entity_analytics Feature:Entity Analytics Security Solution Entity Analytics features Team:Entity Analytics Security Entity Analytics Team backport:version Backport to applied version labels v8.18.0 release_note:skip Skip the PR/issue when compiling release notes labels Dec 13, 2024
@machadoum machadoum marked this pull request as ready for review December 13, 2024 14:46
@machadoum machadoum requested a review from a team as a code owner December 13, 2024 14:46
@machadoum machadoum requested a review from CAWilson94 December 13, 2024 14:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

@machadoum machadoum changed the title Entity store status page - Add health status to transform [SecuritySolution] Entity store status page - Add health status to transform Dec 13, 2024
Copy link
Contributor

@tiansivive tiansivive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, havent desk tested

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #30 / Cloud Security Posture Findings Page onboarding Vulnerabilities - clicking on the No integrations installed prompt action button - install CNVM: navigates to the CNVM integration installation page

Metrics [docs]

✅ unchanged

History

cc @machadoum

Copy link
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, working great 🚀

@machadoum machadoum merged commit 1550c90 into elastic:main Dec 18, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12389056133

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 18, 2024
…ansform (elastic#202523)

## Summary

Add the actual transform status to the Entity Store status page.
Before, it just showed green whenever the transform was installed.

### How to test it?
* Install the Engine
* Break the transform by updating it on the stack management page
* The status change should be reflected in the engine status page

![Screenshot 2024-12-16 at 11 05
30](https://github.com/user-attachments/assets/a288a037-e1ea-4747-a2bb-266300dad946)

(cherry picked from commit 1550c90)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 18, 2024
… to transform (#202523) (#204692)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[SecuritySolution] Entity store status page - Add health status to
transform (#202523)](#202523)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Pablo
Machado","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-18T08:24:04Z","message":"[SecuritySolution]
Entity store status page - Add health status to transform
(#202523)\n\n## Summary\n\nAdd the actual transform status to the Entity
Store status page.\nBefore, it just showed green whenever the transform
was installed.\n\n### How to test it?\n* Install the Engine \n* Break
the transform by updating it on the stack management page\n* The status
change should be reflected in the engine status page\n\n\n![Screenshot
2024-12-16 at 11
05\n30](https://github.com/user-attachments/assets/a288a037-e1ea-4747-a2bb-266300dad946)","sha":"1550c90d3769ff27b0613b8004b9193a888c8236","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","Theme: entity_analytics","Feature:Entity
Analytics","Team:Entity
Analytics","backport:version","v8.18.0"],"title":"[SecuritySolution]
Entity store status page - Add health status to
transform","number":202523,"url":"https://github.com/elastic/kibana/pull/202523","mergeCommit":{"message":"[SecuritySolution]
Entity store status page - Add health status to transform
(#202523)\n\n## Summary\n\nAdd the actual transform status to the Entity
Store status page.\nBefore, it just showed green whenever the transform
was installed.\n\n### How to test it?\n* Install the Engine \n* Break
the transform by updating it on the stack management page\n* The status
change should be reflected in the engine status page\n\n\n![Screenshot
2024-12-16 at 11
05\n30](https://github.com/user-attachments/assets/a288a037-e1ea-4747-a2bb-266300dad946)","sha":"1550c90d3769ff27b0613b8004b9193a888c8236"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202523","number":202523,"mergeCommit":{"message":"[SecuritySolution]
Entity store status page - Add health status to transform
(#202523)\n\n## Summary\n\nAdd the actual transform status to the Entity
Store status page.\nBefore, it just showed green whenever the transform
was installed.\n\n### How to test it?\n* Install the Engine \n* Break
the transform by updating it on the stack management page\n* The status
change should be reflected in the engine status page\n\n\n![Screenshot
2024-12-16 at 11
05\n30](https://github.com/user-attachments/assets/a288a037-e1ea-4747-a2bb-266300dad946)","sha":"1550c90d3769ff27b0613b8004b9193a888c8236"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Pablo Machado <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
…ansform (elastic#202523)

## Summary

Add the actual transform status to the Entity Store status page.
Before, it just showed green whenever the transform was installed.

### How to test it?
* Install the Engine 
* Break the transform by updating it on the stack management page
* The status change should be reflected in the engine status page


![Screenshot 2024-12-16 at 11 05
30](https://github.com/user-attachments/assets/a288a037-e1ea-4747-a2bb-266300dad946)
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
…ansform (elastic#202523)

## Summary

Add the actual transform status to the Entity Store status page.
Before, it just showed green whenever the transform was installed.

### How to test it?
* Install the Engine 
* Break the transform by updating it on the stack management page
* The status change should be reflected in the engine status page


![Screenshot 2024-12-16 at 11 05
30](https://github.com/user-attachments/assets/a288a037-e1ea-4747-a2bb-266300dad946)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
…ansform (elastic#202523)

## Summary

Add the actual transform status to the Entity Store status page.
Before, it just showed green whenever the transform was installed.

### How to test it?
* Install the Engine 
* Break the transform by updating it on the stack management page
* The status change should be reflected in the engine status page


![Screenshot 2024-12-16 at 11 05
30](https://github.com/user-attachments/assets/a288a037-e1ea-4747-a2bb-266300dad946)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:Entity Analytics Security Solution Entity Analytics features release_note:skip Skip the PR/issue when compiling release notes Team:Entity Analytics Security Entity Analytics Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Theme: entity_analytics v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants