[Obs AI Assistant] It should be possible to clear the user-specific system prompt #202279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
sorenlouv
added
v7.17.0
release_note:fix
backport:prev-minor
viduni94
reviewed
Nov 29, 2024
...ssistant_management/public/routes/components/knowledge_base_edit_user_instruction_flyout.tsx
Show resolved
Hide resolved
sorenlouv
commented
Dec 2, 2024
| @@ -405,7 +405,7 @@ export class KnowledgeBaseService { | |||
| document: { | |||
| '@timestamp': new Date().toISOString(), | |||
| ...doc, | |||
| semantic_text: doc.text, | |||
| ...(doc.text ? { semantic_text: doc.text } : {}), | |||
There was a problem hiding this comment.
Empty semantic_text is not allowed so the field is removed when empty
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 7.17, 8.15, 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12120465072 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 2, 2024
…ystem prompt (elastic#202279) I noticed that I was not able to clear the user-specific system prompt. I had initially entered "Please speak in Swedish" and saved. Afterwards I wanted to clear this but the save button is disabled if the text content is empty.  (cherry picked from commit a63441d)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 2, 2024
…ystem prompt (elastic#202279) I noticed that I was not able to clear the user-specific system prompt. I had initially entered "Please speak in Swedish" and saved. Afterwards I wanted to clear this but the save button is disabled if the text content is empty.  (cherry picked from commit a63441d)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 2, 2024
…ific system prompt (#202279) (#202469) # Backport This will backport the following commits from `main` to `8.x`: - [[Obs AI Assistant] It should be possible to clear the user-specific system prompt (#202279)](#202279) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T13:33:59Z","message":"[Obs AI Assistant] It should be possible to clear the user-specific system prompt (#202279)\n\nI noticed that I was not able to clear the user-specific system prompt.\r\nI had initially entered \"Please speak in Swedish\" and saved. Afterwards\r\nI wanted to clear this but the save button is disabled if the text\r\ncontent is empty.\r\n\r\n","sha":"a63441d461d32130c25c6d21d2b42c18eb2f14b5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","v7.17.0","backport:prev-minor","Team:Obs AI Assistant","ci:project-deploy-observability"],"title":"[Obs AI Assistant] It should be possible to clear the user-specific system prompt","number":202279,"url":"https://github.com/elastic/kibana/pull/202279","mergeCommit":{"message":"[Obs AI Assistant] It should be possible to clear the user-specific system prompt (#202279)\n\nI noticed that I was not able to clear the user-specific system prompt.\r\nI had initially entered \"Please speak in Swedish\" and saved. Afterwards\r\nI wanted to clear this but the save button is disabled if the text\r\ncontent is empty.\r\n\r\n","sha":"a63441d461d32130c25c6d21d2b42c18eb2f14b5"}},"sourceBranch":"main","suggestedTargetBranches":["7.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202279","number":202279,"mergeCommit":{"message":"[Obs AI Assistant] It should be possible to clear the user-specific system prompt (#202279)\n\nI noticed that I was not able to clear the user-specific system prompt.\r\nI had initially entered \"Please speak in Swedish\" and saved. Afterwards\r\nI wanted to clear this but the save button is disabled if the text\r\ncontent is empty.\r\n\r\n","sha":"a63441d461d32130c25c6d21d2b42c18eb2f14b5"}},{"branch":"7.17","label":"v7.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Søren Louv-Jansen <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Dec 2, 2024
…cific system prompt (#202279) (#202468) # Backport This will backport the following commits from `main` to `8.17`: - [[Obs AI Assistant] It should be possible to clear the user-specific system prompt (#202279)](#202279) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T13:33:59Z","message":"[Obs AI Assistant] It should be possible to clear the user-specific system prompt (#202279)\n\nI noticed that I was not able to clear the user-specific system prompt.\r\nI had initially entered \"Please speak in Swedish\" and saved. Afterwards\r\nI wanted to clear this but the save button is disabled if the text\r\ncontent is empty.\r\n\r\n","sha":"a63441d461d32130c25c6d21d2b42c18eb2f14b5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","v7.17.0","backport:prev-minor","Team:Obs AI Assistant","ci:project-deploy-observability"],"title":"[Obs AI Assistant] It should be possible to clear the user-specific system prompt","number":202279,"url":"https://github.com/elastic/kibana/pull/202279","mergeCommit":{"message":"[Obs AI Assistant] It should be possible to clear the user-specific system prompt (#202279)\n\nI noticed that I was not able to clear the user-specific system prompt.\r\nI had initially entered \"Please speak in Swedish\" and saved. Afterwards\r\nI wanted to clear this but the save button is disabled if the text\r\ncontent is empty.\r\n\r\n","sha":"a63441d461d32130c25c6d21d2b42c18eb2f14b5"}},"sourceBranch":"main","suggestedTargetBranches":["7.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202279","number":202279,"mergeCommit":{"message":"[Obs AI Assistant] It should be possible to clear the user-specific system prompt (#202279)\n\nI noticed that I was not able to clear the user-specific system prompt.\r\nI had initially entered \"Please speak in Swedish\" and saved. Afterwards\r\nI wanted to clear this but the save button is disabled if the text\r\ncontent is empty.\r\n\r\n","sha":"a63441d461d32130c25c6d21d2b42c18eb2f14b5"}},{"branch":"7.17","label":"v7.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Søren Louv-Jansen <[email protected]>
sorenlouv
removed
the
backport:prev-minor
sorenlouv
added
the
backport:prev-minor
|
Starting backport for target branches: 7.17, 8.15, 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12137259528 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
sorenlouv
added
v8.17.0
backport:prev-minor
|
Starting backport for target branches: 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12137819295 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
…ystem prompt (elastic#202279) I noticed that I was not able to clear the user-specific system prompt. I had initially entered "Please speak in Swedish" and saved. Afterwards I wanted to clear this but the save button is disabled if the text content is empty. 
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…ystem prompt (elastic#202279) I noticed that I was not able to clear the user-specific system prompt. I had initially entered "Please speak in Swedish" and saved. Afterwards I wanted to clear this but the save button is disabled if the text content is empty. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that I was not able to clear the user-specific system prompt. I had initially entered "Please speak in Swedish" and saved. Afterwards I wanted to clear this but the save button is disabled if the text content is empty.