Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES3] Enable AI assistant knowledge base #202210

Merged
merged 3 commits into from
Nov 30, 2024
Merged

[ES3] Enable AI assistant knowledge base #202210

merged 3 commits into from
Nov 30, 2024

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Nov 28, 2024 •
edited by kibanamachine
Loading

Summary

This enables the knowledge base for the Serverless Search AI assistant. It also renames a few options to align naming, including a rename for the settings page in Observability's Serverless deployment to remove a reference to Search.

@sphilipse sphilipse requested review from a team as code owners November 28, 2024 16:35
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 v8.17.0 v8.18.0 labels Nov 28, 2024
Samiul-TheSoccerFan
Samiul-TheSoccerFan approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samiul-TheSoccerFan Samiul-TheSoccerFan added the backport:version Backport to applied version labels label Nov 28, 2024
jloleysens
jloleysens approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except we only deployed/tested an observability project based on the current labels (ci:project-deploy-observability) but the config changed for search projects, mind if we test against a search project before merging too?

@sphilipse sphilipse added the ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project label Nov 29, 2024
@sphilipse sphilipse enabled auto-merge (squash) November 29, 2024 19:17
@sphilipse sphilipse disabled auto-merge November 29, 2024 19:17
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 29, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchAssistant 4.7KB 4.8KB +104.0B
serverlessObservability 29.1KB 29.0KB -29.0B
serverlessSearch 22.2KB 22.7KB +495.0B
total +570.0B

History

@sphilipse sphilipse merged commit 0854996 into elastic:main Nov 30, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12096926587

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 30, 2024
@sphilipse
[ES3] Enable AI assistant knowledge base (elastic#202210)
20c720a 
## Summary

This enables the knowledge base for the Serverless Search AI assistant.
It also renames a few options to align naming, including a rename for
the settings page in Observability's Serverless deployment to remove a
reference to Search.

(cherry picked from commit 0854996)
@kibanamachine kibanamachine mentioned this pull request Nov 30, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 30, 2024
@sphilipse
[ES3] Enable AI assistant knowledge base (elastic#202210)
de4b3ab 
## Summary

This enables the knowledge base for the Serverless Search AI assistant.
It also renames a few options to align naming, including a rename for
the settings page in Observability's Serverless deployment to remove a
reference to Search.

(cherry picked from commit 0854996)
@kibanamachine kibanamachine mentioned this pull request Nov 30, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.17
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 30, 2024
@kibanamachine @sphilipse
[8.17] [ES3] Enable AI assistant knowledge base (#202210) (#202387)
5fbc576 
# Backport

This will backport the following commits from `main` to `8.17`:
- [[ES3] Enable AI assistant knowledge base
(#202210)](#202210)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-30T13:52:39Z","message":"[ES3]
Enable AI assistant knowledge base (#202210)\n\n## Summary\r\n\r\nThis
enables the knowledge base for the Serverless Search AI assistant.\r\nIt
also renames a few options to align naming, including a rename
for\r\nthe settings page in Observability's Serverless deployment to
remove a\r\nreference to
Search.","sha":"0854996ba19ed61786fc32b9403552ac564e2d85","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-elasticsearch","ci:project-deploy-observability","backport:version","v8.17.0","v8.18.0"],"title":"[ES3]
Enable AI assistant knowledge
base","number":202210,"url":"https://github.com/elastic/kibana/pull/202210","mergeCommit":{"message":"[ES3]
Enable AI assistant knowledge base (#202210)\n\n## Summary\r\n\r\nThis
enables the knowledge base for the Serverless Search AI assistant.\r\nIt
also renames a few options to align naming, including a rename
for\r\nthe settings page in Observability's Serverless deployment to
remove a\r\nreference to
Search.","sha":"0854996ba19ed61786fc32b9403552ac564e2d85"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202210","number":202210,"mergeCommit":{"message":"[ES3]
Enable AI assistant knowledge base (#202210)\n\n## Summary\r\n\r\nThis
enables the knowledge base for the Serverless Search AI assistant.\r\nIt
also renames a few options to align naming, including a rename
for\r\nthe settings page in Observability's Serverless deployment to
remove a\r\nreference to
Search.","sha":"0854996ba19ed61786fc32b9403552ac564e2d85"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 30, 2024
@kibanamachine @sphilipse
[8.x] [ES3] Enable AI assistant knowledge base (#202210) (#202388)
e3205a9 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES3] Enable AI assistant knowledge base
(#202210)](#202210)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-30T13:52:39Z","message":"[ES3]
Enable AI assistant knowledge base (#202210)\n\n## Summary\r\n\r\nThis
enables the knowledge base for the Serverless Search AI assistant.\r\nIt
also renames a few options to align naming, including a rename
for\r\nthe settings page in Observability's Serverless deployment to
remove a\r\nreference to
Search.","sha":"0854996ba19ed61786fc32b9403552ac564e2d85","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-elasticsearch","ci:project-deploy-observability","backport:version","v8.17.0","v8.18.0"],"title":"[ES3]
Enable AI assistant knowledge
base","number":202210,"url":"https://github.com/elastic/kibana/pull/202210","mergeCommit":{"message":"[ES3]
Enable AI assistant knowledge base (#202210)\n\n## Summary\r\n\r\nThis
enables the knowledge base for the Serverless Search AI assistant.\r\nIt
also renames a few options to align naming, including a rename
for\r\nthe settings page in Observability's Serverless deployment to
remove a\r\nreference to
Search.","sha":"0854996ba19ed61786fc32b9403552ac564e2d85"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202210","number":202210,"mergeCommit":{"message":"[ES3]
Enable AI assistant knowledge base (#202210)\n\n## Summary\r\n\r\nThis
enables the knowledge base for the Serverless Search AI assistant.\r\nIt
also renames a few options to align naming, including a rename
for\r\nthe settings page in Observability's Serverless deployment to
remove a\r\nreference to
Search.","sha":"0854996ba19ed61786fc32b9403552ac564e2d85"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@sphilipse @CAWilson94
[ES3] Enable AI assistant knowledge base (elastic#202210)
af7a9e3 
## Summary

This enables the knowledge base for the Serverless Search AI assistant.
It also renames a few options to align naming, including a rename for
the settings page in Observability's Serverless deployment to remove a
reference to Search.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@sphilipse @CAWilson94
[ES3] Enable AI assistant knowledge base (elastic#202210)
7bdfdf3 
## Summary

This enables the knowledge base for the Serverless Search AI assistant.
It also renames a few options to align naming, including a rename for
the settings page in Observability's Serverless deployment to remove a
reference to Search.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samiul-TheSoccerFan Samiul-TheSoccerFan Samiul-TheSoccerFan approved these changes

@jloleysens jloleysens jloleysens approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@SiddharthMantri SiddharthMantri SiddharthMantri approved these changes

@kdelemme kdelemme kdelemme approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sphilipse @elasticmachine @kibanamachine @kdelemme @SiddharthMantri @pgayvallet @jloleysens @Samiul-TheSoccerFan