-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix list item refresh issue #202194
Fix list item refresh issue #202194
Conversation
/ci |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I had a few nits about copy/naming, but the implementation here is sound.
Co-authored-by: Ryland Herrick <[email protected]>
Co-authored-by: Ryland Herrick <[email protected]>
@elasticmachine merge upstream |
@elasticmachine merge upstream |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12258869673 |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
## Fix refresh issue for serverless If use only have `write` and `read` privileges `refresh=true` don't work, because it require at least `maintenance` For creation it's easy to change to `wait_for` and it will work. For delete endpoint I implement the same technique as is used in deleting lists. --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Ryland Herrick <[email protected]> (cherry picked from commit 36a36b4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [Fix list item refresh issue (#202194)](#202194) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Khristinin Nikita","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T15:02:19Z","message":"Fix list item refresh issue (#202194)\n\n## Fix refresh issue for serverless\r\n\r\nIf use only have `write` and `read` privileges `refresh=true` don't\r\nwork, because it require at least `maintenance`\r\n\r\nFor creation it's easy to change to `wait_for` and it will work.\r\n\r\nFor delete endpoint I implement the same technique as is used in\r\ndeleting lists.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Ryland Herrick <[email protected]>","sha":"36a36b44e03f3023ddc51459c8d5ed67ffb4dab9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"Fix list item refresh issue","number":202194,"url":"https://github.com/elastic/kibana/pull/202194","mergeCommit":{"message":"Fix list item refresh issue (#202194)\n\n## Fix refresh issue for serverless\r\n\r\nIf use only have `write` and `read` privileges `refresh=true` don't\r\nwork, because it require at least `maintenance`\r\n\r\nFor creation it's easy to change to `wait_for` and it will work.\r\n\r\nFor delete endpoint I implement the same technique as is used in\r\ndeleting lists.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Ryland Herrick <[email protected]>","sha":"36a36b44e03f3023ddc51459c8d5ed67ffb4dab9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202194","number":202194,"mergeCommit":{"message":"Fix list item refresh issue (#202194)\n\n## Fix refresh issue for serverless\r\n\r\nIf use only have `write` and `read` privileges `refresh=true` don't\r\nwork, because it require at least `maintenance`\r\n\r\nFor creation it's easy to change to `wait_for` and it will work.\r\n\r\nFor delete endpoint I implement the same technique as is used in\r\ndeleting lists.\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Ryland Herrick <[email protected]>","sha":"36a36b44e03f3023ddc51459c8d5ed67ffb4dab9"}}]}] BACKPORT--> Co-authored-by: Khristinin Nikita <[email protected]>
## Fix refresh issue for serverless If use only have `write` and `read` privileges `refresh=true` don't work, because it require at least `maintenance` For creation it's easy to change to `wait_for` and it will work. For delete endpoint I implement the same technique as is used in deleting lists. --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Ryland Herrick <[email protected]>
Fix refresh issue for serverless
If use only have
write
andread
privilegesrefresh=true
don't work, because it require at leastmaintenance
For creation it's easy to change to
wait_for
and it will work.For delete endpoint I implement the same technique as is used in deleting lists.