Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list item refresh issue #202194

Merged
merged 8 commits into from
Dec 10, 2024
Merged

Conversation

nkhristinin
Copy link
Contributor

@nkhristinin nkhristinin commented Nov 28, 2024

Fix refresh issue for serverless

If use only have write and read privileges refresh=true don't work, because it require at least maintenance

For creation it's easy to change to wait_for and it will work.

For delete endpoint I implement the same technique as is used in deleting lists.

@nkhristinin
Copy link
Contributor Author

/ci

@nkhristinin nkhristinin marked this pull request as ready for review December 2, 2024 14:47
@nkhristinin nkhristinin requested a review from a team as a code owner December 2, 2024 14:47
@nkhristinin nkhristinin requested a review from rylnd December 2, 2024 14:47
@nkhristinin nkhristinin added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 2, 2024
@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I had a few nits about copy/naming, but the implementation here is sound.

@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin nkhristinin enabled auto-merge (squash) December 9, 2024 15:03
@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

@nkhristinin nkhristinin merged commit 36a36b4 into elastic:main Dec 10, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12258869673

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #110 / Rules Management - Prebuilt Rules - Prebuilt Rules Management @ess @serverless @skipInServerlessMKI Bootstrap Prebuilt Rules should install fleet packages required for detection engine to function

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 14.7MB 14.7MB -11.0B

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
## Fix refresh issue for serverless

If use only have `write` and `read` privileges `refresh=true` don't
work, because it require at least `maintenance`

For creation it's easy to change to `wait_for` and it will work.

For delete endpoint I implement the same technique as is used in
deleting lists.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Ryland Herrick <[email protected]>
(cherry picked from commit 36a36b4)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 10, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [Fix list item refresh issue
(#202194)](#202194)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T15:02:19Z","message":"Fix
list item refresh issue (#202194)\n\n## Fix refresh issue for
serverless\r\n\r\nIf use only have `write` and `read` privileges
`refresh=true` don't\r\nwork, because it require at least
`maintenance`\r\n\r\nFor creation it's easy to change to `wait_for` and
it will work.\r\n\r\nFor delete endpoint I implement the same technique
as is used in\r\ndeleting lists.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Ryland
Herrick
<[email protected]>","sha":"36a36b44e03f3023ddc51459c8d5ed67ffb4dab9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"Fix
list item refresh
issue","number":202194,"url":"https://github.com/elastic/kibana/pull/202194","mergeCommit":{"message":"Fix
list item refresh issue (#202194)\n\n## Fix refresh issue for
serverless\r\n\r\nIf use only have `write` and `read` privileges
`refresh=true` don't\r\nwork, because it require at least
`maintenance`\r\n\r\nFor creation it's easy to change to `wait_for` and
it will work.\r\n\r\nFor delete endpoint I implement the same technique
as is used in\r\ndeleting lists.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Ryland
Herrick
<[email protected]>","sha":"36a36b44e03f3023ddc51459c8d5ed67ffb4dab9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202194","number":202194,"mergeCommit":{"message":"Fix
list item refresh issue (#202194)\n\n## Fix refresh issue for
serverless\r\n\r\nIf use only have `write` and `read` privileges
`refresh=true` don't\r\nwork, because it require at least
`maintenance`\r\n\r\nFor creation it's easy to change to `wait_for` and
it will work.\r\n\r\nFor delete endpoint I implement the same technique
as is used in\r\ndeleting lists.\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>\r\nCo-authored-by: Ryland
Herrick
<[email protected]>","sha":"36a36b44e03f3023ddc51459c8d5ed67ffb4dab9"}}]}]
BACKPORT-->

Co-authored-by: Khristinin Nikita <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Fix refresh issue for serverless

If use only have `write` and `read` privileges `refresh=true` don't
work, because it require at least `maintenance`

For creation it's easy to change to `wait_for` and it will work.

For delete endpoint I implement the same technique as is used in
deleting lists.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Ryland Herrick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants