[Discover] Unskip _sidebar tests for MKI testing

[kertal]

Summary

Resolves #195100

I tried to reproduce the flakiness on MKI, but it wasn't flaky in my tests. I've refactored the code, so a debugger would stop the execution in case the test would fail, I've tested it with a simple bash script with a for loop executing the test runner, but it didn't fail. So let's unskip this test for MKI and see how it goes.

I do agree with @jughosta

Looks very much like https://github.com/elastic/kibana-team/issues/928 where for some reason ES reports fields as Empty during some period of time but hard to reproduce.

In our 1:1 @jughosta mentioned, that she observered the same behavior in https://github.com/elastic/kibana-team/issues/928, but after a while she couldn't reproduce (the request for available fields returns just meta fields in this case, flagging all fields as unavailable). It look me a quite a while to setup all this, so I haven't had the chance to test it on a fresh instance. I've added code that in and error case the query is resubmitted. However it would be still of interest, what could lead to the failure, which is high likely the field_caps request returning no available fields.

Local testing

That's the commit that I used to open the functional test runner with Chrome Dev Tools automatically open (So I didn't have to do it manually): 586c5a1

And a local shell script flaky test runner, I've used like this

for i in {1..25}; do
  echo "Flaky Bash Runner iteration: $i"
  TEST_CLOUD_HOST_NAME={qaCloudURL} \
  TEST_CLOUD=1 \
  NODE_TLS_REJECT_UNAUTHORIZED=0 \
  TEST_ES_URL="{qaEsInstanceURL}" \
  TEST_KIBANA_URL="{qaKibanaInstanceURL}" \
  node --no-warnings scripts/functional_test_runner \
    --quiet \
    --config x-pack/test_serverless/functional/test_suites/security/common_configs/config.group6.ts
done

Executed in a VSCode JavaScript Debug Terminal, this will stop the test execution on adebugger statement in the code

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[kertal]

/ci

[kibanamachine]

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7532

[✅] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group6.ts: 50/50 tests passed.
[✅] test/functional/apps/discover/group6/config.ts: 25/25 tests passed.

see run history

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[kertal]

that's the code that should help to catch an occacional flakiness, resubmitting the query, so available fields should be returned like expected

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: b4b1473

Metrics [docs]

✅ unchanged

History

• 💔 Build #255872 failed bd9d609
• 💚 Build #255586 succeeded 97e2fe1
• 💚 Build #255284 succeeded 912da81

cc @kertal

[davismcphee]

The code changes look good to me, and this seems like a tricky issue that's difficult to troubleshoot from the consumer side. Do we know if ES teams are aware of the issue? I didn't go through the process of trying to reproduce myself, but I'm not sure what else we could do on our end other than retry the requests.

[kertal]

The code changes look good to me, and this seems like a tricky issue that's difficult to troubleshoot from the consumer side. Do we know if ES teams are aware of the issue? I didn't go through the process of trying to reproduce myself, but I'm not sure what else we could do on our end other than retry the requests.

We raised this back in the days, however they also could not reproduce https://github.com/elastic/kibana-team/issues/928#issuecomment-2172843868 ... let's keep an eye open for this

[kibanamachine]

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12133432347

[kibanamachine]

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 202133

Questions ?

Please refer to the Backport tool documentation

[kertal]

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.