Fix Code Scanning Alert #1292 #202125
Merged
Fix Code Scanning Alert #1292 #202125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
release_note:skip
afharo
commented
Nov 28, 2024
| @@ -117,10 +117,12 @@ describe('assignToPaths', () => { | |||
| assignToPaths(paths, '/foo', {}); | |||
| assignToPaths(paths, '/bar/{id?}', {}); | |||
There was a problem hiding this comment.
I actually wonder if this type of path should translate into 2: /bar and /bar/{id}. But that's unrelated to this PR.
There was a problem hiding this comment.
++ it should, thanks for adding that check
💚 Build Succeeded
Metrics [docs]
cc @afharo |
jloleysens
approved these changes
Nov 29, 2024
| @@ -117,10 +117,12 @@ describe('assignToPaths', () => { | |||
| assignToPaths(paths, '/foo', {}); | |||
| assignToPaths(paths, '/bar/{id?}', {}); | |||
There was a problem hiding this comment.
++ it should, thanks for adding that check
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12084865691 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 29, 2024
## Summary Resolves [elastic#1292](elastic/kibana-team#1292) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 841d052)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 29, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Fix Code Scanning Alert #1292 (#202125)](#202125) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-29T12:35:49Z","message":"Fix Code Scanning Alert #1292 (#202125)\n\n## Summary\n\nResolves [#1292](https://github.com/elastic/kibana-team/issues/1292)\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"841d052776e5e9e703ce69f0161bc21e49446792","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"Fix Code Scanning Alert #1292","number":202125,"url":"https://github.com/elastic/kibana/pull/202125","mergeCommit":{"message":"Fix Code Scanning Alert #1292 (#202125)\n\n## Summary\n\nResolves [#1292](https://github.com/elastic/kibana-team/issues/1292)\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"841d052776e5e9e703ce69f0161bc21e49446792"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202125","number":202125,"mergeCommit":{"message":"Fix Code Scanning Alert #1292 (#202125)\n\n## Summary\n\nResolves [#1292](https://github.com/elastic/kibana-team/issues/1292)\n\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios","sha":"841d052776e5e9e703ce69f0161bc21e49446792"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Resolves [elastic#1292](elastic/kibana-team#1292) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1292
Checklist