Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade rxjs: 6.1.0 ---> 6.2.1. #20209

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Upgrade rxjs: 6.1.0 ---> 6.2.1. #20209

merged 1 commit into from
Jun 25, 2018

Conversation

azasypkin
Copy link
Member

@azasypkin azasypkin added review chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v6.4.0 labels Jun 25, 2018
@azasypkin azasypkin requested review from timroes and spalger June 25, 2018 16:02
timroes
timroes approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the CHANGELOG, none of the changes look dangerous for my knowledge about our usage of RxJS, haven't checked out or tested, since there is no specific place to test. If tests pass, LGTM

timroes
timroes approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the CHANGELOG, none of the changes look dangerous for my knowledge about our usage of RxJS, haven't checked out or tested, since there is no specific place to test. If tests pass, LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@azasypkin
Copy link
Member Author

Thanks for review! I've tested locally and haven't noticed anything suspicious so far and change list looks relatively safe as well, so let's see.

@azasypkin azasypkin merged commit 1803798 into elastic:master Jun 25, 2018
@azasypkin azasypkin deleted the issue-xxx-upgrade-rxjs branch June 25, 2018 18:04
azasypkin added a commit to azasypkin/kibana that referenced this pull request Jun 25, 2018
@azasypkin
Upgrade rxjs: 6.1.0 ---> 6.2.1. (elastic#20209)
4012615
@azasypkin azasypkin mentioned this pull request Jun 25, 2018
Merged
@azasypkin
Copy link
Member Author

6.x/6.4: 99f157b

mattapperson pushed a commit that referenced this pull request Jun 28, 2018
@azasypkin @mattapperson
Upgrade rxjs: 6.1.0 ---> 6.2.1. (#20209)
7433fa0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timroes timroes timroes approved these changes

@spalger spalger Awaiting requested review from spalger

Assignees
No one assigned
Labels
backported chore review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.4.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azasypkin @elasticmachine @timroes