[8.x] Allow data Streams enrich policies (#200903) #202055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes [elastic#187438](elastic#187438) ## Summary This PR introduces the data streams as source indices in the enrich policies. For that, it uses the groups functionality, so the indices are separated from the data streams. https://github.com/user-attachments/assets/1716d57b-b8c7-417a-b75c-33378f3269ca ### Strings I've changed some of the existing strings but left other as they were. I'll be happy to also change those if folks feel that should be the case. I've added a hint text and changed the label for the box in the creation step (marked in yellow) <img width="400" alt="Screenshot 2024-11-20 at 12 35 32" src="https://github.com/user-attachments/assets/794a7063-3f75-4f3d-996c-12ca8b9ed9b6"> I haven't change the label for the indices group (green) and I've followed the same structure for the new group category (yellow) <table> <tr> <td style="padding-right: 10px;"> <img alt="Screenshot 2024-11-20 at 12 37 51" src="https://github.com/user-attachments/assets/89a554a6-57e4-4208-bde4-d4868dec11bc"> </td> <td> <img alt="Screenshot 2024-11-20 at 12 38 16" src="https://github.com/user-attachments/assets/d82c7ae3-79c9-432e-aa3c-8ca02502e18f"> </td> </tr> </table> I haven't change the 'Source indices' text in the Summary (green) because in the request tab the correspondan field in the request is indices (blue) <table> <tr> <td style="padding-right: 10px;"> <img alt="Screenshot 2024-11-20 at 12 38 53" src="https://github.com/user-attachments/assets/80623ded-11e3-4661-9fa8-ad84182a72a3"> </td> <td> <img alt="Screenshot 2024-11-20 at 12 39 19" src="https://github.com/user-attachments/assets/f2ad6449-1a3a-448a-8598-c8c9eb41a717"> </td> </tr> </table> I also haven't change the 'Source indices' text in the table or in the detail flyout (green) since both indices and data streams are treated like indices. <table> <tr> <td style="padding-right: 10px;"> <img width="898" alt="Screenshot 2024-11-20 at 12 39 52" src="https://github.com/user-attachments/assets/8165fe3f-0286-4ad1-a40d-44e19e4eef29"> </td> <td> <img width="892" alt="Screenshot 2024-11-20 at 12 40 25" src="https://github.com/user-attachments/assets/bb046aa4-2a6c-40e0-bb32-ecb4a13adea9"> </td> </tr> </table> ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 8629b1d)
7 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Async chunks
cc @SoniaSanzV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation