Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize references to folders owned by CSP team in CODEOWNERS file #202036

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

albertoblaz
Copy link
Contributor

@albertoblaz albertoblaz commented Nov 27, 2024

Summary

Reorganize references to folders owned by the CSP team in CODEOWNERS file.

Details

  • Removed duplicated reference to x-pack/plugins/security_solution/public/cloud_security_posture folder
  • Removed redundant references to basic.ts and essentials.ts in x-pack/test_serverless/functional/test_suites/security/config.cloud_security_posture folder when whole of it is owned
  • Removed redundant references to common, graph and public folders in CSP package when whole package is owned (and missed an explicit reference to the storybook subfolder too)
  • Grouped and sorted references to all folders owned by our team to avoid spreading them and to have them in a single part of the file CI autogenerates part of the file, so I could only group and sort some references

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@albertoblaz albertoblaz added release_note:skip Skip the PR/issue when compiling release notes code coverage Issues & PRs about code coverage Team:Cloud Security Cloud Security team related labels Nov 27, 2024
@albertoblaz albertoblaz requested a review from a team November 27, 2024 16:48
@albertoblaz albertoblaz self-assigned this Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@albertoblaz albertoblaz added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Nov 27, 2024
@albertoblaz albertoblaz enabled auto-merge (squash) November 27, 2024 17:32
@albertoblaz albertoblaz merged commit e3027cf into elastic:main Nov 27, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12056443797

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @albertoblaz

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Streams] App plugin (#200060)
- [eem] _search endpoint / initial entity manager UI (#199609)

Manual backport

To create the backport manually run:

node scripts/backport --pr 202036

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 28, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202036 locally

@opauloh
Copy link
Contributor

opauloh commented Nov 28, 2024

Friendly reminder: Looks like this PR hasn’t been backported yet. To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label. You can also create backports manually by running node scripts/backport --pr 202036 locally

@albertoblaz I think we can skip backporting the codeowners file as codeowners it's only used in the main branch

Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for organizing it!

@opauloh opauloh removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 28, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 28, 2024
@opauloh
Copy link
Contributor

opauloh commented Nov 28, 2024

I removed the backport labels

@albertoblaz albertoblaz deleted the polish-codeowners branch November 29, 2024 08:23
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…le (elastic#202036)

## Summary

Reorganize references to folders owned by the CSP team in `CODEOWNERS`
file.

### Details

- Removed duplicated reference to
`x-pack/plugins/security_solution/public/cloud_security_posture` folder
- Removed redundant references to `basic.ts` and `essentials.ts` in
`x-pack/test_serverless/functional/test_suites/security/config.cloud_security_posture`
folder when whole of it is owned
- ~~Removed redundant references to `common`, `graph` and `public`
folders in CSP package when whole package is owned (and missed an
explicit reference to the `storybook` subfolder too)~~
- ~~Grouped and sorted references to all folders owned by our team to
avoid spreading them and to have them in a single part of the file~~ CI
autogenerates part of the file, so I could only group and sort some
references

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting code coverage Issues & PRs about code coverage release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants