-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize references to folders owned by CSP team in CODEOWNERS
file
#202036
Conversation
- Entire folder is owned by kibana-cloud-security-posture
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12056443797 |
💚 Build Succeeded
Metrics [docs]
cc @albertoblaz |
💔 All backports failed
Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
@albertoblaz I think we can skip backporting the codeowners file as codeowners it's only used in the main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for organizing it!
I removed the backport labels |
…le (elastic#202036) ## Summary Reorganize references to folders owned by the CSP team in `CODEOWNERS` file. ### Details - Removed duplicated reference to `x-pack/plugins/security_solution/public/cloud_security_posture` folder - Removed redundant references to `basic.ts` and `essentials.ts` in `x-pack/test_serverless/functional/test_suites/security/config.cloud_security_posture` folder when whole of it is owned - ~~Removed redundant references to `common`, `graph` and `public` folders in CSP package when whole package is owned (and missed an explicit reference to the `storybook` subfolder too)~~ - ~~Grouped and sorted references to all folders owned by our team to avoid spreading them and to have them in a single part of the file~~ CI autogenerates part of the file, so I could only group and sort some references ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
Summary
Reorganize references to folders owned by the CSP team in
CODEOWNERS
file.Details
x-pack/plugins/security_solution/public/cloud_security_posture
folderbasic.ts
andessentials.ts
inx-pack/test_serverless/functional/test_suites/security/config.cloud_security_posture
folder when whole of it is ownedRemoved redundant references tocommon
,graph
andpublic
folders in CSP package when whole package is owned (and missed an explicit reference to thestorybook
subfolder too)Grouped and sorted references to all folders owned by our team to avoid spreading them and to have them in a single part of the fileCI autogenerates part of the file, so I could only group and sort some referencesChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*
label is applied per the guidelines