[Discover] Address the flaky histogram code #201809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jughosta
added
release_note:skip
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7492[❌] test/functional/apps/management/config.ts: 7/30 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7496[❌] test/functional/apps/management/config.ts: 1/25 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7497[❌] test/functional/apps/management/config.ts: 6/25 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#7505[❌] test/functional/apps/management/config.ts: 0/25 tests passed. |
jughosta
changed the title
💔 Build Failed
Failed CI StepsHistorycc @jughosta |
jughosta
added
v9.0.0
v8.16.0
backport:version
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7511[✅] test/functional/apps/management/config.ts: 100/100 tests passed. |
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
davismcphee
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Nice, thanks for addressing this so quickly!
I don't suppose this gets us closer to being able to revert #200687 since it causes UI flickering, does it? Just asking since I saw it was linked as a similar issue.
9 tasks
sabarasaba
approved these changes
Nov 28, 2024
|
@davismcphee the change of #186642 was already removed in #200687 |
kertal
reviewed
Nov 28, 2024
Comment on lines
+335
to
+337
| if (!dataView.isTimeBased() || !dataView.timeFieldName) { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
sometimes it's simple, this has to be celebrated ! 🥳
|
@davismcphee I think it's fixing the root cause. Checked it in 8.17 branch here #202070 |
|
Starting backport for target branches: 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12066202642 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 28, 2024
- Closes elastic#201744 - Similar to elastic#184600 ## Summary This PR fixes the issues with the transition from a data view without a time field to a data view with a time field. Previously reported error:  (cherry picked from commit f50b93c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 28, 2024
- Closes elastic#201744 - Similar to elastic#184600 ## Summary This PR fixes the issues with the transition from a data view without a time field to a data view with a time field. Previously reported error:  (cherry picked from commit f50b93c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 28, 2024
- Closes elastic#201744 - Similar to elastic#184600 ## Summary This PR fixes the issues with the transition from a data view without a time field to a data view with a time field. Previously reported error:  (cherry picked from commit f50b93c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 28, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Address the flaky histogram code (#201809)](#201809) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T09:35:29Z","message":"[Discover] Address the flaky histogram code (#201809)\n\n- Closes https://github.com/elastic/kibana/issues/201744\r\n- Similar to https://github.com/elastic/kibana/issues/184600\r\n\r\n## Summary\r\n\r\nThis PR fixes the issues with the transition from a data view without a\r\ntime field to a data view with a time field.\r\n\r\nPreviously reported error:\r\n","sha":"f50b93c29004f8dac0fc6d1b44e6a8497a0cf2ea","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[Discover] Address the flaky histogram code","number":201809,"url":"https://github.com/elastic/kibana/pull/201809","mergeCommit":{"message":"[Discover] Address the flaky histogram code (#201809)\n\n- Closes https://github.com/elastic/kibana/issues/201744\r\n- Similar to https://github.com/elastic/kibana/issues/184600\r\n\r\n## Summary\r\n\r\nThis PR fixes the issues with the transition from a data view without a\r\ntime field to a data view with a time field.\r\n\r\nPreviously reported error:\r\n","sha":"f50b93c29004f8dac0fc6d1b44e6a8497a0cf2ea"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201809","number":201809,"mergeCommit":{"message":"[Discover] Address the flaky histogram code (#201809)\n\n- Closes https://github.com/elastic/kibana/issues/201744\r\n- Similar to https://github.com/elastic/kibana/issues/184600\r\n\r\n## Summary\r\n\r\nThis PR fixes the issues with the transition from a data view without a\r\ntime field to a data view with a time field.\r\n\r\nPreviously reported error:\r\n","sha":"f50b93c29004f8dac0fc6d1b44e6a8497a0cf2ea"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <[email protected]>
jughosta
added a commit
that referenced
this pull request
Nov 28, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [[Discover] Address the flaky histogram code (#201809)](#201809) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T09:35:29Z","message":"[Discover] Address the flaky histogram code (#201809)\n\n- Closes https://github.com/elastic/kibana/issues/201744\r\n- Similar to https://github.com/elastic/kibana/issues/184600\r\n\r\n## Summary\r\n\r\nThis PR fixes the issues with the transition from a data view without a\r\ntime field to a data view with a time field.\r\n\r\nPreviously reported error:\r\n","sha":"f50b93c29004f8dac0fc6d1b44e6a8497a0cf2ea","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[Discover] Address the flaky histogram code","number":201809,"url":"https://github.com/elastic/kibana/pull/201809","mergeCommit":{"message":"[Discover] Address the flaky histogram code (#201809)\n\n- Closes https://github.com/elastic/kibana/issues/201744\r\n- Similar to https://github.com/elastic/kibana/issues/184600\r\n\r\n## Summary\r\n\r\nThis PR fixes the issues with the transition from a data view without a\r\ntime field to a data view with a time field.\r\n\r\nPreviously reported error:\r\n","sha":"f50b93c29004f8dac0fc6d1b44e6a8497a0cf2ea"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201809","number":201809,"mergeCommit":{"message":"[Discover] Address the flaky histogram code (#201809)\n\n- Closes https://github.com/elastic/kibana/issues/201744\r\n- Similar to https://github.com/elastic/kibana/issues/184600\r\n\r\n## Summary\r\n\r\nThis PR fixes the issues with the transition from a data view without a\r\ntime field to a data view with a time field.\r\n\r\nPreviously reported error:\r\n","sha":"f50b93c29004f8dac0fc6d1b44e6a8497a0cf2ea"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Julia Rechkunova <[email protected]>
jughosta
added a commit
that referenced
this pull request
Nov 28, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[Discover] Address the flaky histogram code (#201809)](#201809) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T09:35:29Z","message":"[Discover] Address the flaky histogram code (#201809)\n\n- Closes https://github.com/elastic/kibana/issues/201744\r\n- Similar to https://github.com/elastic/kibana/issues/184600\r\n\r\n## Summary\r\n\r\nThis PR fixes the issues with the transition from a data view without a\r\ntime field to a data view with a time field.\r\n\r\nPreviously reported error:\r\n","sha":"f50b93c29004f8dac0fc6d1b44e6a8497a0cf2ea","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[Discover] Address the flaky histogram code","number":201809,"url":"https://github.com/elastic/kibana/pull/201809","mergeCommit":{"message":"[Discover] Address the flaky histogram code (#201809)\n\n- Closes https://github.com/elastic/kibana/issues/201744\r\n- Similar to https://github.com/elastic/kibana/issues/184600\r\n\r\n## Summary\r\n\r\nThis PR fixes the issues with the transition from a data view without a\r\ntime field to a data view with a time field.\r\n\r\nPreviously reported error:\r\n","sha":"f50b93c29004f8dac0fc6d1b44e6a8497a0cf2ea"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201809","number":201809,"mergeCommit":{"message":"[Discover] Address the flaky histogram code (#201809)\n\n- Closes https://github.com/elastic/kibana/issues/201744\r\n- Similar to https://github.com/elastic/kibana/issues/184600\r\n\r\n## Summary\r\n\r\nThis PR fixes the issues with the transition from a data view without a\r\ntime field to a data view with a time field.\r\n\r\nPreviously reported error:\r\n","sha":"f50b93c29004f8dac0fc6d1b44e6a8497a0cf2ea"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Julia Rechkunova <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
- Closes elastic#201744 - Similar to elastic#184600 ## Summary This PR fixes the issues with the transition from a data view without a time field to a data view with a time field. Previously reported error: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the issues with the transition from a data view without a time field to a data view with a time field.
Previously reported error:
