Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Search:AppSearch:Engines:Curations page]Manage queries modal dialog missing title from announcement #201782

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix: [Search:AppSearch:Engines:Curations page]Manage queries modal dialog missing title from announcement #201782

merged 2 commits into from
Nov 27, 2024

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Nov 26, 2024 •
edited by kibanamachine
Loading

Closes: #201756

Description

Dialog modal visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened.

What was changed?:

  1. aria-labelledby={modalTitleId} attribute was added for mentioned EuiModal

Screen

Screenshot 2024-11-26 at 15 28 28

@alexwizp alexwizp added Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Search backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 26, 2024
@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp marked this pull request as ready for review November 26, 2024 15:44
@alexwizp alexwizp requested a review from a team as a code owner November 26, 2024 15:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #18 / Category can submit without setting a category

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB +128.0B

History

@alexwizp alexwizp merged commit 2a59bc2 into elastic:main Nov 27, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12049050457

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 27, 2024
@alexwizp
fix: [Search:AppSearch:Engines:Curations page]Manage queries modal di…
82e03ca 
…alog missing title from announcement (elastic#201782)

Closes: elastic#201756

## Description
Dialog modal visible title should be announced for the users, especially
using assistive technology to know what dialog modal, flyout opened.

## What was changed?:

1. aria-labelledby={modalTitleId} attribute was added for mentioned
EuiModal

## Screen

<img width="1330" alt="Screenshot 2024-11-26 at 15 28 28"
src="https://github.com/user-attachments/assets/760dda30-aed0-4f72-bae7-dab72f64a51e">

(cherry picked from commit 2a59bc2)
@kibanamachine kibanamachine mentioned this pull request Nov 27, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 27, 2024
@kibanamachine @alexwizp
[8.x] fix: [Search:AppSearch:Engines:Curations page]Manage queries mo…
cf8819b 
…dal dialog missing title from announcement (#201782) (#201944)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Search:AppSearch:Engines:Curations page]Manage queries modal
dialog missing title from announcement
(#201782)](#201782)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-27T11:08:29Z","message":"fix:
[Search:AppSearch:Engines:Curations page]Manage queries modal dialog
missing title from announcement (#201782)\n\nCloses: #201756\r\n\r\n##
Description\r\nDialog modal visible title should be announced for the
users, especially\r\nusing assistive technology to know what dialog
modal, flyout opened.\r\n\r\n## What was changed?:\r\n\r\n1.
aria-labelledby={modalTitleId} attribute was added for
mentioned\r\nEuiModal\r\n\r\n## Screen\r\n\r\n<img width=\"1330\"
alt=\"Screenshot 2024-11-26 at 15 28
28\"\r\nsrc=\"https://github.com/user-attachments/assets/760dda30-aed0-4f72-bae7-dab72f64a51e\">","sha":"2a59bc201e295468935e9679ed24c1e799f86d44","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix:
[Search:AppSearch:Engines:Curations page]Manage queries modal dialog
missing title from
announcement","number":201782,"url":"https://github.com/elastic/kibana/pull/201782","mergeCommit":{"message":"fix:
[Search:AppSearch:Engines:Curations page]Manage queries modal dialog
missing title from announcement (#201782)\n\nCloses: #201756\r\n\r\n##
Description\r\nDialog modal visible title should be announced for the
users, especially\r\nusing assistive technology to know what dialog
modal, flyout opened.\r\n\r\n## What was changed?:\r\n\r\n1.
aria-labelledby={modalTitleId} attribute was added for
mentioned\r\nEuiModal\r\n\r\n## Screen\r\n\r\n<img width=\"1330\"
alt=\"Screenshot 2024-11-26 at 15 28
28\"\r\nsrc=\"https://github.com/user-attachments/assets/760dda30-aed0-4f72-bae7-dab72f64a51e\">","sha":"2a59bc201e295468935e9679ed24c1e799f86d44"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201782","number":201782,"mergeCommit":{"message":"fix:
[Search:AppSearch:Engines:Curations page]Manage queries modal dialog
missing title from announcement (#201782)\n\nCloses: #201756\r\n\r\n##
Description\r\nDialog modal visible title should be announced for the
users, especially\r\nusing assistive technology to know what dialog
modal, flyout opened.\r\n\r\n## What was changed?:\r\n\r\n1.
aria-labelledby={modalTitleId} attribute was added for
mentioned\r\nEuiModal\r\n\r\n## Screen\r\n\r\n<img width=\"1330\"
alt=\"Screenshot 2024-11-26 at 15 28
28\"\r\nsrc=\"https://github.com/user-attachments/assets/760dda30-aed0-4f72-bae7-dab72f64a51e\">","sha":"2a59bc201e295468935e9679ed24c1e799f86d44"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sphilipse sphilipse sphilipse approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Search:AppSearch:Engines:Curations page]Manage queries modal dialog missing title from announcement
4 participants
@alexwizp @elasticmachine @kibanamachine @sphilipse