[Discover][UnifiedDataTable] Attempt to fix flaky jest test #201754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kertal
force-pushed
the
discover-attempt-to-fix-flaky-jest
branch
from
0e3d69a to
be757a4
Compare
|
/ci |
|
/ci |
|
/ci |
kertal
added
Feature:Discover
kertal
added
the
Team:DataDiscovery
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
PhilippeOberti
approved these changes
Nov 27, 2024
akowalska622
approved these changes
Nov 27, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12066908661 |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
cc @kertal |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 28, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Discover][UnifiedDataTable] Fix flaky jest test](#201754) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Matthias Wilhelm","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T10:19:07Z","message":"[Discover][UnifiedDataTable] Fix flaky jest test\n\nPreventing a flaky jest test by adding waitFor functionality","sha":"d3727a5342e54aaa79586921d0e1b12498c1c7be","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","Feature:UnifiedDataTable"],"title":"[Discover][UnifiedDataTable] Attempt to fix flaky jest test","number":201754,"url":"https://github.com/elastic/kibana/pull/201754","mergeCommit":{"message":"[Discover][UnifiedDataTable] Fix flaky jest test\n\nPreventing a flaky jest test by adding waitFor functionality","sha":"d3727a5342e54aaa79586921d0e1b12498c1c7be"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201754","number":201754,"mergeCommit":{"message":"[Discover][UnifiedDataTable] Fix flaky jest test\n\nPreventing a flaky jest test by adding waitFor functionality","sha":"d3727a5342e54aaa79586921d0e1b12498c1c7be"}}]}] BACKPORT--> Co-authored-by: Matthias Wilhelm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #187527
The jest test occasionally failed , and we don't have a good way to reproduce or run a flaky test runner, so this attempt is simple trying out an addtional
waitForto see if this could help.PS: I think the root cause could be lazy loading of an involved component, if someone has an idea how to debug this, pls let know 🙏
Checklist