Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge updates from dirty yarn.lock created by 'kbn bootstrap' #20169

Merged

Conversation

justinkambic
Copy link
Contributor

Motivation

The x-pack/yarn.lock file is changing to a dirty state on the latest master commits. The version updates/modifications are stored in the commit on this branch.

Testing this PR

Checkout this branch and run yarn kbn bootstrap from project root. You should have a clean git status when it's done.

@justinkambic justinkambic added bug Fixes for quality problems that affect the customer experience dev build v7.0.0 v6.4.0 labels Jun 22, 2018
@justinkambic justinkambic requested a review from bmcconaghy June 22, 2018 19:31
@justinkambic justinkambic changed the title Merge updates from dirty yarn.lock created by 'kbn bootstrap'. Merge updates from dirty yarn.lock created by 'kbn bootstrap' Jun 22, 2018
Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pulled this down and bootstrapped and no local changes.

Copy link

@rhoboat rhoboat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches my local lock file. ++

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@justinkambic
Copy link
Contributor Author

Backported to:
6.x/6.4.0 1f6e334

@justinkambic justinkambic deleted the bug-fix/update-yarn-lockfile branch June 22, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience build dev v6.4.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants