[Obx-ux-mgmt][Alerting]Mismatch between preview chart and rule execution regarding wildcards #201553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion regarding wildcards
fkanout
added
bug
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kdelemme
approved these changes
Nov 25, 2024
fkanout
added
backport:prev-minor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12027693010 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 26, 2024
…ion regarding wildcards (elastic#201553) ## Summary It fixes elastic#186624 by making the preview chat represent the wildcard correctly. The missing use case was when passing the query without " " |Tested cases|Note| |---|---| |<img width="596" alt="Screenshot 2024-11-25 at 12 04 14" src="https://github.com/user-attachments/assets/8140d175-9ff3-4d1a-ac72-baf1e7878326">|<img width="594" alt="Screenshot 2024-11-25 at 12 04 27" src="https://github.com/user-attachments/assets/cf0eeb97-0fe7-4509-b4db-c8e4b54e0def">We can't show "NoData" in this case. I tested the same formula in Lens and got the same results. It's not ideal, but at least we don't have any data/bars that could mislead the user| |<img width="596" alt="Screenshot 2024-11-25 at 11 59 53" src="https://github.com/user-attachments/assets/cc128bd7-f4aa-403a-8c0a-398b36694064">|| |<img width="596" alt="Screenshot 2024-11-25 at 11 59 41" src="https://github.com/user-attachments/assets/7f4ae425-6c3b-4067-ab45-0e8282ddd901">|| |<img width="596" alt="Screenshot 2024-11-25 at 11 59 28" src="https://github.com/user-attachments/assets/e2e6dfde-834a-4921-8471-a7270bbd2f9c">|| |<img width="596" alt="Screenshot 2024-11-25 at 11 59 08" src="https://github.com/user-attachments/assets/6ffc641d-b043-4740-897f-5d4e94adda41">|| |<img width="596" alt="Screenshot 2024-11-25 at 11 58 58" src="https://github.com/user-attachments/assets/5122e9df-b392-4785-8a2b-5219c818dfed">|| (cherry picked from commit f0c8fde)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 26, 2024
…execution regarding wildcards (#201553) (#201733) # Backport This will backport the following commits from `main` to `8.x`: - [[Obx-ux-mgmt][Alerting]Mismatch between preview chart and rule execution regarding wildcards (#201553)](#201553) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Faisal Kanout","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T09:33:55Z","message":"[Obx-ux-mgmt][Alerting]Mismatch between preview chart and rule execution regarding wildcards (#201553)\n\n## Summary\r\nIt fixes #186624 by making the preview chat represent the wildcard\r\ncorrectly. The missing use case was when passing the query without \" \"\r\n\r\n\r\n|Tested cases|Note|\r\n|---|---|\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 12 04 14\"\r\nsrc=\"https://github.com/user-attachments/assets/8140d175-9ff3-4d1a-ac72-baf1e7878326\">|<img\r\nwidth=\"594\" alt=\"Screenshot 2024-11-25 at 12 04 27\"\r\nsrc=\"https://github.com/user-attachments/assets/cf0eeb97-0fe7-4509-b4db-c8e4b54e0def\">We\r\ncan't show \"NoData\" in this case. I tested the same formula in Lens and\r\ngot the same results. It's not ideal, but at least we don't have any\r\ndata/bars that could mislead the user|\r\n\r\n\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 59 53\"\r\nsrc=\"https://github.com/user-attachments/assets/cc128bd7-f4aa-403a-8c0a-398b36694064\">||\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 59 41\"\r\nsrc=\"https://github.com/user-attachments/assets/7f4ae425-6c3b-4067-ab45-0e8282ddd901\">||\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 59 28\"\r\nsrc=\"https://github.com/user-attachments/assets/e2e6dfde-834a-4921-8471-a7270bbd2f9c\">||\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 59 08\"\r\nsrc=\"https://github.com/user-attachments/assets/6ffc641d-b043-4740-897f-5d4e94adda41\">||\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 58 58\"\r\nsrc=\"https://github.com/user-attachments/assets/5122e9df-b392-4785-8a2b-5219c818dfed\">||","sha":"f0c8fde12469a9d827a4f4cb8498f3210b400ce2","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Alerting","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.18.0"],"title":"[Obx-ux-mgmt][Alerting]Mismatch between preview chart and rule execution regarding wildcards","number":201553,"url":"https://github.com/elastic/kibana/pull/201553","mergeCommit":{"message":"[Obx-ux-mgmt][Alerting]Mismatch between preview chart and rule execution regarding wildcards (#201553)\n\n## Summary\r\nIt fixes #186624 by making the preview chat represent the wildcard\r\ncorrectly. The missing use case was when passing the query without \" \"\r\n\r\n\r\n|Tested cases|Note|\r\n|---|---|\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 12 04 14\"\r\nsrc=\"https://github.com/user-attachments/assets/8140d175-9ff3-4d1a-ac72-baf1e7878326\">|<img\r\nwidth=\"594\" alt=\"Screenshot 2024-11-25 at 12 04 27\"\r\nsrc=\"https://github.com/user-attachments/assets/cf0eeb97-0fe7-4509-b4db-c8e4b54e0def\">We\r\ncan't show \"NoData\" in this case. I tested the same formula in Lens and\r\ngot the same results. It's not ideal, but at least we don't have any\r\ndata/bars that could mislead the user|\r\n\r\n\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 59 53\"\r\nsrc=\"https://github.com/user-attachments/assets/cc128bd7-f4aa-403a-8c0a-398b36694064\">||\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 59 41\"\r\nsrc=\"https://github.com/user-attachments/assets/7f4ae425-6c3b-4067-ab45-0e8282ddd901\">||\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 59 28\"\r\nsrc=\"https://github.com/user-attachments/assets/e2e6dfde-834a-4921-8471-a7270bbd2f9c\">||\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 59 08\"\r\nsrc=\"https://github.com/user-attachments/assets/6ffc641d-b043-4740-897f-5d4e94adda41\">||\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 58 58\"\r\nsrc=\"https://github.com/user-attachments/assets/5122e9df-b392-4785-8a2b-5219c818dfed\">||","sha":"f0c8fde12469a9d827a4f4cb8498f3210b400ce2"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201553","number":201553,"mergeCommit":{"message":"[Obx-ux-mgmt][Alerting]Mismatch between preview chart and rule execution regarding wildcards (#201553)\n\n## Summary\r\nIt fixes #186624 by making the preview chat represent the wildcard\r\ncorrectly. The missing use case was when passing the query without \" \"\r\n\r\n\r\n|Tested cases|Note|\r\n|---|---|\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 12 04 14\"\r\nsrc=\"https://github.com/user-attachments/assets/8140d175-9ff3-4d1a-ac72-baf1e7878326\">|<img\r\nwidth=\"594\" alt=\"Screenshot 2024-11-25 at 12 04 27\"\r\nsrc=\"https://github.com/user-attachments/assets/cf0eeb97-0fe7-4509-b4db-c8e4b54e0def\">We\r\ncan't show \"NoData\" in this case. I tested the same formula in Lens and\r\ngot the same results. It's not ideal, but at least we don't have any\r\ndata/bars that could mislead the user|\r\n\r\n\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 59 53\"\r\nsrc=\"https://github.com/user-attachments/assets/cc128bd7-f4aa-403a-8c0a-398b36694064\">||\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 59 41\"\r\nsrc=\"https://github.com/user-attachments/assets/7f4ae425-6c3b-4067-ab45-0e8282ddd901\">||\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 59 28\"\r\nsrc=\"https://github.com/user-attachments/assets/e2e6dfde-834a-4921-8471-a7270bbd2f9c\">||\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 59 08\"\r\nsrc=\"https://github.com/user-attachments/assets/6ffc641d-b043-4740-897f-5d4e94adda41\">||\r\n|<img width=\"596\" alt=\"Screenshot 2024-11-25 at 11 58 58\"\r\nsrc=\"https://github.com/user-attachments/assets/5122e9df-b392-4785-8a2b-5219c818dfed\">||","sha":"f0c8fde12469a9d827a4f4cb8498f3210b400ce2"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Faisal Kanout <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…ion regarding wildcards (elastic#201553) ## Summary It fixes elastic#186624 by making the preview chat represent the wildcard correctly. The missing use case was when passing the query without " " |Tested cases|Note| |---|---| |<img width="596" alt="Screenshot 2024-11-25 at 12 04 14" src="https://github.com/user-attachments/assets/8140d175-9ff3-4d1a-ac72-baf1e7878326">|<img width="594" alt="Screenshot 2024-11-25 at 12 04 27" src="https://github.com/user-attachments/assets/cf0eeb97-0fe7-4509-b4db-c8e4b54e0def">We can't show "NoData" in this case. I tested the same formula in Lens and got the same results. It's not ideal, but at least we don't have any data/bars that could mislead the user| |<img width="596" alt="Screenshot 2024-11-25 at 11 59 53" src="https://github.com/user-attachments/assets/cc128bd7-f4aa-403a-8c0a-398b36694064">|| |<img width="596" alt="Screenshot 2024-11-25 at 11 59 41" src="https://github.com/user-attachments/assets/7f4ae425-6c3b-4067-ab45-0e8282ddd901">|| |<img width="596" alt="Screenshot 2024-11-25 at 11 59 28" src="https://github.com/user-attachments/assets/e2e6dfde-834a-4921-8471-a7270bbd2f9c">|| |<img width="596" alt="Screenshot 2024-11-25 at 11 59 08" src="https://github.com/user-attachments/assets/6ffc641d-b043-4740-897f-5d4e94adda41">|| |<img width="596" alt="Screenshot 2024-11-25 at 11 58 58" src="https://github.com/user-attachments/assets/5122e9df-b392-4785-8a2b-5219c818dfed">||
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…ion regarding wildcards (elastic#201553) ## Summary It fixes elastic#186624 by making the preview chat represent the wildcard correctly. The missing use case was when passing the query without " " |Tested cases|Note| |---|---| |<img width="596" alt="Screenshot 2024-11-25 at 12 04 14" src="https://github.com/user-attachments/assets/8140d175-9ff3-4d1a-ac72-baf1e7878326">|<img width="594" alt="Screenshot 2024-11-25 at 12 04 27" src="https://github.com/user-attachments/assets/cf0eeb97-0fe7-4509-b4db-c8e4b54e0def">We can't show "NoData" in this case. I tested the same formula in Lens and got the same results. It's not ideal, but at least we don't have any data/bars that could mislead the user| |<img width="596" alt="Screenshot 2024-11-25 at 11 59 53" src="https://github.com/user-attachments/assets/cc128bd7-f4aa-403a-8c0a-398b36694064">|| |<img width="596" alt="Screenshot 2024-11-25 at 11 59 41" src="https://github.com/user-attachments/assets/7f4ae425-6c3b-4067-ab45-0e8282ddd901">|| |<img width="596" alt="Screenshot 2024-11-25 at 11 59 28" src="https://github.com/user-attachments/assets/e2e6dfde-834a-4921-8471-a7270bbd2f9c">|| |<img width="596" alt="Screenshot 2024-11-25 at 11 59 08" src="https://github.com/user-attachments/assets/6ffc641d-b043-4740-897f-5d4e94adda41">|| |<img width="596" alt="Screenshot 2024-11-25 at 11 58 58" src="https://github.com/user-attachments/assets/5122e9df-b392-4785-8a2b-5219c818dfed">||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It fixes #186624 by making the preview chat represent the wildcard correctly. The missing use case was when passing the query without " "
|
||
||
||
||
||
|
|
|
|