[ES|QL] Supports custom formatters in charts #201540

ppisljar · 2024-11-25T10:32:50Z

Summary

adds labeling and formatting supports to esql charts

elasticmachine · 2024-11-26T09:44:22Z

Pinging @elastic/kibana-visualizations (Team:Visualizations)

elasticmachine · 2024-11-26T09:44:24Z

Pinging @elastic/kibana-esql (Team:ESQL)

kertal · 2024-11-28T09:44:45Z

src/plugins/data/common/search/expressions/esql.ts

@@ -315,7 +315,14 @@ export const getEsqlFn = ({ getStartDependencies }: EsqlFnArguments) => {
            (body.all_columns ?? body.columns)?.map(({ name, type }) => ({
              id: name,
              name,
-              meta: { type: esFieldTypeToKibanaFieldType(type), esType: type },
+              meta: {


Being not familiar with this are of the code, and Lukas being on PTO, I wonder, how can this be tested in the DataDiscovery world? thx

Go to discover, switch to esql mode and enter a query which contains | WHERE @timestamp >= ?_tstart AND @timestamp <= ?_tend | STATS ...., save this to a new dashboard
now change a query to add a new field, remove the auto added dimension, manually add a new dimension, or change an existing one ... the field list is empty on main, but contains correct fields on this branch

x-pack/plugins/lens/public/datasources/form_based/dimension_panel/format_selector.tsx

src/plugins/data/common/search/expressions/esql.ts

x-pack/plugins/lens/public/datasources/text_based/components/dimension_editor.tsx

markov00 · 2024-12-03T16:11:01Z

x-pack/plugins/lens/public/datasources/text_based/components/dimension_editor.tsx

+      {!isFullscreen && (
+        <div className="lnsIndexPatternDimensionEditor--padded lnsIndexPatternDimensionEditor--collapseNext">
+          {selectedField && (


nit: you can bring selectedField up to the initial condition and remove it from the rest of this code.

Suggested change

{!isFullscreen && (

<div className="lnsIndexPatternDimensionEditor--padded lnsIndexPatternDimensionEditor--collapseNext">

{selectedField && (

{!isFullscreen && selectedField && (

<div className="lnsIndexPatternDimensionEditor--padded lnsIndexPatternDimensionEditor--collapseNext">

x-pack/plugins/lens/public/datasources/text_based/to_expression.ts

markov00 · 2024-12-03T16:23:30Z

x-pack/plugins/lens/public/datasources/text_based/to_expression.ts

+    .filter((col) => col.params?.format)
+    .map((col) => {
+      // TODO: improve the type handling here
+      const format = col.params!.format!;


Suggested change

.filter((col) => col.params?.format)

.map((col) => {

// TODO: improve the type handling here

const format = col.params!.format!;

.filter((col): col is TextBasedLayerColumn & {params: {format: ValueFormatConfig}} => col.params?.format)

.map((col) => {

const format = col.params.format;

this doesnt seem to work
Type 'ValueFormatConfig | undefined' is not assignable to type 'boolean'.
Type 'undefined' is not assignable to type 'boolean'.

.filter((col): col is TextBasedLayerColumn & { params: { format: ValueFormatConfig } } => Boolean(col.params?.format) )

is this really better from what we currently have ?

This creates a type guard that is the way to fix col.params!.format!; in this place.
You can move the filter/typeguard function outside this code to make it a bit less verbose.

x-pack/plugins/lens/public/datasources/text_based/components/dimension_editor.tsx

…-fix'

cnasikas

ResponseOps LGTM!

stratoula

I havent tested yet but the change in fetchFieldsFromESQL seems to affect the editor

packages/kbn-esql-editor/src/fetch_fields_from_esql.ts

stratoula

This works great and is a nice addition, kudos Peter

I updated the labels as I think it should go to 8.18 and also be added on our release notes

markov00

I left a last minor change as comment, it will be nice if that can be fixed, otherwise we can revisit it later.

kertal

DataDiscovery Code LGTM, tested locally and works as expected. It's a nice enhancement 👍

…l/formatting

elasticmachine · 2024-12-10T19:51:32Z

💚 Build Succeeded

Buildkite Build
Commit: ca78ff8

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`discover`	784.9KB	784.9KB	+19.0B
`esql`	202.5KB	202.5KB	+35.0B
`lens`	1.5MB	1.5MB	+2.5KB
`stackAlerts`	73.5KB	73.5KB	-48.0B
total			+2.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	421.0KB	421.0KB	-12.0B
`stackAlerts`	25.2KB	25.1KB	-139.0B
total			-151.0B

History

💚 Build #258069 succeeded 05b42ea
💛 Build #257232 was flaky ce20437
💛 Build #256731 was flaky 95ba77a
💔 Build #256729 failed 8772e75
💛 Build #256364 was flaky f531765
💔 Build #256347 failed 0b10597

kibanamachine · 2024-12-11T04:45:25Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12269844696

(cherry picked from commit 168e67d)

kibanamachine · 2024-12-11T04:50:17Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Supports custom formatters in charts (#201540)](#201540)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Peter Pisljar <[email protected]>

ppisljar added 5 commits November 21, 2024 10:03

fix esql field hints

eb8118f

fix esql field hints

11808e9

allow to get meta from esql based datatable

cf66f63

allow editing format and label for esql

28794cd

fix types

823a6d3

ppisljar added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ESQL ES|QL related features in Kibana labels Nov 25, 2024

ppisljar added 3 commits November 25, 2024 13:43

fix jest test

bb62c90

use the correct types

c67876c

Merge branch 'main' into esql/formatting

3487fc3

markov00 mentioned this pull request Nov 26, 2024

[Lens] Tech preview of Lens powered by ES|QL #197028

Open

11 tasks

ppisljar marked this pull request as ready for review November 26, 2024 09:44

ppisljar requested review from a team as code owners November 26, 2024 09:44

Merge branch 'main' into esql/formatting

ddbc2d0

kertal reviewed Nov 28, 2024

View reviewed changes

markov00 requested changes Nov 28, 2024

View reviewed changes

ppisljar added 2 commits December 2, 2024 10:03

Merge branch 'main' into esql/formatting

d03b1dd

update based on review

bc3ec1f

ppisljar force-pushed the esql/formatting branch from 46eb97e to bc3ec1f Compare December 2, 2024 10:13

...

22731c8

ppisljar requested a review from a team as a code owner December 3, 2024 08:16

update look&feel

f531765

ppisljar force-pushed the esql/formatting branch from 0b10597 to f531765 Compare December 3, 2024 10:54

markov00 requested changes Dec 3, 2024

View reviewed changes

ppisljar and others added 2 commits December 4, 2024 07:24

fix based on review

8772e75

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

95ba77a

…-fix'

cnasikas approved these changes Dec 4, 2024

View reviewed changes

Merge branch 'main' into esql/formatting

ce20437

stratoula reviewed Dec 5, 2024

View reviewed changes

packages/kbn-esql-editor/src/fetch_fields_from_esql.ts Outdated Show resolved Hide resolved

Merge branch 'main' into esql/formatting

05b42ea

stratoula approved these changes Dec 9, 2024

View reviewed changes

stratoula changed the title ~~adds labeling and formatting support to esql charts~~ [ES|QL] Supports custom formatters in charts Dec 9, 2024

markov00 self-requested a review December 9, 2024 08:50

markov00 approved these changes Dec 9, 2024

View reviewed changes

kertal requested review from kertal and a team December 9, 2024 09:33

kertal approved these changes Dec 10, 2024

View reviewed changes

ppisljar added 2 commits December 10, 2024 19:11

Merge branch 'main' into esql/formatting

7074216

Merge branch 'esql/formatting' of github.com:ppisljar/kibana into esq…

ca78ff8

…l/formatting

ppisljar merged commit 168e67d into elastic:main Dec 11, 2024
9 checks passed

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 11, 2024

[ES|QL] Supports custom formatters in charts (elastic#201540)

6630be4

(cherry picked from commit 168e67d)

kibanamachine mentioned this pull request Dec 11, 2024

[8.x] [ES|QL] Supports custom formatters in charts (#201540) #203717

Merged

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024

[ES|QL] Supports custom formatters in charts (elastic#201540)

8e2e2cc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ES|QL] Supports custom formatters in charts #201540

[ES|QL] Supports custom formatters in charts #201540

ppisljar commented Nov 25, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Nov 26, 2024

elasticmachine commented Nov 26, 2024

kertal Nov 28, 2024

ppisljar Dec 2, 2024

markov00 Dec 3, 2024

markov00 Dec 3, 2024

ppisljar Dec 4, 2024

markov00 Dec 4, 2024

ppisljar Dec 5, 2024

markov00 Dec 9, 2024

cnasikas left a comment

stratoula left a comment

stratoula left a comment •

edited

Loading

markov00 left a comment

kertal left a comment

elasticmachine commented Dec 10, 2024

kibanamachine commented Dec 11, 2024

kibanamachine commented Dec 11, 2024

[ES|QL] Supports custom formatters in charts #201540

[ES|QL] Supports custom formatters in charts #201540

Conversation

ppisljar commented Nov 25, 2024 • edited by kibanamachine Loading

Summary

elasticmachine commented Nov 26, 2024

elasticmachine commented Nov 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cnasikas left a comment

Choose a reason for hiding this comment

stratoula left a comment

Choose a reason for hiding this comment

stratoula left a comment • edited Loading

Choose a reason for hiding this comment

markov00 left a comment

Choose a reason for hiding this comment

kertal left a comment

Choose a reason for hiding this comment

elasticmachine commented Dec 10, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

History

kibanamachine commented Dec 11, 2024

kibanamachine commented Dec 11, 2024

💚 All backports created successfully

Questions ?

ppisljar commented Nov 25, 2024 •

edited by kibanamachine

Loading

stratoula left a comment •

edited

Loading