Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cloud Security] Removing Unused Options For CNVM #201461

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Nov 22, 2024

Summary

This PR is to Remove Unused options for CNVM + Edit the page now that there are no more options to choose from
Screenshot 2024-11-27 at 1 03 06 PM

@animehart
Copy link
Contributor Author

/ci

@animehart
Copy link
Contributor Author

/ci

@animehart animehart marked this pull request as ready for review November 22, 2024 21:51
@animehart animehart requested a review from a team as a code owner November 22, 2024 21:51
@animehart animehart added the Team:Cloud Security Cloud Security team related label Nov 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@animehart animehart added v9.0.0 v8.18.0 release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 22, 2024
Copy link
Contributor

@albertoblaz albertoblaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertoblaz
Copy link
Contributor

@elasticmachine merge upstream

@animehart animehart changed the title [Cloud Security] Removing Unusued Options For CNVM [Cloud Security] Removing Unused Options For CNVM Nov 26, 2024
@animehart animehart marked this pull request as draft November 27, 2024 02:53
@animehart animehart marked this pull request as ready for review November 27, 2024 21:03
@animehart animehart requested a review from opauloh November 27, 2024 21:18
Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@animehart
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #100 / Dataset Quality Dataset quality handles user privileges User can read logs-* User cannot monitor any data stream Estimated data are not available due to underprivileged user

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 502.8KB 502.6KB -212.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudSecurityPosture 17.9KB 17.9KB -76.0B

History

@animehart animehart merged commit 91643e9 into elastic:main Nov 28, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12072122605

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 28, 2024
## Summary
This PR is to Remove Unused options for CNVM + Edit the page now that
there are no more options to choose from
<img width="825" alt="Screenshot 2024-11-27 at 1 03 06 PM"
src="https://github.com/user-attachments/assets/712ce0bd-c0f8-47ae-b4a2-ee6fe2a047a2">

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 91643e9)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 28, 2024
…02200)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Cloud Security] Removing Unused Options For CNVM
(#201461)](#201461)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rickyanto
Ang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T15:53:37Z","message":"[Cloud
Security] Removing Unused Options For CNVM (#201461)\n\n##
Summary\r\nThis PR is to Remove Unused options for CNVM + Edit the page
now that\r\nthere are no more options to choose from\r\n<img
width=\"825\" alt=\"Screenshot 2024-11-27 at 1 03
06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/712ce0bd-c0f8-47ae-b4a2-ee6fe2a047a2\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"91643e9491a51fce4557bf1b5876452527259ecf","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud
Security","backport:prev-minor","v8.18.0"],"title":"[Cloud Security]
Removing Unused Options For
CNVM","number":201461,"url":"https://github.com/elastic/kibana/pull/201461","mergeCommit":{"message":"[Cloud
Security] Removing Unused Options For CNVM (#201461)\n\n##
Summary\r\nThis PR is to Remove Unused options for CNVM + Edit the page
now that\r\nthere are no more options to choose from\r\n<img
width=\"825\" alt=\"Screenshot 2024-11-27 at 1 03
06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/712ce0bd-c0f8-47ae-b4a2-ee6fe2a047a2\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"91643e9491a51fce4557bf1b5876452527259ecf"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201461","number":201461,"mergeCommit":{"message":"[Cloud
Security] Removing Unused Options For CNVM (#201461)\n\n##
Summary\r\nThis PR is to Remove Unused options for CNVM + Edit the page
now that\r\nthere are no more options to choose from\r\n<img
width=\"825\" alt=\"Screenshot 2024-11-27 at 1 03
06 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/712ce0bd-c0f8-47ae-b4a2-ee6fe2a047a2\">\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"91643e9491a51fce4557bf1b5876452527259ecf"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Rickyanto Ang <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary
This PR is to Remove Unused options for CNVM + Edit the page now that
there are no more options to choose from
<img width="825" alt="Screenshot 2024-11-27 at 1 03 06 PM"
src="https://github.com/user-attachments/assets/712ce0bd-c0f8-47ae-b4a2-ee6fe2a047a2">

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants