[SecuritySolution][Navigation] Prevent initial re-render using project nav #201431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semd
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @semd |
michaelolo24
approved these changes
Nov 25, 2024
angorayc
approved these changes
Nov 25, 2024
|
Starting backport for target branches: 8.16, 8.17, 8.x https://github.com/elastic/kibana/actions/runs/12015929027 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 25, 2024
…t nav (elastic#201431) ## Summary Prevents an initial re-render when the `project` navigation style is set (serverless and new solution nav for stateful). This re-render was affecting all the top-level pages in Security Solution. --------- Co-authored-by: Michael Olorunnisola <[email protected]> (cherry picked from commit d3ee297)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 25, 2024
…t nav (elastic#201431) ## Summary Prevents an initial re-render when the `project` navigation style is set (serverless and new solution nav for stateful). This re-render was affecting all the top-level pages in Security Solution. --------- Co-authored-by: Michael Olorunnisola <[email protected]> (cherry picked from commit d3ee297)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 25, 2024
…t nav (elastic#201431) ## Summary Prevents an initial re-render when the `project` navigation style is set (serverless and new solution nav for stateful). This re-render was affecting all the top-level pages in Security Solution. --------- Co-authored-by: Michael Olorunnisola <[email protected]> (cherry picked from commit d3ee297)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 25, 2024
… project nav (#201431) (#201666) # Backport This will backport the following commits from `main` to `8.16`: - [[SecuritySolution][Navigation] Prevent initial re-render using project nav (#201431)](#201431) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-25T17:56:28Z","message":"[SecuritySolution][Navigation] Prevent initial re-render using project nav (#201431)\n\n## Summary\r\n\r\nPrevents an initial re-render when the `project` navigation style is set\r\n(serverless and new solution nav for stateful).\r\n\r\nThis re-render was affecting all the top-level pages in Security\r\nSolution.\r\n\r\n---------\r\n\r\nCo-authored-by: Michael Olorunnisola <[email protected]>","sha":"d3ee297d9fc5e007d7333816074b02463dd0c646","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:version","v8.17.0","v8.18.0","v8.16.2"],"title":"[SecuritySolution][Navigation] Prevent initial re-render using project nav","number":201431,"url":"https://github.com/elastic/kibana/pull/201431","mergeCommit":{"message":"[SecuritySolution][Navigation] Prevent initial re-render using project nav (#201431)\n\n## Summary\r\n\r\nPrevents an initial re-render when the `project` navigation style is set\r\n(serverless and new solution nav for stateful).\r\n\r\nThis re-render was affecting all the top-level pages in Security\r\nSolution.\r\n\r\n---------\r\n\r\nCo-authored-by: Michael Olorunnisola <[email protected]>","sha":"d3ee297d9fc5e007d7333816074b02463dd0c646"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201431","number":201431,"mergeCommit":{"message":"[SecuritySolution][Navigation] Prevent initial re-render using project nav (#201431)\n\n## Summary\r\n\r\nPrevents an initial re-render when the `project` navigation style is set\r\n(serverless and new solution nav for stateful).\r\n\r\nThis re-render was affecting all the top-level pages in Security\r\nSolution.\r\n\r\n---------\r\n\r\nCo-authored-by: Michael Olorunnisola <[email protected]>","sha":"d3ee297d9fc5e007d7333816074b02463dd0c646"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 25, 2024
… project nav (#201431) (#201667) # Backport This will backport the following commits from `main` to `8.17`: - [[SecuritySolution][Navigation] Prevent initial re-render using project nav (#201431)](#201431) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-25T17:56:28Z","message":"[SecuritySolution][Navigation] Prevent initial re-render using project nav (#201431)\n\n## Summary\r\n\r\nPrevents an initial re-render when the `project` navigation style is set\r\n(serverless and new solution nav for stateful).\r\n\r\nThis re-render was affecting all the top-level pages in Security\r\nSolution.\r\n\r\n---------\r\n\r\nCo-authored-by: Michael Olorunnisola <[email protected]>","sha":"d3ee297d9fc5e007d7333816074b02463dd0c646","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:version","v8.17.0","v8.18.0","v8.16.2"],"title":"[SecuritySolution][Navigation] Prevent initial re-render using project nav","number":201431,"url":"https://github.com/elastic/kibana/pull/201431","mergeCommit":{"message":"[SecuritySolution][Navigation] Prevent initial re-render using project nav (#201431)\n\n## Summary\r\n\r\nPrevents an initial re-render when the `project` navigation style is set\r\n(serverless and new solution nav for stateful).\r\n\r\nThis re-render was affecting all the top-level pages in Security\r\nSolution.\r\n\r\n---------\r\n\r\nCo-authored-by: Michael Olorunnisola <[email protected]>","sha":"d3ee297d9fc5e007d7333816074b02463dd0c646"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201431","number":201431,"mergeCommit":{"message":"[SecuritySolution][Navigation] Prevent initial re-render using project nav (#201431)\n\n## Summary\r\n\r\nPrevents an initial re-render when the `project` navigation style is set\r\n(serverless and new solution nav for stateful).\r\n\r\nThis re-render was affecting all the top-level pages in Security\r\nSolution.\r\n\r\n---------\r\n\r\nCo-authored-by: Michael Olorunnisola <[email protected]>","sha":"d3ee297d9fc5e007d7333816074b02463dd0c646"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 25, 2024
…project nav (#201431) (#201668) # Backport This will backport the following commits from `main` to `8.x`: - [[SecuritySolution][Navigation] Prevent initial re-render using project nav (#201431)](#201431) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-25T17:56:28Z","message":"[SecuritySolution][Navigation] Prevent initial re-render using project nav (#201431)\n\n## Summary\r\n\r\nPrevents an initial re-render when the `project` navigation style is set\r\n(serverless and new solution nav for stateful).\r\n\r\nThis re-render was affecting all the top-level pages in Security\r\nSolution.\r\n\r\n---------\r\n\r\nCo-authored-by: Michael Olorunnisola <[email protected]>","sha":"d3ee297d9fc5e007d7333816074b02463dd0c646","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","backport:version","v8.17.0","v8.18.0","v8.16.2"],"title":"[SecuritySolution][Navigation] Prevent initial re-render using project nav","number":201431,"url":"https://github.com/elastic/kibana/pull/201431","mergeCommit":{"message":"[SecuritySolution][Navigation] Prevent initial re-render using project nav (#201431)\n\n## Summary\r\n\r\nPrevents an initial re-render when the `project` navigation style is set\r\n(serverless and new solution nav for stateful).\r\n\r\nThis re-render was affecting all the top-level pages in Security\r\nSolution.\r\n\r\n---------\r\n\r\nCo-authored-by: Michael Olorunnisola <[email protected]>","sha":"d3ee297d9fc5e007d7333816074b02463dd0c646"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201431","number":201431,"mergeCommit":{"message":"[SecuritySolution][Navigation] Prevent initial re-render using project nav (#201431)\n\n## Summary\r\n\r\nPrevents an initial re-render when the `project` navigation style is set\r\n(serverless and new solution nav for stateful).\r\n\r\nThis re-render was affecting all the top-level pages in Security\r\nSolution.\r\n\r\n---------\r\n\r\nCo-authored-by: Michael Olorunnisola <[email protected]>","sha":"d3ee297d9fc5e007d7333816074b02463dd0c646"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…t nav (elastic#201431) ## Summary Prevents an initial re-render when the `project` navigation style is set (serverless and new solution nav for stateful). This re-render was affecting all the top-level pages in Security Solution. --------- Co-authored-by: Michael Olorunnisola <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…t nav (elastic#201431) ## Summary Prevents an initial re-render when the `project` navigation style is set (serverless and new solution nav for stateful). This re-render was affecting all the top-level pages in Security Solution. --------- Co-authored-by: Michael Olorunnisola <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prevents an initial re-render when the
projectnavigation style is set (serverless and new solution nav for stateful).This re-render was affecting all the top-level pages in Security Solution.