-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Create dev script to be able to run Deployment agnostic tests #201351
Conversation
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Nice job! I haven't review it yet, but I've got a couple questions/remarks after briefly looking at it.
|
I will add those changes, thanks for the review @crespocarlos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As agreed with @crespocarlos , we will keep these 2 files separated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the script!
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12010502273 |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
cc @rmyz |
…lastic#201351) ## Summary Closes elastic#201346 This PR adds a `dat` dev script, which lets you easily run APM deployment-agnostic tests, as we already do with `api` tests. ## Examples Run only server with stateful config ```sh node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --server ``` Run only runner with stateful config ```sh node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --runner ``` Run everything with serverless config ```sh node x-pack/plugins/observability_solution/apm/scripts/test/dat --serverless ``` More information [here](https://github.com/elastic/kibana/pull/201351/files#diff-5ca943bbe3962fc31cce510407cc1563a959b0fdb9cb52619f57e1f182a9751a) --------- Co-authored-by: Cauê Marcondes <[email protected]> (cherry picked from commit 92fc653)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…ests (#201351) (#201585) # Backport This will backport the following commits from `main` to `8.x`: - [[APM] Create dev script to be able to run Deployment agnostic tests (#201351)](#201351) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-25T12:56:45Z","message":"[APM] Create dev script to be able to run Deployment agnostic tests (#201351)\n\n## Summary\n\nCloses #201346\n\nThis PR adds a `dat` dev script, which lets you easily run APM\ndeployment-agnostic tests, as we already do with `api` tests.\n\n## Examples\n\nRun only server with stateful config\n```sh\nnode x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --server\n```\nRun only runner with stateful config\n```sh\nnode x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --runner\n```\nRun everything with serverless config\n```sh\nnode x-pack/plugins/observability_solution/apm/scripts/test/dat --serverless\n```\n\nMore information\n[here](https://github.com/elastic/kibana/pull/201351/files#diff-5ca943bbe3962fc31cce510407cc1563a959b0fdb9cb52619f57e1f182a9751a)\n\n---------\n\nCo-authored-by: Cauê Marcondes <[email protected]>","sha":"92fc653480b1fb8a64d2adafe385d1a1a390274a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services"],"title":"[APM] Create dev script to be able to run Deployment agnostic tests","number":201351,"url":"https://github.com/elastic/kibana/pull/201351","mergeCommit":{"message":"[APM] Create dev script to be able to run Deployment agnostic tests (#201351)\n\n## Summary\n\nCloses #201346\n\nThis PR adds a `dat` dev script, which lets you easily run APM\ndeployment-agnostic tests, as we already do with `api` tests.\n\n## Examples\n\nRun only server with stateful config\n```sh\nnode x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --server\n```\nRun only runner with stateful config\n```sh\nnode x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --runner\n```\nRun everything with serverless config\n```sh\nnode x-pack/plugins/observability_solution/apm/scripts/test/dat --serverless\n```\n\nMore information\n[here](https://github.com/elastic/kibana/pull/201351/files#diff-5ca943bbe3962fc31cce510407cc1563a959b0fdb9cb52619f57e1f182a9751a)\n\n---------\n\nCo-authored-by: Cauê Marcondes <[email protected]>","sha":"92fc653480b1fb8a64d2adafe385d1a1a390274a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201351","number":201351,"mergeCommit":{"message":"[APM] Create dev script to be able to run Deployment agnostic tests (#201351)\n\n## Summary\n\nCloses #201346\n\nThis PR adds a `dat` dev script, which lets you easily run APM\ndeployment-agnostic tests, as we already do with `api` tests.\n\n## Examples\n\nRun only server with stateful config\n```sh\nnode x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --server\n```\nRun only runner with stateful config\n```sh\nnode x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --runner\n```\nRun everything with serverless config\n```sh\nnode x-pack/plugins/observability_solution/apm/scripts/test/dat --serverless\n```\n\nMore information\n[here](https://github.com/elastic/kibana/pull/201351/files#diff-5ca943bbe3962fc31cce510407cc1563a959b0fdb9cb52619f57e1f182a9751a)\n\n---------\n\nCo-authored-by: Cauê Marcondes <[email protected]>","sha":"92fc653480b1fb8a64d2adafe385d1a1a390274a"}}]}] BACKPORT--> Co-authored-by: Sergi Romeu <[email protected]>
…lastic#201351) ## Summary Closes elastic#201346 This PR adds a `dat` dev script, which lets you easily run APM deployment-agnostic tests, as we already do with `api` tests. ## Examples Run only server with stateful config ```sh node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --server ``` Run only runner with stateful config ```sh node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --runner ``` Run everything with serverless config ```sh node x-pack/plugins/observability_solution/apm/scripts/test/dat --serverless ``` More information [here](https://github.com/elastic/kibana/pull/201351/files#diff-5ca943bbe3962fc31cce510407cc1563a959b0fdb9cb52619f57e1f182a9751a) --------- Co-authored-by: Cauê Marcondes <[email protected]>
…lastic#201351) ## Summary Closes elastic#201346 This PR adds a `dat` dev script, which lets you easily run APM deployment-agnostic tests, as we already do with `api` tests. ## Examples Run only server with stateful config ```sh node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --server ``` Run only runner with stateful config ```sh node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --runner ``` Run everything with serverless config ```sh node x-pack/plugins/observability_solution/apm/scripts/test/dat --serverless ``` More information [here](https://github.com/elastic/kibana/pull/201351/files#diff-5ca943bbe3962fc31cce510407cc1563a959b0fdb9cb52619f57e1f182a9751a) --------- Co-authored-by: Cauê Marcondes <[email protected]>
Summary
Closes #201346
This PR adds a
dat
dev script, which lets you easily run APM deployment-agnostic tests, as we already do withapi
tests.Examples
Run only server with stateful config
Run only runner with stateful config
Run everything with serverless config
More information here