Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Create dev script to be able to run Deployment agnostic tests #201351

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

rmyz
Copy link
Contributor

@rmyz rmyz commented Nov 22, 2024

Summary

Closes #201346

This PR adds a dat dev script, which lets you easily run APM deployment-agnostic tests, as we already do with api tests.

Examples

Run only server with stateful config

node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --server

Run only runner with stateful config

node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --runner

Run everything with serverless config

node x-pack/plugins/observability_solution/apm/scripts/test/dat --serverless

More information here

@rmyz rmyz added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 22, 2024
@rmyz rmyz self-assigned this Nov 22, 2024
@rmyz rmyz requested a review from a team as a code owner November 22, 2024 10:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 22, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@crespocarlos
Copy link
Contributor

Nice job! I haven't review it yet, but I've got a couple questions/remarks after briefly looking at it.

  • Could we incorporate the necessary changes into api.js CLI instead?
  • Unless you are familiar with what the acronym stands for, dat is a confusing name.

@rmyz
Copy link
Contributor Author

rmyz commented Nov 22, 2024

Nice job! I haven't review it yet, but I've got a couple questions/remarks after briefly looking at it.

  • Could we incorporate the necessary changes into api.js CLI instead?
  • Unless you are familiar with what the acronym stands for, dat is a confusing name.

I will add those changes, thanks for the review @crespocarlos

Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmyz
Copy link
Contributor Author

rmyz commented Nov 25, 2024

As agreed with @crespocarlos , we will keep these 2 files separated api.js and dat.js to avoid overcomplicating api.js with loads of params.

Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the script!

@rmyz rmyz enabled auto-merge (squash) November 25, 2024 10:21
@rmyz rmyz removed the ci:project-deploy-observability Create an Observability project label Nov 25, 2024
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 25, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@rmyz rmyz removed the ci:project-deploy-observability Create an Observability project label Nov 25, 2024
@rmyz rmyz merged commit 92fc653 into elastic:main Nov 25, 2024
33 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12010502273

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / Category can submit without setting a category
  • [job] [logs] Jest Tests #11 / OutputHealth should render output health component when degraded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
apm 12 13 +1

Total ESLint disabled count

id before after diff
apm 80 81 +1

History

cc @rmyz

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 25, 2024
…lastic#201351)

## Summary

Closes elastic#201346

This PR adds a `dat` dev script, which lets you easily run APM
deployment-agnostic tests, as we already do with `api` tests.

## Examples

Run only server with stateful config
```sh
node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --server
```
Run only runner with stateful config
```sh
node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --runner
```
Run everything with serverless config
```sh
node x-pack/plugins/observability_solution/apm/scripts/test/dat --serverless
```

More information
[here](https://github.com/elastic/kibana/pull/201351/files#diff-5ca943bbe3962fc31cce510407cc1563a959b0fdb9cb52619f57e1f182a9751a)

---------

Co-authored-by: Cauê Marcondes <[email protected]>
(cherry picked from commit 92fc653)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Nov 25, 2024
2 tasks
@rmyz rmyz deleted the 201346-apm-create-dat-dev-script branch November 25, 2024 13:56
kibanamachine added a commit that referenced this pull request Nov 25, 2024
…ests (#201351) (#201585)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM] Create dev script to be able to run Deployment agnostic tests
(#201351)](#201351)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sergi
Romeu","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-25T12:56:45Z","message":"[APM]
Create dev script to be able to run Deployment agnostic tests
(#201351)\n\n## Summary\n\nCloses #201346\n\nThis PR adds a `dat` dev
script, which lets you easily run APM\ndeployment-agnostic tests, as we
already do with `api` tests.\n\n## Examples\n\nRun only server with
stateful config\n```sh\nnode
x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful
--server\n```\nRun only runner with stateful config\n```sh\nnode
x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful
--runner\n```\nRun everything with serverless config\n```sh\nnode
x-pack/plugins/observability_solution/apm/scripts/test/dat
--serverless\n```\n\nMore
information\n[here](https://github.com/elastic/kibana/pull/201351/files#diff-5ca943bbe3962fc31cce510407cc1563a959b0fdb9cb52619f57e1f182a9751a)\n\n---------\n\nCo-authored-by:
Cauê Marcondes
<[email protected]>","sha":"92fc653480b1fb8a64d2adafe385d1a1a390274a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-infra_services"],"title":"[APM]
Create dev script to be able to run Deployment agnostic
tests","number":201351,"url":"https://github.com/elastic/kibana/pull/201351","mergeCommit":{"message":"[APM]
Create dev script to be able to run Deployment agnostic tests
(#201351)\n\n## Summary\n\nCloses #201346\n\nThis PR adds a `dat` dev
script, which lets you easily run APM\ndeployment-agnostic tests, as we
already do with `api` tests.\n\n## Examples\n\nRun only server with
stateful config\n```sh\nnode
x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful
--server\n```\nRun only runner with stateful config\n```sh\nnode
x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful
--runner\n```\nRun everything with serverless config\n```sh\nnode
x-pack/plugins/observability_solution/apm/scripts/test/dat
--serverless\n```\n\nMore
information\n[here](https://github.com/elastic/kibana/pull/201351/files#diff-5ca943bbe3962fc31cce510407cc1563a959b0fdb9cb52619f57e1f182a9751a)\n\n---------\n\nCo-authored-by:
Cauê Marcondes
<[email protected]>","sha":"92fc653480b1fb8a64d2adafe385d1a1a390274a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201351","number":201351,"mergeCommit":{"message":"[APM]
Create dev script to be able to run Deployment agnostic tests
(#201351)\n\n## Summary\n\nCloses #201346\n\nThis PR adds a `dat` dev
script, which lets you easily run APM\ndeployment-agnostic tests, as we
already do with `api` tests.\n\n## Examples\n\nRun only server with
stateful config\n```sh\nnode
x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful
--server\n```\nRun only runner with stateful config\n```sh\nnode
x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful
--runner\n```\nRun everything with serverless config\n```sh\nnode
x-pack/plugins/observability_solution/apm/scripts/test/dat
--serverless\n```\n\nMore
information\n[here](https://github.com/elastic/kibana/pull/201351/files#diff-5ca943bbe3962fc31cce510407cc1563a959b0fdb9cb52619f57e1f182a9751a)\n\n---------\n\nCo-authored-by:
Cauê Marcondes
<[email protected]>","sha":"92fc653480b1fb8a64d2adafe385d1a1a390274a"}}]}]
BACKPORT-->

Co-authored-by: Sergi Romeu <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
…lastic#201351)

## Summary

Closes elastic#201346

This PR adds a `dat` dev script, which lets you easily run APM
deployment-agnostic tests, as we already do with `api` tests.

## Examples

Run only server with stateful config
```sh
node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --server
```
Run only runner with stateful config
```sh
node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --runner
```
Run everything with serverless config
```sh
node x-pack/plugins/observability_solution/apm/scripts/test/dat --serverless
```

More information
[here](https://github.com/elastic/kibana/pull/201351/files#diff-5ca943bbe3962fc31cce510407cc1563a959b0fdb9cb52619f57e1f182a9751a)

---------

Co-authored-by: Cauê Marcondes <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…lastic#201351)

## Summary

Closes elastic#201346

This PR adds a `dat` dev script, which lets you easily run APM
deployment-agnostic tests, as we already do with `api` tests.

## Examples

Run only server with stateful config
```sh
node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --server
```
Run only runner with stateful config
```sh
node x-pack/plugins/observability_solution/apm/scripts/test/dat --stateful --runner
```
Run everything with serverless config
```sh
node x-pack/plugins/observability_solution/apm/scripts/test/dat --serverless
```

More information
[here](https://github.com/elastic/kibana/pull/201351/files#diff-5ca943bbe3962fc31cce510407cc1563a959b0fdb9cb52619f57e1f182a9751a)

---------

Co-authored-by: Cauê Marcondes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Create dev script to be able to run Deployment agnostic tests
5 participants