[Monitoring] [Pipeline Viewer] Remove obsolete code

[justinkambic]

Motivation

As part of our revamp of the Pipeline Viewer, we have replaced a significant amount of visualization code. The old code may be useful in the future, but for the time being we have no plans to use it, so we are going to remove it from the active codebase and let it live in history for possible future reuse.

Closes #19736

Testing This PR

As the code we're removing is no longer in use, testing is a little obscure. The best procedure is making sure it passes CI, and running the view itself.

1. Start up a Logstash pipeline with at least one branch.
2. Navigate to X-Pack monitoring.
3. Choose Logstash/Pipelines and open the view for your pipeline.
4. Make sure all the features work.
   a. Click a plugin name to ensure DetailDrawer renders properly
   b. Collapse/expand your branch repeatedly
   c. Ensure no errors/warnings are logged to the dev console

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[justinkambic]

@ycombinator @mattapperson should be good to review now, thanks

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[ycombinator]

Are the rest of the classes here still needed?

[ycombinator]

I think its not as obvious but there's some obsolete code in the models folder as well, for example:

kibana/x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/boolean_edge.js

Lines 22 to 24 in 937d141

	get svgClass() {
	return `${super.svgClass} ${super.svgClass}Boolean ${super.svgClass}Boolean--${this.when}`;
	}

[justinkambic]

I think its not as obvious but there's some obsolete code in the models folder

I did find this but I was under the impression that it's not obsolete because it's used in the Graph model, no?

Are the rest of the classes here still needed?

Same question as above.

[ycombinator]

I did find this but I was under the impression that it's not obsolete because it's used in the Graph model, no?

I think it depends. IMO, the only code that should be left in the Graph model classes after this PR is code that's needed by the conversion process to go from DAG -> config representation. Everything else should be obsolete, no?

[justinkambic]

Everything else should be obsolete, no?

Yeah, that sounds good, I'll revisit this. 👍

[justinkambic]

@ycombinator should be good for another 👀

[ycombinator]

This is looking good. Found one more area that you can clean up:

I think this object key can go, including the methods used to generate it's value:

kibana/x-pack/plugins/monitoring/public/components/logstash/pipeline_viewer/models/graph/vertex.js

Line 61 in 8fc0fca

display: this.truncateStringForDisplay(this.id, this.displaySubtitleMaxLength)

In fact, once you remove the display key, the object will have just one key left, complete, so you could probably just remove the object wrapper altogether.

There's a similar area in the IfVertex class as well.

And remember the corresponding unit test code as well.

[justinkambic]

@ycombinator e8fa994 should address the display prop

[ycombinator]

LGTM pending green CI. Great to see all the old code being removed from the codebase ❤️.

[elasticmachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request

[justinkambic]

@ycombinator can you please have a 👀 at 36f369e

If that LGTY then I think we are good to merge

[ycombinator]

LGTM after changes made to make CI go green.

[justinkambic]

Backported to:
6.4.0/6.x 15667e5