-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] update cheerio to 1.0.0 #201216
Closed
Closed
[chore] update cheerio to 1.0.0 #201216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
faea438
to
e47c383
Compare
💔 Build Failed
Failed CI StepsHistory
|
Closing, we decided to postpone it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #200791
Updating the cheerio dependency separately due to issues with globally bumping it to version
1.0.0
:The enzyme library, which we use in many Jest tests, has pinned cheerio to 1.0.0-rc.3. This is because later releases of cheerio no longer export the lib folder, which enzyme relies on.
If we globally update cheerio to version
1.0.0
, Jest tests running injest-environment-jsdom
fail with the error:To resolve this issue, I applied dependency resolution to ensure compatibility:
[email protected]
is still supported by[email protected]
and passes our snyk check (1.0.0-rc.3
fails)I believe it is a temporary solution because
enzyme
will be removed with future React updates.