Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update cheerio to 1.0.0 #201216

Closed
wants to merge 21 commits into from
Closed

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Nov 21, 2024

Summary

Related to #200791

Updating the cheerio dependency separately due to issues with globally bumping it to version 1.0.0:

The enzyme library, which we use in many Jest tests, has pinned cheerio to 1.0.0-rc.3. This is because later releases of cheerio no longer export the lib folder, which enzyme relies on.

If we globally update cheerio to version 1.0.0, Jest tests running in jest-environment-jsdom fail with the error:

Cannot find module 'cheerio/lib/utils' from 'node_modules/enzyme/build/Utils.js'

To resolve this issue, I applied dependency resolution to ensure compatibility:

[email protected] is still supported by [email protected] and passes our snyk check (1.0.0-rc.3 fails)

I believe it is a temporary solution because enzyme will be removed with future React updates.

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 21, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@elasticmachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

History

@dmlemeshko
Copy link
Member Author

Closing, we decided to postpone it.

@dmlemeshko dmlemeshko closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants