Set refresh according to stateful vs stateless when indexing alert documents #201209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Feature:Alerting
Team:ResponseOps
3 tasks
…ikecote/kibana into alerting/refresh-stateful-vs-stateless
…h-stateful-vs-stateless
mikecote
added
ci:cloud-deploy
mikecote
added
ci:project-deploy-security
@jloleysens from my observations, requests take 0-1s longer with |
kdelemme
approved these changes
Nov 26, 2024
This reverts commit 7c19b45.
mikecote
removed
ci:cloud-deploy
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
⏳ Build in-progress
History
cc @mikecote |
|
Starting backport for target branches: 8.16, 8.17 https://github.com/elastic/kibana/actions/runs/12073149086 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Nov 28, 2024
…cuments (elastic#201209) In this PR, I'm making the change so when Kibana is running with Elasticsearch stateful we set refresh to `wait_for` (instead of `true`) so we are not putting too much pressure on the Elasticsearch indices when under load. ## To verify Very using the Cloud deployment and Serverless project created from this PR 1. Create an always firing ES Query rule 2. Create an always firing security detection rule w/ alert suppression 3. Verify the ECH cluster logs and observe `*** Refresh value when indexing alerts: wait_for` and `*** Rule registry - refresh value when indexing alerts: wait_for` messages 4. Verify the serverless project logs on QA overview and observe `*** Refresh value when indexing alerts: true` and `*** Rule registry - refresh value when indexing alerts: true` messages ## To-Do - [x] Revert commit elastic@7c19b45 that was added for testing purposes --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit a4cb330) # Conflicts: # x-pack/plugins/alerting/kibana.jsonc # x-pack/plugins/alerting/server/plugin.ts
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Nov 28, 2024
…cuments (elastic#201209) In this PR, I'm making the change so when Kibana is running with Elasticsearch stateful we set refresh to `wait_for` (instead of `true`) so we are not putting too much pressure on the Elasticsearch indices when under load. ## To verify Very using the Cloud deployment and Serverless project created from this PR 1. Create an always firing ES Query rule 2. Create an always firing security detection rule w/ alert suppression 3. Verify the ECH cluster logs and observe `*** Refresh value when indexing alerts: wait_for` and `*** Rule registry - refresh value when indexing alerts: wait_for` messages 4. Verify the serverless project logs on QA overview and observe `*** Refresh value when indexing alerts: true` and `*** Rule registry - refresh value when indexing alerts: true` messages ## To-Do - [x] Revert commit elastic@7c19b45 that was added for testing purposes --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit a4cb330) # Conflicts: # x-pack/plugins/alerting/server/plugin.ts
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Nov 28, 2024
…cuments (elastic#201209) In this PR, I'm making the change so when Kibana is running with Elasticsearch stateful we set refresh to `wait_for` (instead of `true`) so we are not putting too much pressure on the Elasticsearch indices when under load. ## To verify Very using the Cloud deployment and Serverless project created from this PR 1. Create an always firing ES Query rule 2. Create an always firing security detection rule w/ alert suppression 3. Verify the ECH cluster logs and observe `*** Refresh value when indexing alerts: wait_for` and `*** Rule registry - refresh value when indexing alerts: wait_for` messages 4. Verify the serverless project logs on QA overview and observe `*** Refresh value when indexing alerts: true` and `*** Rule registry - refresh value when indexing alerts: true` messages ## To-Do - [x] Revert commit elastic@7c19b45 that was added for testing purposes --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit a4cb330)
mikecote
added a commit
that referenced
this pull request
Nov 29, 2024
…ert documents (#201209) (#202227) # Backport This will backport the following commits from `main` to `8.x`: - [Set refresh according to stateful vs stateless when indexing alert documents (#201209)](#201209) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mike Côté","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T17:10:56Z","message":"Set refresh according to stateful vs stateless when indexing alert documents (#201209)\n\nIn this PR, I'm making the change so when Kibana is running with\r\nElasticsearch stateful we set refresh to `wait_for` (instead of `true`)\r\nso we are not putting too much pressure on the Elasticsearch indices\r\nwhen under load.\r\n\r\n## To verify\r\n\r\nVery using the Cloud deployment and Serverless project created from this\r\nPR\r\n\r\n1. Create an always firing ES Query rule\r\n2. Create an always firing security detection rule w/ alert suppression\r\n3. Verify the ECH cluster logs and observe `*** Refresh value when\r\nindexing alerts: wait_for` and `*** Rule registry - refresh value when\r\nindexing alerts: wait_for` messages\r\n4. Verify the serverless project logs on QA overview and observe `***\r\nRefresh value when indexing alerts: true` and `*** Rule registry -\r\nrefresh value when indexing alerts: true` messages\r\n\r\n## To-Do\r\n\r\n- [x] Revert commit\r\nhttps://github.com//pull/201209/commits/7c19b458e6f55866bfff6a5b0f39188ae95dc6c6\r\nthat was added for testing purposes\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a4cb330af2d414e383d75efce526513171098ece","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0","v8.16.1","v8.18.0"],"number":201209,"url":"https://github.com/elastic/kibana/pull/201209","mergeCommit":{"message":"Set refresh according to stateful vs stateless when indexing alert documents (#201209)\n\nIn this PR, I'm making the change so when Kibana is running with\r\nElasticsearch stateful we set refresh to `wait_for` (instead of `true`)\r\nso we are not putting too much pressure on the Elasticsearch indices\r\nwhen under load.\r\n\r\n## To verify\r\n\r\nVery using the Cloud deployment and Serverless project created from this\r\nPR\r\n\r\n1. Create an always firing ES Query rule\r\n2. Create an always firing security detection rule w/ alert suppression\r\n3. Verify the ECH cluster logs and observe `*** Refresh value when\r\nindexing alerts: wait_for` and `*** Rule registry - refresh value when\r\nindexing alerts: wait_for` messages\r\n4. Verify the serverless project logs on QA overview and observe `***\r\nRefresh value when indexing alerts: true` and `*** Rule registry -\r\nrefresh value when indexing alerts: true` messages\r\n\r\n## To-Do\r\n\r\n- [x] Revert commit\r\nhttps://github.com//pull/201209/commits/7c19b458e6f55866bfff6a5b0f39188ae95dc6c6\r\nthat was added for testing purposes\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a4cb330af2d414e383d75efce526513171098ece"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201209","number":201209,"mergeCommit":{"message":"Set refresh according to stateful vs stateless when indexing alert documents (#201209)\n\nIn this PR, I'm making the change so when Kibana is running with\r\nElasticsearch stateful we set refresh to `wait_for` (instead of `true`)\r\nso we are not putting too much pressure on the Elasticsearch indices\r\nwhen under load.\r\n\r\n## To verify\r\n\r\nVery using the Cloud deployment and Serverless project created from this\r\nPR\r\n\r\n1. Create an always firing ES Query rule\r\n2. Create an always firing security detection rule w/ alert suppression\r\n3. Verify the ECH cluster logs and observe `*** Refresh value when\r\nindexing alerts: wait_for` and `*** Rule registry - refresh value when\r\nindexing alerts: wait_for` messages\r\n4. Verify the serverless project logs on QA overview and observe `***\r\nRefresh value when indexing alerts: true` and `*** Rule registry -\r\nrefresh value when indexing alerts: true` messages\r\n\r\n## To-Do\r\n\r\n- [x] Revert commit\r\nhttps://github.com//pull/201209/commits/7c19b458e6f55866bfff6a5b0f39188ae95dc6c6\r\nthat was added for testing purposes\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a4cb330af2d414e383d75efce526513171098ece"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/202221","number":202221,"state":"OPEN"},{"branch":"8.16","label":"v8.16.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/202222","number":202222,"state":"OPEN"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
mikecote
added a commit
that referenced
this pull request
Nov 29, 2024
…lert documents (#201209) (#202221) # Backport This will backport the following commits from `main` to `8.17`: - [Set refresh according to stateful vs stateless when indexing alert documents (#201209)](#201209) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mike Côté","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T17:10:56Z","message":"Set refresh according to stateful vs stateless when indexing alert documents (#201209)\n\nIn this PR, I'm making the change so when Kibana is running with\r\nElasticsearch stateful we set refresh to `wait_for` (instead of `true`)\r\nso we are not putting too much pressure on the Elasticsearch indices\r\nwhen under load.\r\n\r\n## To verify\r\n\r\nVery using the Cloud deployment and Serverless project created from this\r\nPR\r\n\r\n1. Create an always firing ES Query rule\r\n2. Create an always firing security detection rule w/ alert suppression\r\n3. Verify the ECH cluster logs and observe `*** Refresh value when\r\nindexing alerts: wait_for` and `*** Rule registry - refresh value when\r\nindexing alerts: wait_for` messages\r\n4. Verify the serverless project logs on QA overview and observe `***\r\nRefresh value when indexing alerts: true` and `*** Rule registry -\r\nrefresh value when indexing alerts: true` messages\r\n\r\n## To-Do\r\n\r\n- [x] Revert commit\r\nhttps://github.com//pull/201209/commits/7c19b458e6f55866bfff6a5b0f39188ae95dc6c6\r\nthat was added for testing purposes\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a4cb330af2d414e383d75efce526513171098ece","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0","v8.16.1"],"number":201209,"url":"https://github.com/elastic/kibana/pull/201209","mergeCommit":{"message":"Set refresh according to stateful vs stateless when indexing alert documents (#201209)\n\nIn this PR, I'm making the change so when Kibana is running with\r\nElasticsearch stateful we set refresh to `wait_for` (instead of `true`)\r\nso we are not putting too much pressure on the Elasticsearch indices\r\nwhen under load.\r\n\r\n## To verify\r\n\r\nVery using the Cloud deployment and Serverless project created from this\r\nPR\r\n\r\n1. Create an always firing ES Query rule\r\n2. Create an always firing security detection rule w/ alert suppression\r\n3. Verify the ECH cluster logs and observe `*** Refresh value when\r\nindexing alerts: wait_for` and `*** Rule registry - refresh value when\r\nindexing alerts: wait_for` messages\r\n4. Verify the serverless project logs on QA overview and observe `***\r\nRefresh value when indexing alerts: true` and `*** Rule registry -\r\nrefresh value when indexing alerts: true` messages\r\n\r\n## To-Do\r\n\r\n- [x] Revert commit\r\nhttps://github.com//pull/201209/commits/7c19b458e6f55866bfff6a5b0f39188ae95dc6c6\r\nthat was added for testing purposes\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a4cb330af2d414e383d75efce526513171098ece"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201209","number":201209,"mergeCommit":{"message":"Set refresh according to stateful vs stateless when indexing alert documents (#201209)\n\nIn this PR, I'm making the change so when Kibana is running with\r\nElasticsearch stateful we set refresh to `wait_for` (instead of `true`)\r\nso we are not putting too much pressure on the Elasticsearch indices\r\nwhen under load.\r\n\r\n## To verify\r\n\r\nVery using the Cloud deployment and Serverless project created from this\r\nPR\r\n\r\n1. Create an always firing ES Query rule\r\n2. Create an always firing security detection rule w/ alert suppression\r\n3. Verify the ECH cluster logs and observe `*** Refresh value when\r\nindexing alerts: wait_for` and `*** Rule registry - refresh value when\r\nindexing alerts: wait_for` messages\r\n4. Verify the serverless project logs on QA overview and observe `***\r\nRefresh value when indexing alerts: true` and `*** Rule registry -\r\nrefresh value when indexing alerts: true` messages\r\n\r\n## To-Do\r\n\r\n- [x] Revert commit\r\nhttps://github.com//pull/201209/commits/7c19b458e6f55866bfff6a5b0f39188ae95dc6c6\r\nthat was added for testing purposes\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a4cb330af2d414e383d75efce526513171098ece"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
mikecote
added a commit
that referenced
this pull request
Nov 29, 2024
…lert documents (#201209) (#202222) # Backport This will backport the following commits from `main` to `8.16`: - [Set refresh according to stateful vs stateless when indexing alert documents (#201209)](#201209) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mike Côté","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T17:10:56Z","message":"Set refresh according to stateful vs stateless when indexing alert documents (#201209)\n\nIn this PR, I'm making the change so when Kibana is running with\r\nElasticsearch stateful we set refresh to `wait_for` (instead of `true`)\r\nso we are not putting too much pressure on the Elasticsearch indices\r\nwhen under load.\r\n\r\n## To verify\r\n\r\nVery using the Cloud deployment and Serverless project created from this\r\nPR\r\n\r\n1. Create an always firing ES Query rule\r\n2. Create an always firing security detection rule w/ alert suppression\r\n3. Verify the ECH cluster logs and observe `*** Refresh value when\r\nindexing alerts: wait_for` and `*** Rule registry - refresh value when\r\nindexing alerts: wait_for` messages\r\n4. Verify the serverless project logs on QA overview and observe `***\r\nRefresh value when indexing alerts: true` and `*** Rule registry -\r\nrefresh value when indexing alerts: true` messages\r\n\r\n## To-Do\r\n\r\n- [x] Revert commit\r\nhttps://github.com//pull/201209/commits/7c19b458e6f55866bfff6a5b0f39188ae95dc6c6\r\nthat was added for testing purposes\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a4cb330af2d414e383d75efce526513171098ece","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0","v8.16.1"],"number":201209,"url":"https://github.com/elastic/kibana/pull/201209","mergeCommit":{"message":"Set refresh according to stateful vs stateless when indexing alert documents (#201209)\n\nIn this PR, I'm making the change so when Kibana is running with\r\nElasticsearch stateful we set refresh to `wait_for` (instead of `true`)\r\nso we are not putting too much pressure on the Elasticsearch indices\r\nwhen under load.\r\n\r\n## To verify\r\n\r\nVery using the Cloud deployment and Serverless project created from this\r\nPR\r\n\r\n1. Create an always firing ES Query rule\r\n2. Create an always firing security detection rule w/ alert suppression\r\n3. Verify the ECH cluster logs and observe `*** Refresh value when\r\nindexing alerts: wait_for` and `*** Rule registry - refresh value when\r\nindexing alerts: wait_for` messages\r\n4. Verify the serverless project logs on QA overview and observe `***\r\nRefresh value when indexing alerts: true` and `*** Rule registry -\r\nrefresh value when indexing alerts: true` messages\r\n\r\n## To-Do\r\n\r\n- [x] Revert commit\r\nhttps://github.com//pull/201209/commits/7c19b458e6f55866bfff6a5b0f39188ae95dc6c6\r\nthat was added for testing purposes\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a4cb330af2d414e383d75efce526513171098ece"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201209","number":201209,"mergeCommit":{"message":"Set refresh according to stateful vs stateless when indexing alert documents (#201209)\n\nIn this PR, I'm making the change so when Kibana is running with\r\nElasticsearch stateful we set refresh to `wait_for` (instead of `true`)\r\nso we are not putting too much pressure on the Elasticsearch indices\r\nwhen under load.\r\n\r\n## To verify\r\n\r\nVery using the Cloud deployment and Serverless project created from this\r\nPR\r\n\r\n1. Create an always firing ES Query rule\r\n2. Create an always firing security detection rule w/ alert suppression\r\n3. Verify the ECH cluster logs and observe `*** Refresh value when\r\nindexing alerts: wait_for` and `*** Rule registry - refresh value when\r\nindexing alerts: wait_for` messages\r\n4. Verify the serverless project logs on QA overview and observe `***\r\nRefresh value when indexing alerts: true` and `*** Rule registry -\r\nrefresh value when indexing alerts: true` messages\r\n\r\n## To-Do\r\n\r\n- [x] Revert commit\r\nhttps://github.com//pull/201209/commits/7c19b458e6f55866bfff6a5b0f39188ae95dc6c6\r\nthat was added for testing purposes\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a4cb330af2d414e383d75efce526513171098ece"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…cuments (elastic#201209) In this PR, I'm making the change so when Kibana is running with Elasticsearch stateful we set refresh to `wait_for` (instead of `true`) so we are not putting too much pressure on the Elasticsearch indices when under load. ## To verify Very using the Cloud deployment and Serverless project created from this PR 1. Create an always firing ES Query rule 2. Create an always firing security detection rule w/ alert suppression 3. Verify the ECH cluster logs and observe `*** Refresh value when indexing alerts: wait_for` and `*** Rule registry - refresh value when indexing alerts: wait_for` messages 4. Verify the serverless project logs on QA overview and observe `*** Refresh value when indexing alerts: true` and `*** Rule registry - refresh value when indexing alerts: true` messages ## To-Do - [x] Revert commit elastic@7c19b45 that was added for testing purposes --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I'm making the change so when Kibana is running with Elasticsearch stateful we set refresh to
wait_for(instead oftrue) so we are not putting too much pressure on the Elasticsearch indices when under load.To verify
Very using the Cloud deployment and Serverless project created from this PR
*** Refresh value when indexing alerts: wait_forand*** Rule registry - refresh value when indexing alerts: wait_formessages*** Refresh value when indexing alerts: trueand*** Rule registry - refresh value when indexing alerts: truemessagesTo-Do