[Feature Flags Example Plugin] Change ctx provider #201097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
chore
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
afharo
commented
Nov 21, 2024
| @@ -59,8 +59,7 @@ export const FeatureFlagsExampleApp = ({ featureFlags }: FeatureFlagsExampleAppD | |||
| <h3>Rendered together</h3> | |||
| <p> | |||
| `useObservable` causes a full re-render of the component, updating the{' '} | |||
| <i>statically</i> | |||
| evaluated flags as well. | |||
| <i>statically</i> evaluated flags as well. | |||
There was a problem hiding this comment.
adding missing space after statically
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11952772954 |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
cc @afharo |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
gsoldevila
pushed a commit
to gsoldevila/kibana
that referenced
this pull request
Nov 22, 2024
(cherry picked from commit f026208) # Conflicts: # examples/feature_flags_example/public/components/app.tsx # examples/feature_flags_example/tsconfig.json
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
gsoldevila
added a commit
that referenced
this pull request
Nov 22, 2024
…201356) # Backport This will backport the following commits from `main` to `8.x`: - [[Feature Flags Example Plugin] Change ctx provider (#201097)](#201097) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T12:01:02Z","message":"[Feature Flags Example Plugin] Change ctx provider (#201097)","sha":"f0262080c806077876604569f2e7fd8a7082cf00","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Core","release_note:skip","v9.0.0","backport:prev-minor"],"number":201097,"url":"https://github.com/elastic/kibana/pull/201097","mergeCommit":{"message":"[Feature Flags Example Plugin] Change ctx provider (#201097)","sha":"f0262080c806077876604569f2e7fd8a7082cf00"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201097","number":201097,"mergeCommit":{"message":"[Feature Flags Example Plugin] Change ctx provider (#201097)","sha":"f0262080c806077876604569f2e7fd8a7082cf00"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <[email protected]>
kibanamachine
added
v8.18.0
and removed
backport missing
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplifying the
application.tsxof the Feature Flags Example Plugincc @gsoldevila