Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @elastic/request-converter to renovate.json #200588

Merged

Conversation

sabarasaba
Copy link
Member

@sabarasaba sabarasaba commented Nov 18, 2024

Fixes #197357

Summary

Add request-converter dependency to renovate.json and assign it to @elastic/kibana-management to review.

Dependency was added in #189976

@sabarasaba sabarasaba added chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Nov 18, 2024
@sabarasaba sabarasaba self-assigned this Nov 18, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #27 / serverless search UI Elasticsearch Start [Onboarding Empty State] developer should show the api key in code view
  • [job] [logs] FTR Configs #4 / upgrade assistant Kibana API Deprecations returns deprecated APIs when the api is called

Metrics [docs]

✅ unchanged

cc @sabarasaba

@sabarasaba sabarasaba marked this pull request as ready for review November 18, 2024 19:15
@sabarasaba
Copy link
Member Author

@elasticmachine merge upstream

@sabarasaba sabarasaba requested a review from a team November 19, 2024 09:14
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sabarasaba sabarasaba merged commit 0bb6293 into elastic:main Nov 20, 2024
22 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11931411942

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 20, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 20, 2024
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Add @elastic/request-converter to renovate.json
(#200588)](#200588)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ignacio
Rivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-20T10:23:38Z","message":"Add
@elastic/request-converter to renovate.json
(#200588)","sha":"0bb62939f09b98ea51cbf998e60f5e796d6176f2","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"Add
@elastic/request-converter to renovate.json
","number":200588,"url":"https://github.com/elastic/kibana/pull/200588","mergeCommit":{"message":"Add
@elastic/request-converter to renovate.json
(#200588)","sha":"0bb62939f09b98ea51cbf998e60f5e796d6176f2"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200588","number":200588,"mergeCommit":{"message":"Add
@elastic/request-converter to renovate.json
(#200588)","sha":"0bb62939f09b98ea51cbf998e60f5e796d6176f2"}}]}]
BACKPORT-->

Co-authored-by: Ignacio Rivas <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) chore release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[console] Automate upgrades of request-converter package
4 participants