[8.15] [Infra] Change order of the errors shown on Infra pages (#200531) #200575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#200190 ## Summary This PR fixes the issue with the errors shown on the metrics explorer page - when the metrics indices can't be fetched we should show the error returned and if there is no fetch error and a remote cluster configured but no connection is possible we should show the remote cluster error: - Example with 504 error  - Example with remote cluster error  ## Testing Couldn't find a way to reproduce this so I "faked" the API response to be an error and checked several cases - API returns an error, we should show the error: https://github.com/user-attachments/assets/c1086b22-1ff5-4333-97a5-b3d1dca16afe - API doesn't return an error but the remote cluster connection wasn't possible, we should show the remote cluster error: https://github.com/user-attachments/assets/151b3ae4-5ca1-4d54-bd58-2729db202cdb - If no remote cluster is used/or a remote cluster is connected and the API response is not returning an error the page should load correctly: https://github.com/user-attachments/assets/f9ef1066-3dfd-4957-8b46-878bf58d2f1c (cherry picked from commit 46d4c84) # Conflicts: # x-pack/plugins/observability_solution/infra/public/pages/metrics/page_template.tsx
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub commentsJust comment with: - `/oblt-deploy` : Deploy a Kibana instance using the Observability test environments. - `run` `docs-build` : Re-trigger the docs validation. (use unformatted text in the comment!) |
rmyz
approved these changes
Nov 18, 2024
miloszmarcinkowski
approved these changes
Nov 18, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.15:Questions ?
Please refer to the Backport tool documentation