-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add isBeta flag to add data module schema #20049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:enhancement
Feature:Add Data
Add Data and sample data feature on Home
v7.0.0
v6.4.0
labels
Jun 19, 2018
💔 Build Failed |
💚 Build Succeeded |
stacey-gammon
approved these changes
Jun 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code lgtm, pull down and verified adding the flag will display the beta heading.
chrisdavies
approved these changes
Jun 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jun 25, 2018
* add isBeta flag to add data module schema * remove changes to packages/kbn-es/yarn.lock * do not put empty flex item in dom * update snapshots
nreese
added a commit
that referenced
this pull request
Jun 25, 2018
mattapperson
pushed a commit
that referenced
this pull request
Jun 28, 2018
* add isBeta flag to add data module schema * remove changes to packages/kbn-es/yarn.lock * do not put empty flex item in dom * update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17679
When add data module specifies
isBeta
, UI will display module as beta statusTo test, added
isBeta: true
to any add data module file in https://github.com/elastic/kibana/tree/master/src/core_plugins/kibana/server/tutorials. As an example for screen shots, I added it to apache logs tutorial