Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isBeta flag to add data module schema #20049

Merged
merged 4 commits into from
Jun 25, 2018
Merged

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Jun 19, 2018

fixes #17679

When add data module specifies isBeta, UI will display module as beta status

To test, added isBeta: true to any add data module file in https://github.com/elastic/kibana/tree/master/src/core_plugins/kibana/server/tutorials. As an example for screen shots, I added it to apache logs tutorial

screen shot 2018-06-19 at 1 32 27 pm

screen shot 2018-06-19 at 1 32 20 pm

@nreese nreese added release_note:enhancement Feature:Add Data Add Data and sample data feature on Home v7.0.0 v6.4.0 labels Jun 19, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, pull down and verified adding the flag will display the beta heading.

Copy link
Contributor

@chrisdavies chrisdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nreese nreese merged commit a1d44c1 into elastic:master Jun 25, 2018
nreese added a commit to nreese/kibana that referenced this pull request Jun 25, 2018
* add isBeta flag to add data module schema

* remove changes to packages/kbn-es/yarn.lock

* do not put empty flex item in dom

* update snapshots
nreese added a commit that referenced this pull request Jun 25, 2018
* add isBeta flag to add data module schema

* remove changes to packages/kbn-es/yarn.lock

* do not put empty flex item in dom

* update snapshots
mattapperson pushed a commit that referenced this pull request Jun 28, 2018
* add isBeta flag to add data module schema

* remove changes to packages/kbn-es/yarn.lock

* do not put empty flex item in dom

* update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add Data] Design input for Beta modules
4 participants