[AI Connector] Change completion subAction schema to be OpenAI compatible #200249

YulNaumenko · 2024-11-14T19:52:55Z

…

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_node:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

See some risk examples
...

…ible

…:YulNaumenko/kibana into ai-connector-inference-completion-openai

stephmilovic · 2024-12-11T19:36:02Z

x-pack/plugins/stack_connectors/common/inference/schema.ts

+     * `none` is the default when no tools are present. `auto` is the default if tools
+     * are present.
+     */
+    tool_choice: schema.maybe(


Am I supposed to do a transform on the OpenAI function_call to make it into tool_choice?

kibana/x-pack/plugins/stack_connectors/common/openai/schema.ts

Lines 92 to 103 in b4ccb0c

function_call: schema.maybe(

schema.oneOf([

schema.literal('none'),

schema.literal('auto'),

schema.object(

{

name: schema.string(),

},

{ unknowns: 'ignore' }

),

])

),

correct, we should stop using the deprecated way of function_call usage and migrate to tool_choice and tools

x-pack/plugins/stack_connectors/server/connector_types/inference/inference.ts

…:YulNaumenko/kibana into ai-connector-inference-completion-openai

…nce-completion-openai

x-pack/plugins/stack_connectors/common/inference/constants.ts

x-pack/plugins/stack_connectors/server/connector_types/inference/inference.ts

stephmilovic · 2024-12-17T17:11:52Z

x-pack/plugins/stack_connectors/server/connector_types/inference/inference.test.ts

      ).rejects.toThrow('API Error');
    });

    it('responds with a readable stream', async () => {
-      const response = await connector.performApiCompletionStream({
-        input: 'What is Elastic?',
+      const response = await connector.performApiUnifiedCompletionStream({


Can you please add tests for the async iterator method as well?

x-pack/plugins/stack_connectors/server/connector_types/inference/inference.ts

ymao1

response ops changes LGTM. looks like all schema changes are to non-persisted schemas so no intermediate release issues.

stephmilovic

I have a draft PR to test Security AI Assistant and Attack Discovery. Both are working with the inference connector configured with OpenAI. Nice work Yuliia! LGTM

kibanamachine · 2024-12-18T05:13:34Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12386809368

elasticmachine · 2024-12-18T05:13:44Z

💚 Build Succeeded

Buildkite Build
Commit: 699b0a9

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`stackConnectors`	659.5KB	660.5KB	+1.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`stackConnectors`	58.5KB	59.0KB	+481.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`stackConnectors`	128	129	+1

Total ESLint disabled count

id	before	after	diff
`stackConnectors`	134	135	+1

History

💔 Build #261575 failed ed6107b
💔 Build #261509 failed 2d2ebde
💔 Build #261205 failed f811503
💔 Build #261199 failed a70051b
💔 Build #261178 failed 36a6f67
💔 Build #261166 failed 6ded610

cc @YulNaumenko

kibanamachine · 2024-12-18T05:18:21Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts You might need to backport the following PRs to 8.x: - [Inference Connector] Changed UI/UX due to the new RFC for the _inference/_service (#203363) - [Inference Connector] Modified getProvider to use _inference/_services ES API instead of hardcoded values. (#199047)

Manual backport

To create the backport manually run:

node scripts/backport --pr 200249

Questions ?

Please refer to the Backport tool documentation

…ible (elastic#200249) … ## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... (cherry picked from commit 6eaa1d0)

pgayvallet · 2024-12-18T09:34:15Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…compatible (#200249) (#204701) # Backport This will backport the following commits from `main` to `8.x`: - [[AI Connector] Change completion subAction schema to be OpenAI compatible (#200249)](#200249)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  --------- Co-authored-by: Yuliia Naumenko <[email protected]>

…ible (elastic#200249) … ## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_node:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...

YulNaumenko added 9 commits November 14, 2024 11:51

[AI Connector] Change completion subAction schema to be OpenAI compat…

f04ab4c

…ible

-

af94594

Merge branch 'main' into ai-connector-inference-completion-openai

697c73c

Merge branch 'main' into ai-connector-inference-completion-openai

7428e6f

Merge branch 'ai-connector-inference-completion-openai' of github.com…

f17c678

…:YulNaumenko/kibana into ai-connector-inference-completion-openai

added unified completion support

2847a11

-

3a03150

Merge branch 'main' into ai-connector-inference-completion-openai

f14b3ec

added dashboard and async iterator

bf34578

stephmilovic reviewed Dec 11, 2024

View reviewed changes

x-pack/plugins/stack_connectors/server/connector_types/inference/inference.ts Outdated Show resolved Hide resolved

stephmilovic reviewed Dec 11, 2024

View reviewed changes

x-pack/plugins/stack_connectors/server/connector_types/inference/inference.ts Outdated Show resolved Hide resolved

YulNaumenko added 3 commits December 11, 2024 18:02

fixed headers

f3b6a75

fixed params

72041b5

Merge branch 'main' into ai-connector-inference-completion-openai

9cec4cb

YulNaumenko marked this pull request as ready for review December 12, 2024 16:06

YulNaumenko requested review from a team as code owners December 12, 2024 16:06

YulNaumenko added 2 commits December 15, 2024 20:06

made the regular stream and non-stream working

79c5c3b

Merge branch 'main' into ai-connector-inference-completion-openai

27512b5

YulNaumenko self-assigned this Dec 16, 2024

YulNaumenko added 8.18 candidate v8.18.0 v9.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels labels Dec 16, 2024

YulNaumenko added 2 commits December 15, 2024 21:38

Merge branch 'ai-connector-inference-completion-openai' of github.com…

8ce2707

…:YulNaumenko/kibana into ai-connector-inference-completion-openai

merge fix

cc7993b

YulNaumenko requested a review from a team as a code owner December 16, 2024 05:45

YulNaumenko added 3 commits December 16, 2024 13:51

tool calls fix

e0ee923

improved

042e813

-

6ded610

stephmilovic mentioned this pull request Dec 16, 2024

[Security assistant] Use inference connector #204505

Draft

YulNaumenko added 3 commits December 16, 2024 16:15

streaming

36a6f67

fixed test

a70051b

fixed streaming

f811503

pgayvallet mentioned this pull request Dec 17, 2024

[inference] Add support for inference connectors #204541

Open

Merge remote-tracking branch 'upstream/main' into ai-connector-infere…

2d2ebde

…nce-completion-openai

stephmilovic reviewed Dec 17, 2024

View reviewed changes

x-pack/plugins/stack_connectors/common/inference/constants.ts Show resolved Hide resolved

stephmilovic reviewed Dec 17, 2024

View reviewed changes

x-pack/plugins/stack_connectors/server/connector_types/inference/inference.ts Outdated Show resolved Hide resolved

stephmilovic reviewed Dec 17, 2024

View reviewed changes

x-pack/plugins/stack_connectors/server/connector_types/inference/inference.ts Outdated Show resolved Hide resolved

YulNaumenko added 2 commits December 17, 2024 11:45

fixed due to comments

232fbe9

excluded n

ed6107b

ymao1 approved these changes Dec 17, 2024

View reviewed changes

stephmilovic approved these changes Dec 17, 2024

View reviewed changes

YulNaumenko added 2 commits December 17, 2024 19:44

fixed tests

4ccb8f3

Merge branch 'main' into ai-connector-inference-completion-openai

699b0a9

YulNaumenko enabled auto-merge (squash) December 18, 2024 03:45

YulNaumenko merged commit 6eaa1d0 into elastic:main Dec 18, 2024
8 checks passed

pgayvallet mentioned this pull request Dec 18, 2024

[8.x] [AI Connector] Change completion subAction schema to be OpenAI compatible (#200249) #204701

Merged

kibanamachine mentioned this pull request Dec 18, 2024

Fix context.pageName by fixing missing executionContext and add enableExecutionContextTracking flag #204547

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AI Connector] Change completion subAction schema to be OpenAI compatible #200249

[AI Connector] Change completion subAction schema to be OpenAI compatible #200249

YulNaumenko commented Nov 14, 2024 •

edited by kibanamachine

Loading

stephmilovic Dec 11, 2024

YulNaumenko Dec 12, 2024

stephmilovic Dec 17, 2024

ymao1 left a comment

stephmilovic left a comment

kibanamachine commented Dec 18, 2024

elasticmachine commented Dec 18, 2024

ESLint disabled line counts

Total ESLint disabled count

kibanamachine commented Dec 18, 2024

pgayvallet commented Dec 18, 2024

	function_call: schema.maybe(
	schema.oneOf([
	schema.literal('none'),
	schema.literal('auto'),
	schema.object(
	{
	name: schema.string(),
	},
	{ unknowns: 'ignore' }
	),
	])
	),

[AI Connector] Change completion subAction schema to be OpenAI compatible #200249

[AI Connector] Change completion subAction schema to be OpenAI compatible #200249

Conversation

YulNaumenko commented Nov 14, 2024 • edited by kibanamachine Loading

Summary

Checklist

Identify risks

stephmilovic Dec 11, 2024

Choose a reason for hiding this comment

YulNaumenko Dec 12, 2024

Choose a reason for hiding this comment

stephmilovic Dec 17, 2024

Choose a reason for hiding this comment

ymao1 left a comment

Choose a reason for hiding this comment

stephmilovic left a comment

Choose a reason for hiding this comment

kibanamachine commented Dec 18, 2024

elasticmachine commented Dec 18, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

kibanamachine commented Dec 18, 2024

💔 All backports failed

Manual backport

Questions ?

pgayvallet commented Dec 18, 2024

💚 All backports created successfully

Questions ?

YulNaumenko commented Nov 14, 2024 •

edited by kibanamachine

Loading